Your message dated Sat, 20 Aug 2022 21:21:24 +0000
with message-id <[email protected]>
and subject line Bug#1017569: fixed in urlview 0.9-23
has caused the Debian Bug report #1017569,
regarding urlview: Mangles non-ASCII URLs for display
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1017569: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017569
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: urlview
Version: 0.9-21+b1
Severity: normal
Tags: patch
Dear Maintainer,
I ~often receive URLs that end in a fancy quote (or close enough);
this can be reproduced with
echo https://example.com/a” | urlview
which displays
UrlView 0.9: (1 matches) Press Q or Ctrl-C to Quit!
-> 1 https://example.com/a�~@~]
I've narrowed it down to being linked to narrow-character ncurses(??)
and am attaching a patch (based on current Salsa) and have opened
https://salsa.debian.org/debian/urlview/-/merge_requests/3
Best,
наб
-- System Information:
Debian Release: 11.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500,
'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.10.0-16-amd64 (SMP w/24 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND,
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages urlview depends on:
ii libc6 2.31-13+deb11u3
ii libncurses6 6.2+20201114-2
ii libtinfo6 6.2+20201114-2
ii sensible-utils 0.0.14
Versions of packages urlview recommends:
ii lynx [www-browser] 2.9.0dev.6-3~deb11u1
ii w3m [www-browser] 0.5.3+git20210102-6
Versions of packages urlview suggests:
pn mutt <none>
pn ncftp | lftp <none>
ii wget 1.21-1+deb11u1
-- no debconf information
From 957868f8722c76907840c214d83fca3c86971c9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?= <[email protected]>
Date: Wed, 17 Aug 2022 22:26:27 +0200
Subject: [PATCH 1/2] d/control: depend on libcurses-dev directly
X-Mutt-PGP: OS
libncurses5-dev is a "transitional package for libncurses-dev"
---
debian/changelog | 3 ++-
debian/control | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 0292d4f..9d83027 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,8 +3,9 @@ urlview (0.9-23) UNRELEASED; urgency=medium
* d/url_handler: don't require bash for no reason, shellcheck-clean
* d/README.Debian: align with reality w.r.t. url_handler.sh
Closes: #1017562
+ * d/control: depend on libcurses-dev directly
- -- наб <[email protected]> Wed, 17 Aug 2022 21:42:22 +0200
+ -- наб <[email protected]> Wed, 17 Aug 2022 22:28:38 +0200
urlview (0.9-22) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index 527952d..e7384b5 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Maintainer: Emanuele Rocca <[email protected]>
Standards-Version: 4.2.0
Vcs-Browser: https://salsa.debian.org/debian/urlview
Vcs-Git: https://salsa.debian.org/debian/urlview.git
-Build-Depends: libncurses5-dev, debhelper (>= 13)
+Build-Depends: libncurses-dev, debhelper (>= 13)
Package: urlview
Architecture: any
--
2.30.2
From 6a2f08ab28343e8c5b7c7ab4a64f09beb913fd91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?= <[email protected]>
Date: Wed, 17 Aug 2022 22:33:38 +0200
Subject: [PATCH 2/2] Link against libncursesw, setlocale(LC_ALL, "")
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Mutt-PGP: OS
On https://example.com/a” (i.e. a fancy quote), urlview with
narrow-character curses makes an absolute hash of it, by writing it as:
https://example.com/a�~@~]
When linked against the wide-character ncurses, it displays it exactly
as expected, in the original form.
---
configure.in | 2 +-
debian/changelog | 3 ++-
urlview.c | 3 +++
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/configure.in b/configure.in
index 45e4e89..7bbd68e 100644
--- a/configure.in
+++ b/configure.in
@@ -24,7 +24,7 @@ AC_ARG_WITH(slang, [ --with-slang[=DIR] use S-Lang instead of curses],
LIBS="$LIBS -lslang -lm"
fi],
- [AC_CHECK_LIB(ncurses, initscr, [LIBS="$LIBS -lncurses"], [LIBS="$LIBS -lcurses"])
+ [AC_CHECK_LIB(ncursesw, initscr, [LIBS="$LIBS -lncursesw"], [LIBS="$LIBS -lcurses"])
AC_CHECK_FUNCS(curs_set)
AC_CHECK_HEADERS(ncurses.h)
AC_CHECK_HEADER(ncurses/curses.h, [CPPFLAGS="$CPPFLAGS -I/usr/include/ncurses"])])
diff --git a/debian/changelog b/debian/changelog
index 9d83027..ffe47ea 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,8 +4,9 @@ urlview (0.9-23) UNRELEASED; urgency=medium
* d/README.Debian: align with reality w.r.t. url_handler.sh
Closes: #1017562
* d/control: depend on libcurses-dev directly
+ * Link against libncursesw, fixing display of non-ASCII URLs
- -- наб <[email protected]> Wed, 17 Aug 2022 22:28:38 +0200
+ -- наб <[email protected]> Wed, 17 Aug 2022 22:39:23 +0200
urlview (0.9-22) unstable; urgency=medium
diff --git a/urlview.c b/urlview.c
index 9281bbb..7b28408 100644
--- a/urlview.c
+++ b/urlview.c
@@ -32,6 +32,7 @@
#endif /* USE_SLANG */
#include <pwd.h>
+#include <locale.h>
#include <string.h>
#include <unistd.h>
#include <ctype.h>
@@ -144,6 +145,8 @@ void search_backward (char *search, int urlcount, char **url, int *redraw, int *
int main (int argc, char **argv)
{
+ setlocale(LC_ALL, "");
+
struct passwd *pw;
struct stat stat_buf;
#ifndef USE_SLANG
--
2.30.2
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: urlview
Source-Version: 0.9-23
Done: Emanuele Rocca <[email protected]>
We believe that the bug you reported is fixed in the latest version of
urlview, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Emanuele Rocca <[email protected]> (supplier of updated urlview package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 20 Aug 2022 22:17:46 +0200
Source: urlview
Architecture: source
Version: 0.9-23
Distribution: unstable
Urgency: medium
Maintainer: Emanuele Rocca <[email protected]>
Changed-By: Emanuele Rocca <[email protected]>
Closes: 598508 693785 933388 1017562 1017569
Changes:
urlview (0.9-23) unstable; urgency=medium
.
[ Emanuele Rocca ]
* d/url_handler.sh: properly use nohup or suppress STDERR.
Thanks Daniel Reichelt for the patch. Closes: #933388
* d/README.Debian: do not mention mimedecode, the package has been removed a
while ago. Closes: #693785
* Allow dumping URLs to stdout by setting the URLVIEW_DEBUG environment
variable. Thanks Francois Lallart. Closes: #598508
* Fix warning about implicit declaration of function 'quote'.
Thanks Joshua Root for the patch.
* Enable Salsa CI Pipeline.
* Add autopkgtests.
* d/control: set Standards-Version to 4.6.1.
.
[ наб ]
* d/url_handler.sh: do not require bash for no reason, shellcheck-clean
* d/README.Debian: align with reality w.r.t. url_handler.sh
Closes: #1017562
* d/control: depend on libcurses-dev directly
* Link against libncursesw, fixing display of non-ASCII URLs
Closes: #1017569
Checksums-Sha1:
f3082c6d9691749d720e75eef33338dd47925991 1763 urlview_0.9-23.dsc
678ac0cbcf20117cadfe6d14bb868b9de7c35e33 171844 urlview_0.9-23.diff.gz
b27973e7d25509b1aeea55bb8fe1d6efb241cb9c 6288 urlview_0.9-23_amd64.buildinfo
Checksums-Sha256:
49c4854d507b7b15f7e84f817428c7ba20a8e5a1d97acd21ab1a5dbf598c483e 1763
urlview_0.9-23.dsc
32dcff6d032ae23f100a42cb7b23573338033b5e0613b20813324ddb417ce86f 171844
urlview_0.9-23.diff.gz
0776164711b633b6aa8b815a2cbfaed3dee155b5d295db10fd27f497710fbde4 6288
urlview_0.9-23_amd64.buildinfo
Files:
31d64c15184e435b9290f0eeb7252550 1763 misc optional urlview_0.9-23.dsc
0ba6c17b6cce97b53199fb2039939e05 171844 misc optional urlview_0.9-23.diff.gz
c76c2ed2414f400fff4b5883d0e8e574 6288 misc optional
urlview_0.9-23_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEElUWWlhkoHBf/rFiR1QhaB1D9t6MFAmMBTlMACgkQ1QhaB1D9
t6N5nw//YLCeJV8A9LQQkbo1twf1EsPuMbDUlAJGAd6sWNM+SdTFqAgUw56f8Gpd
GD58gAdCarwhH4eHwqPrqTd8pGKKu7yY8zDgsn9Bkpl4bKBxGkhSaDGLiA5nYfmZ
wIwzbejdjygQmg6kFpXTWb3UoSzJkF0K60bfbLrJ8pfM17ViHvMOIhthh66A4rnL
vICw2ZiVwsYUSkW6XhtjSSRH/9FbV40iYOekJa1Y5aTNL/6K2ogqKwSuV9kZtjBa
2Z5mO2joAV+tzWMfWntPzq0ncNYDTCmpavwAPRYoV77TEyrxvCDx9hcI/KIsPD7n
/zVdyYe6MtM9WIrCvNr4be+25xmuFCABKmKPZoWNbkMwfvA5xQlKeZYv1GZh3U/b
NwAcOWxwthAZQ6N4bp6m0cfICUjyHNUKJD9Fnm1NAiLLHBBYUGO2r+V6TPH6wEjn
FIoDfu3/ZxC7QlsVAJ3EejbNSAOj5LhoTnbaXUXoTYd8ki44cjyo/IRd8B6FEWox
NjMr/hZufwdLVlVPR3irWVP6TzNIc+3J4wUrEpDS/yeR5t6gKviPIuojqV0KWu+R
mfvtHwzUmbw8ZnRcM2WhKb/Er8Mn1Hl2YeeKMyRUFP8L3IoBkQsFWo4KMy1wLc0t
PS88aevAoYkmaHHqR0RlI3HJfSezWWGF7xTmUJJmnsjWjO6LNpM=
=Taqj
-----END PGP SIGNATURE-----
--- End Message ---
