Your message dated Thu, 15 Sep 2022 22:25:40 -0400
with message-id 
<CAD+GYvw6fcfOEm69on5LK=a_vjc0pvd80qlo8mpv4jjxsg0...@mail.gmail.com>
and subject line re, harfbuzz: Please make autopkgtests cross-test-friendly
has caused the Debian Bug report #946446,
regarding harfbuzz: Please make autopkgtests cross-test-friendly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
946446: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946446
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: harfbuzz
Version: 2.6.4-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

The harfbuzz tests currently fail in this environment, because they are
build tests that do not invoke the toolchain in a cross-aware manner.  I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment.  Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
[email protected]                                     [email protected]
diff -Nru harfbuzz-2.6.4/debian/tests/build harfbuzz-2.6.4/debian/tests/build
--- harfbuzz-2.6.4/debian/tests/build   2019-11-02 19:37:28.000000000 -0700
+++ harfbuzz-2.6.4/debian/tests/build   2019-12-08 21:37:00.000000000 -0800
@@ -7,6 +7,13 @@
 WORKDIR=$(mktemp -d)
 trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM
 cd $WORKDIR
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
 cat <<EOF > hbtest.c
 #include <hb.h>
 #include <stdio.h>
@@ -18,7 +25,7 @@
 }
 EOF
 
-gcc -o hbtest hbtest.c `pkg-config --cflags --libs harfbuzz`
+${CROSS_COMPILE}gcc -o hbtest hbtest.c `${CROSS_COMPILE}pkg-config --cflags 
--libs harfbuzz`
 echo "build: OK"
 [ -x hbtest ]
 ./hbtest

--- End Message ---
--- Begin Message ---
Version: 5.1.0-1

--- End Message ---

Reply via email to