Your message dated Fri, 16 Sep 2022 21:51:24 +0000
with message-id <[email protected]>
and subject line Bug#1010760: fixed in minetest 5.6.0+dfsg+~1.9.0mt7+dfsg-1
has caused the Debian Bug report #1010760,
regarding minetest: Floating point serialization error on x86
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1010760: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010760
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: minetest
Version: 5.3.0+repack-2.1+deb11u1
Severity: normal
Tags: patch upstream
X-Debbugs-Cc: [email protected]
Dear Maintainer,
Minetest in versions lower than 5.5.0 is being miscompiled by GCC on
x86. To verify this bug, run Minetest using “minetest --run-unittests”
on x86 and look for the following three lines:
Test assertion failed: readF1000(is) == 53.534f
at test_serialization.cpp:308
[FAIL] testStreamRead - 0ms
The reason for this is that the x87 FPU computes in 80bit precision by
default, while IEEE-754 requires 64 bit precision.
There exist two ways to solve this. Upstream forces SSE2 for floating
point calculations, by adding the following to CMakeLists.txt on x86:
--- start of patch ---
# use SSE for floating-point operations to avoid issues with improper
fp-rounding and loss of precision
# when moving fp-data to incompatible or less-precise registers/storage
locations
# see https://gcc.gnu.org/wiki/FloatingPointMath and
https://gcc.gnu.org/wiki/x87note
add_compile_options(-mfpmath=sse -msse2)
--- end of patch ---
A non-SSE2 way is to achieve this is to use the compiler option “-mpc64”.
Both achieve the same goal, calculating with 64 bit precision instead of
doing calculations with 80 bit precision and then rounding the result to
64 bit (which makes the unit test fail).
I therefore suggest to instead try the following to CMakeLists.txt on x86:
--- start of patch ---
# Limit x87 FPU to 64 bit precision to avoid floating point precision
# errors. See both https://gcc.gnu.org/wiki/FloatingPointMath and
# https://gcc.gnu.org/wiki/x87note for more details about this.
add_compile_options(-mpc64)
--- end of patch ---
If you use the latter, verify that this makes the testStreamRead not fail.
There is no need to upstream this change, as it has already been fixed
in Minetest 5.5.0, but since it affects serialization, it might lead to
some crashes or maybe even security bugs if Minetest 5.3.x and 5.4.x are
being distributed in ways that floating point calculations are miscompiled.
For full context, see <https://github.com/minetest/minetest/issues/11810>.
-- System Information:
Debian Release: 11.3
APT prefers stable
APT policy: (900, 'stable'), (500, 'oldoldstable')
Architecture: i386 (i686)
Kernel: Linux 5.10.0-10-686 (SMP w/2 CPU threads)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages minetest depends on:
ii libc6 2.31-13+deb11u3
ii libcurl3-gnutls 7.74.0-1.3+deb11u1
ii libfreetype6 2.10.4+dfsg-1
ii libgcc-s1 10.2.1-6
ii libgmp10 2:6.2.1+dfsg-1+deb11u1
ii libirrlicht1.8 1.8.4+dfsg1-1.1
ii libjsoncpp24 1.9.4-4
ii libleveldb1d 1.22-3
ii libluajit-5.1-2 2.1.0~beta3+dfsg-5.3
ii libncursesw6 6.2+20201114-2
ii libopenal1 1:1.19.1-2
ii libpq5 13.5-0+deb11u1
ii libspatialindex6 1.9.3-2
ii libsqlite3-0 3.34.1-3
ii libstdc++6 10.2.1-6
ii libtinfo6 6.2+20201114-2
ii libvorbisfile3 1.3.7-1
ii libx11-6 2:1.7.2-1
ii minetest-data 5.3.0+repack-2.1+deb11u1
ii zlib1g 1:1.2.11.dfsg-2
minetest recommends no packages.
Versions of packages minetest suggests:
pn minetest-mod-moreblocks <none>
pn minetest-mod-moreores <none>
pn minetest-mod-pipeworks <none>
pn minetest-server <none>
pn minetestmapper <none>
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: minetest
Source-Version: 5.6.0+dfsg+~1.9.0mt7+dfsg-1
Done: Tobias Frost <[email protected]>
We believe that the bug you reported is fixed in the latest version of
minetest, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Tobias Frost <[email protected]> (supplier of updated minetest package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 16 Sep 2022 23:09:33 +0200
Source: minetest
Architecture: source
Version: 5.6.0+dfsg+~1.9.0mt7+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Tobias Frost <[email protected]>
Closes: 996663 1010760 1010827 1019871
Changes:
minetest (5.6.0+dfsg+~1.9.0mt7+dfsg-1) unstable; urgency=medium
.
* Team upload.
* New upstream version. Closes: #1019871.
- CVE-2022-35978.patch is no longer needed.
- New upstream version Closes: #1010827, #996663
- Upstream fixed security issues:
- HTTP API access control bypass (no CVE issued)
* Patches:
- Refreshing patches.
- Forwarding fix-typos.patch upstream.
* As upstream requires SSE3 to function properly, depend on sse3-support to
ensure minetest can only installed on i386 machines with that CPU feature.
(Closes: #1010760)
* Review d/copyright.
* Bump S-V to 4.6.1 -- no changes required.
* Don't install optimize_textures.sh.
* Build with debug infos.
* Enable unittests during build.
* Add autopkgtest.
- Add patch to make unittests not requiring build directory be available.
* Enable out-of-tree build, so that cleanup is easier.
* Add custom salsa-ci.yaml to override repotest.
Checksums-Sha1:
aef766a58f6e8ea4ca7082ae772ebd8aaa07b1e2 3426
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.dsc
5966246bb60d9261bb2ba4445b4cf6fd83fe9848 633088
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-irrlicht.tar.xz
357d0c584c1d029de0ddd3282eb7e16725dcb37e 2191940
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-mtg.tar.xz
8c947c3d67646eb92ac9f673c1502805b2e7ea59 6243268
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig.tar.xz
a6aa772c3c5388784ed5f174ee04cab299e34882 41840
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.debian.tar.xz
2ee0d83b6a0d195e73454787400af8d2f775b2f6 15111
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1_amd64.buildinfo
Checksums-Sha256:
c6abd6da77b047da7995fa1e5b36b82db5705940c284954d2bb45ef8d558c506 3426
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.dsc
baea62f72ac17e246370527d4163c6b224e9b2f2a49266f2cc62d46509e4bd54 633088
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-irrlicht.tar.xz
435b4316336d9a4c72dde15f33f641258d9d2a20d60eed912f6717f0b95814d1 2191940
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-mtg.tar.xz
17414aeb8899a8c6167c8d871cabd6e9bf2d82d15a67bffa1c430843bfc076bc 6243268
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig.tar.xz
581009cffd44248a9523253111107e888cdeb2cb803667274d4f09739a4983f6 41840
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.debian.tar.xz
ee56509986423de84d5f7a3dbfd099093da38844954f39df45be7c5f06134df7 15111
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1_amd64.buildinfo
Files:
49fd96835c7c20b91f583ba9b48b0180 3426 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.dsc
fe08c2ea1cbcdfe5eb121c2c6b5750ba 633088 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-irrlicht.tar.xz
f1f07ae5fe8dfa46a9cf8ae951e42a2c 2191940 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig-mtg.tar.xz
f46c7e106cef2452acf1374c94b917cc 6243268 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg.orig.tar.xz
6a633e205fa85e9d79f5413eece0f00f 41840 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1.debian.tar.xz
c89fe0779d9c01b2f072accb00220510 15111 games optional
minetest_5.6.0+dfsg+~1.9.0mt7+dfsg-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE/d0M/zhkJ3YwohhskWT6HRe9XTYFAmMk7F8ACgkQkWT6HRe9
XTZQ3xAAi1EiZZNV2rKBAWp/xFW/MLmUUEmOv5RZswqBvRdRPv4SPIr2ZdzWfbru
cAAwm9QNBThCTNAq80w3MkqEra/+b/i3wXVjHzfKoYVN7VNzAATAWXN6Ge1goeAi
28+dpdb4S4K7t2y2NB+tgpxfwOxqFyD0CeXLo7BKbTBqq9XBMNNunETh0RbYmIkF
RzrZmO+wnXjrsG0tY6cvU7keRMUTFUcQ4QoHVQ4/u5NqiAa0M5TpC5pdXhVUMuFF
+4MvloPEP96asG6afySYcCKuqye60yTBOLeQ4hmF+B0sA4+FI8iXI6kISkgt6DbI
F7jsLfv3NUtL/2Dol2/9SntgznlehcW68EuHwzBy/GkA11c40gxUuLziRU4vj+NG
NpJA9lCgoL5tO2y2HnW2tAJzCNfuoPaZsja1b26OEmaMYI8aVm3sQxttc/ShgLaG
l+6Z9L7Y/rohIyc6OZSKxiIvwt0zpZlGvRgmwAyfreDdl+1C6D7iLwYkkLtOJJVK
jvJlb7IMCA2ZqQdQpzdU9cUZs/T4Uo3IqrnYnjBOJlRBSU7iZn1RR+jPqXKDGk1Q
z7ZQ7RzkbvDU7YfAWVsOOuzW8xBOG/yftoqYZOyT8USZH+28F7gb4XTsVot2QcZ0
QYn0+27ZIZnJjoTRTC2i8ZigDAt6WWSpOpjMZtIDz6rmGWyGKU4=
=tZ7d
-----END PGP SIGNATURE-----
--- End Message ---
