Your message dated Tue, 20 Sep 2022 11:36:08 +0000
with message-id <[email protected]>
and subject line Bug#977832: fixed in fai 6.0~alpha3
has caused the Debian Bug report #977832,
regarding fai-setup-storage: setup-storage fails if old disk setup contains a 
VG with plus sign in its name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
977832: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977832
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.9.4
Severity: normal

Dear Maintainer,

setup-storage fails to setup a disk if the disk already contains a VG with a 
plus sign in its name.

Minimized disk setup that causes the issue:
```
$ parted --script /dev/loop0 print free
Model: Loopback device (loopback)
Disk /dev/loop2: 128MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags: 

Number  Start   End    Size   File system  Name     Flags
 1      17.4kB  128MB  128MB               primary  lvm

$ lsblk /dev/loop0
NAME           MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
loop2            7:2    0 122.1M  0 loop 
└─loop2p1      259:7    0   122M  0 part 
  └─old_vg-a+b 253:5    0   120M  0 lvm  
```



Minimized disk config that reproduces the issue:
```
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
```

The setup-storage error message I get for this combination:
```
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b 
-- system left untouched.
```

The impact is that setup-storage can't resetup the disk.
If I remove the `+` from `a+b` then the issue doesn't happen.
If I remove the `disk_config lvm` line then the issue doesn't happen.
We've encountered this issue with existing machines that have been previously 
installed with Debian Installer.

Best,

Michael Schaller


setup-storage debug output:
```
disklist: loop0
Starting setup-storage 2.3
Using config file: <redacted>
Input was:
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
(CMD) parted -s /dev/loop0 unit TiB print 1> /tmp/DawnyWaUqw 2> /tmp/1CdIC7E2lZ
Executing: parted -s /dev/loop0 unit TiB print
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 0.00TiB
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start    End      Size     File system  Name     Flags
(STDOUT)  1      0.00TiB  0.00TiB  0.00TiB               primary  lvm
(STDOUT) 
(CMD) parted -s /dev/loop0 unit B print free 1> /tmp/6y8bZKl8j9 2> 
/tmp/cRw5eJZBPo
Executing: parted -s /dev/loop0 unit B print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 128000000B
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start   End         Size        File system  Name     Flags
(STDOUT)  1      17408B  127983103B  127965696B               primary  lvm
(STDOUT) 
(CMD) parted -s /dev/loop0 unit chs print free 1> /tmp/JpcgqNuRbJ 2> 
/tmp/fAQl87C8ra
Executing: parted -s /dev/loop0 unit chs print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 490,49,1
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) BIOS cylinder,head,sector geometry: 490,255,2.  Each cylinder is 261kB.
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start   End       File system  Name     Flags
(STDOUT)  1      0,17,0  490,33,0               primary  lvm
(STDOUT) 
Ignoring volume group: dhcp-100-105-1-216-vg
Current disk layout in %current_config
$VAR1 = {
          '/dev/loop0' => {
                            'sector_size' => '512',
                            'bios_sectors_per_track' => '2',
                            'size' => '128000000',
                            'partitions' => {
                                              '1' => {
                                                       'flags' => 'lvm',
                                                       'filesystem' => '',
                                                       'count_byte' => 
'127965696',
                                                       'is_extended' => 0,
                                                       'begin_byte' => '17408',
                                                       'end_byte' => '127983103'
                                                     }
                                            },
                            'begin_byte' => 0,
                            'bios_cylinders' => '490',
                            'bios_heads' => '255',
                            'disklabel' => 'gpt',
                            'end_byte' => 127999999
                          }
        };
Current LVM layout in %current_lvm_config
$VAR1 = {
          'old_vg' => {
                        'physical_volumes' => [
                                                '/dev/loop0p1'
                                              ],
                        'size' => '120.000839233398',
                        'volumes' => {
                                       'a+b' => {
                                                  'size' => '120.000839233398'
                                                }
                                     }
                      }
        };
Current RAID layout in %current_raid_config
$VAR1 = {};
Current device tree in %current_dev_children
$VAR1 = {
          'VG_old_vg' => [
                           '/dev/old_vg/a+b'
                         ],
          '/dev/loop0p1' => [
                              'VG_old_vg'
                            ],
          '/dev/loop0' => [
                            '/dev/loop0p1'
                          ]
        };
Desired disk layout in %FAI::configs
$VAR1 = {
          'VG_--ANY--' => {
                            'opts_all' => {},
                            'fstabkey' => 'device'
                          },
          'PHY_/dev/loop0' => {
                                'partitions' => {
                                                  '1' => {
                                                           'encrypt' => 0,
                                                           'start_byte' => 
1048576,
                                                           'mountpoint' => '-',
                                                           'filesystem' => '-',
                                                           'size' => {
                                                                       
'always_format' => 0,
                                                                       
'extended' => 0,
                                                                       
'eff_size' => 126934528,
                                                                       'resize' 
=> 0,
                                                                       'range' 
=> '126934528-126934528',
                                                                       
'preserve' => 0
                                                                     },
                                                           'mount_options' => 
'-',
                                                           'end_byte' => 
127983103
                                                         }
                                                },
                                'bootable' => -1,
                                'fstabkey' => 'device',
                                'preserveparts' => 0,
                                'disklabel' => 'gpt',
                                'opts_all' => {},
                                'virtual' => 0
                              }
        };
Desired device tree in %FAI::dev_children
$VAR1 = {
          '/dev/loop0' => [
                            '/dev/loop0p1'
                          ]
        };
Erased devices: /dev/loop0p1
Trying to add CMD: true
PRE: 
POST: exist_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: vgchange -a y old_vg
PRE: 
POST: pre_wipe_old_vg
Trying to add CMD: wipefs -a /dev/old_vg/a+b
PRE: pre_wipe_old_vg,
POST: wipefs_old_vg/a+b
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Trying to add CMD: vgremove old_vg
PRE: vgchange_a_n_VG_old_vg,lv_rm_old_vg/a+b
POST: vg_removed_old_vg
Trying to add CMD: pvremove  /dev/loop0p1
PRE: vg_removed_old_vg
POST: pvremove_old_vg
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: pvremove_old_vg
POST: pv_sigs_removed_wipe_/dev/loop0p1_old_vg
Trying to add CMD: true
PRE: pvremove_old_vg,pv_sigs_removed_wipe_/dev/loop0p1_old_vg
POST: pv_sigs_removed_old_vg
Trying to add CMD: true
PRE: vgchange_a_n_VG_old_vg,pv_sigs_removed_old_vg,self_cleared_/dev/old_vg/a+b
POST: self_cleared_VG_old_vg
Trying to add CMD: true
PRE: cleared2_/dev/loop0,exist_/dev/loop0p1
POST: pt_complete_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b 
-- system left untouched.
```

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha3
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 20 Sep 2022 12:02:28 +0200
Source: fai
Architecture: source
Version: 6.0~alpha3
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha3) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 5ed8f18fc1f4e62e6084d13b3e78fa1ddd425f5b 2070 fai_6.0~alpha3.dsc
 842a482c26f6b22546e9728b7f7752571bb97f45 291024 fai_6.0~alpha3.tar.xz
 929dc9f581e06564c3fe5bcdbd4c81d7b195be4c 16281 fai_6.0~alpha3_amd64.buildinfo
Checksums-Sha256:
 6df39296be8bb6abc97c6fdb38078713872cd05531d7a38df1bdcd7323091f9d 2070 
fai_6.0~alpha3.dsc
 a928a6cf9e871d44d3d9175226f2444eb0810cf2f2e42855240097ea5cd7bb8b 291024 
fai_6.0~alpha3.tar.xz
 0cc886edb3aea2fe4716e1c2f7dda39eac8664e9f08e9512d2073375cf94ae70 16281 
fai_6.0~alpha3_amd64.buildinfo
Files:
 770b1729c3c586ff565acfecbfc8f7f6 2070 admin optional fai_6.0~alpha3.dsc
 07dd4be79b25ddbe361f5092de20ddd9 291024 admin optional fai_6.0~alpha3.tar.xz
 753a1a8da14dfb61fafe6a3a7cbb04b7 16281 admin optional 
fai_6.0~alpha3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMpj9oRHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeQwKhAAlQSYkOy5GsJ7z21Itku6CDdlsK7yVcj9
3WFWrDVl/KAuqkYVt0R3c0sEAPASAmXrFuThLq3vLTBFBBhOv/ZTWcAZCCqYeo9j
JhbLVY7BltVAd6VclYK6ZHz0tsTfqvmnzsHs4IsfBtNMPXL1H7KLll0Wnwx/fsfC
T8fxfN5jVJy7ThWw+Ah4KQs9W74t9lp20jcga5SEWuDSS++oGkSvWaZl3hDY9Wfp
VqAJZCCl2E9I6cdDmBPrAbARkTsG31zmBgnMh7vxNDV2ccq/L+eAbVeL+6UhiLaC
dLYVhwy97lBvJY8Cb+l1sbZ/evUfe6o3e39Et3yWFYHrYCBmdVrRLNYI+1zqyhIw
rjaZY6SoMcXZOer0QkMonf4BvPzCrKvGGd+uHMMAF+0v94YtDalkRbBjLF19yEIm
StmeHzK0DpUTLGCbwsR3QzbECCwhtLXK7btUdYs+iymrvyrMH0MlK3rIaDbELr8n
yYSWHQSzjG+FDqRH+H/7+UBmFa3N8tWfOc4DZFQ3yG+NwfBPKNNMEbCPXzhJLUN4
w9QNNxYKCgxT2HAhjWagJbUd3sOjdXmhUquWS3xcCiizBTcNKcAeyzNeXHv9EQkJ
ifg41dVOSraA4o7++5BttohG30RU4QbojWC9Sa9K1dc77FRwQJJFakyCJX6i9iGu
OxDlL0soryA=
=XZ9E
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to