Your message dated Sun, 25 Sep 2022 13:30:43 +0800
with message-id
<cafyclw-krewwgozajqwhjedfyp3nweeheqnhsosrgkwfxmh...@mail.gmail.com>
and subject line Re: Bug#944271: dh_golang_autopkgtest: overrides
dh_auto_configure
has caused the Debian Bug report #944271,
regarding dh_golang_autopkgtest: overrides dh_auto_configure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
944271: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944271
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-golang
Version: 1.42
Severity: important
Affects: -1 src:umoci
Control: blocks 943891 by -1
dh_golang_autopkgtest needlessly overrides dh_auto_configure:
https://salsa.debian.org/go-team/packages/dh-golang/blob/master/script/dh_golang_autopkgtest#L83
There are numerous problems with that. First of all this is redundant
and should only be done by the package. Secondly the behavior of override
is not identical to what build system does which causes weird failures
on packages that build successfully. Thirdly, current behavior throws
away important parts of source tree (e.g. "vendor" directory) where
essential code is usually shipped. Finally clean-up of "vendor" directory
is not the job of autopkgtest.
Current behavior affects other packages and their migration to "testing".
Notable case is "umoci" package and #943891 where autopkgtest fails to build
"umoci" due to incorrect behavior of autopkgtest's dh_auto_configure override
(lines 104...113). (Note that "umoci" have no "override_dh_auto_configure").
--
Best wishes,
Dmitry Smirnov
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---
On Thu, Nov 7, 2019 at 1:27 PM Dmitry Smirnov <[email protected]> wrote:
>
> Package: dh-golang
> Version: 1.42
> Severity: important
> Affects: -1 src:umoci
> Control: blocks 943891 by -1
>
> dh_golang_autopkgtest needlessly overrides dh_auto_configure:
>
>
> https://salsa.debian.org/go-team/packages/dh-golang/blob/master/script/dh_golang_autopkgtest#L83
>
> There are numerous problems with that. First of all this is redundant
> and should only be done by the package. Secondly the behavior of override
> is not identical to what build system does which causes weird failures
> on packages that build successfully. Thirdly, current behavior throws
> away important parts of source tree (e.g. "vendor" directory) where
> essential code is usually shipped. Finally clean-up of "vendor" directory
> is not the job of autopkgtest.
>
> Current behavior affects other packages and their migration to "testing".
>
> Notable case is "umoci" package and #943891 where autopkgtest fails to build
> "umoci" due to incorrect behavior of autopkgtest's dh_auto_configure override
> (lines 104...113). (Note that "umoci" have no "override_dh_auto_configure").
>
FTR, umoci currently has a successful autopkgtest-pkg-go. Thus I think
we can close this now.
--
Shengjing Zhu
--- End Message ---
