Your message dated Sun, 25 Sep 2022 11:37:30 +0000
with message-id <[email protected]>
and subject line Bug#977832: fixed in fai 6.0~alpha13
has caused the Debian Bug report #977832,
regarding fai-setup-storage: setup-storage fails if old disk setup contains a 
VG with plus sign in its name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
977832: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977832
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.9.4
Severity: normal

Dear Maintainer,

setup-storage fails to setup a disk if the disk already contains a VG with a 
plus sign in its name.

Minimized disk setup that causes the issue:
```
$ parted --script /dev/loop0 print free
Model: Loopback device (loopback)
Disk /dev/loop2: 128MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags: 

Number  Start   End    Size   File system  Name     Flags
 1      17.4kB  128MB  128MB               primary  lvm

$ lsblk /dev/loop0
NAME           MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
loop2            7:2    0 122.1M  0 loop 
└─loop2p1      259:7    0   122M  0 part 
  └─old_vg-a+b 253:5    0   120M  0 lvm  
```



Minimized disk config that reproduces the issue:
```
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
```

The setup-storage error message I get for this combination:
```
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b 
-- system left untouched.
```

The impact is that setup-storage can't resetup the disk.
If I remove the `+` from `a+b` then the issue doesn't happen.
If I remove the `disk_config lvm` line then the issue doesn't happen.
We've encountered this issue with existing machines that have been previously 
installed with Debian Installer.

Best,

Michael Schaller


setup-storage debug output:
```
disklist: loop0
Starting setup-storage 2.3
Using config file: <redacted>
Input was:
disk_config disk1 disklabel:gpt
primary - 0- - -
disk_config lvm
(CMD) parted -s /dev/loop0 unit TiB print 1> /tmp/DawnyWaUqw 2> /tmp/1CdIC7E2lZ
Executing: parted -s /dev/loop0 unit TiB print
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 0.00TiB
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start    End      Size     File system  Name     Flags
(STDOUT)  1      0.00TiB  0.00TiB  0.00TiB               primary  lvm
(STDOUT) 
(CMD) parted -s /dev/loop0 unit B print free 1> /tmp/6y8bZKl8j9 2> 
/tmp/cRw5eJZBPo
Executing: parted -s /dev/loop0 unit B print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 128000000B
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start   End         Size        File system  Name     Flags
(STDOUT)  1      17408B  127983103B  127965696B               primary  lvm
(STDOUT) 
(CMD) parted -s /dev/loop0 unit chs print free 1> /tmp/JpcgqNuRbJ 2> 
/tmp/fAQl87C8ra
Executing: parted -s /dev/loop0 unit chs print free
(STDOUT) Model: Loopback device (loopback)
(STDOUT) Disk /dev/loop0: 490,49,1
(STDOUT) Sector size (logical/physical): 512B/512B
(STDOUT) BIOS cylinder,head,sector geometry: 490,255,2.  Each cylinder is 261kB.
(STDOUT) Partition Table: gpt
(STDOUT) Disk Flags: 
(STDOUT) 
(STDOUT) Number  Start   End       File system  Name     Flags
(STDOUT)  1      0,17,0  490,33,0               primary  lvm
(STDOUT) 
Ignoring volume group: dhcp-100-105-1-216-vg
Current disk layout in %current_config
$VAR1 = {
          '/dev/loop0' => {
                            'sector_size' => '512',
                            'bios_sectors_per_track' => '2',
                            'size' => '128000000',
                            'partitions' => {
                                              '1' => {
                                                       'flags' => 'lvm',
                                                       'filesystem' => '',
                                                       'count_byte' => 
'127965696',
                                                       'is_extended' => 0,
                                                       'begin_byte' => '17408',
                                                       'end_byte' => '127983103'
                                                     }
                                            },
                            'begin_byte' => 0,
                            'bios_cylinders' => '490',
                            'bios_heads' => '255',
                            'disklabel' => 'gpt',
                            'end_byte' => 127999999
                          }
        };
Current LVM layout in %current_lvm_config
$VAR1 = {
          'old_vg' => {
                        'physical_volumes' => [
                                                '/dev/loop0p1'
                                              ],
                        'size' => '120.000839233398',
                        'volumes' => {
                                       'a+b' => {
                                                  'size' => '120.000839233398'
                                                }
                                     }
                      }
        };
Current RAID layout in %current_raid_config
$VAR1 = {};
Current device tree in %current_dev_children
$VAR1 = {
          'VG_old_vg' => [
                           '/dev/old_vg/a+b'
                         ],
          '/dev/loop0p1' => [
                              'VG_old_vg'
                            ],
          '/dev/loop0' => [
                            '/dev/loop0p1'
                          ]
        };
Desired disk layout in %FAI::configs
$VAR1 = {
          'VG_--ANY--' => {
                            'opts_all' => {},
                            'fstabkey' => 'device'
                          },
          'PHY_/dev/loop0' => {
                                'partitions' => {
                                                  '1' => {
                                                           'encrypt' => 0,
                                                           'start_byte' => 
1048576,
                                                           'mountpoint' => '-',
                                                           'filesystem' => '-',
                                                           'size' => {
                                                                       
'always_format' => 0,
                                                                       
'extended' => 0,
                                                                       
'eff_size' => 126934528,
                                                                       'resize' 
=> 0,
                                                                       'range' 
=> '126934528-126934528',
                                                                       
'preserve' => 0
                                                                     },
                                                           'mount_options' => 
'-',
                                                           'end_byte' => 
127983103
                                                         }
                                                },
                                'bootable' => -1,
                                'fstabkey' => 'device',
                                'preserveparts' => 0,
                                'disklabel' => 'gpt',
                                'opts_all' => {},
                                'virtual' => 0
                              }
        };
Desired device tree in %FAI::dev_children
$VAR1 = {
          '/dev/loop0' => [
                            '/dev/loop0p1'
                          ]
        };
Erased devices: /dev/loop0p1
Trying to add CMD: true
PRE: 
POST: exist_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: vgchange -a y old_vg
PRE: 
POST: pre_wipe_old_vg
Trying to add CMD: wipefs -a /dev/old_vg/a+b
PRE: pre_wipe_old_vg,
POST: wipefs_old_vg/a+b
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Trying to add CMD: vgremove old_vg
PRE: vgchange_a_n_VG_old_vg,lv_rm_old_vg/a+b
POST: vg_removed_old_vg
Trying to add CMD: pvremove  /dev/loop0p1
PRE: vg_removed_old_vg
POST: pvremove_old_vg
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: pvremove_old_vg
POST: pv_sigs_removed_wipe_/dev/loop0p1_old_vg
Trying to add CMD: true
PRE: pvremove_old_vg,pv_sigs_removed_wipe_/dev/loop0p1_old_vg
POST: pv_sigs_removed_old_vg
Trying to add CMD: true
PRE: vgchange_a_n_VG_old_vg,pv_sigs_removed_old_vg,self_cleared_/dev/old_vg/a+b
POST: self_cleared_VG_old_vg
Trying to add CMD: true
PRE: cleared2_/dev/loop0,exist_/dev/loop0p1
POST: pt_complete_/dev/loop0
Trying to add CMD: wipefs -af /dev/loop0p1
PRE: exist_/dev/loop0,self_cleared_VG_old_vg
POST: wipefs_/dev/loop0p1
Trying to add CMD: true
PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1
POST: cleared1_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mklabel gpt
PRE: cleared1_/dev/loop0
POST: cleared2_/dev/loop0
Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B
PRE: cleared2_/dev/loop0
POST: prep2_/dev/loop0p1
Trying to add CMD: true
PRE: prep2_/dev/loop0p1
POST: exist_/dev/loop0p1
Trying to add CMD: vgchange -a n old_vg
PRE: self_cleared_/dev/old_vg/a+b
POST: vgchange_a_n_VG_old_vg
Trying to add CMD: lvremove -f /dev/old_vg/a+b
PRE: wipefs_old_vg/a+b
POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b
Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b 
-- system left untouched.
```

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha13
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 25 Sep 2022 11:18:43 +0200
Source: fai
Architecture: source
Version: 6.0~alpha13
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha13) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 4a99bf2bd25c7c743c462c0a207c2375de9330d3 2094 fai_6.0~alpha13.dsc
 6ceece444056ddd4a916a8a2431a89d5bd5d25a6 291084 fai_6.0~alpha13.tar.xz
 471d70f6ef42e8d214b93993b96962b95ced5c22 16303 fai_6.0~alpha13_amd64.buildinfo
Checksums-Sha256:
 6bd6d69e996987a47918d213b3b8aeb2cc5cf02c620053d1908efe4c5e591b77 2094 
fai_6.0~alpha13.dsc
 12b7705cc69e843815f53f09d5041c437e657b5f112bbd033b40123cb1994534 291084 
fai_6.0~alpha13.tar.xz
 263ced4df083d3c3f94d74c8dcb1439e0e56fdb7d43027de4b339e8e11260d8b 16303 
fai_6.0~alpha13_amd64.buildinfo
Files:
 0acd8017e07a2cf0a5a638bc5ee1f528 2094 admin optional fai_6.0~alpha13.dsc
 c6f46b53cd40c52c2631cff81693206c 291084 admin optional fai_6.0~alpha13.tar.xz
 b41e1a1ed90432d9e54fd911d223b095 16303 admin optional 
fai_6.0~alpha13_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMwHSURHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeR00hAAtHlzETXADiHwdcZq29qmhBWWkdII7kJz
HsF2p2kDhTr4pAzRf7kFQLsvDiESRGfaIM66/Vv+n/fSyK+SeGfFmyyi6XrMfBza
eBu+zOg1FCFTIBu3EoF2/7oKCs7xDpLrW1AN073p4TwYZ1QUSAvtNiNxXd6pL1PP
kRqWv1L6wVm72q98a8BnBzmpLx1K/fQncdiOnYm0gP784NEuwBV7iu8W21rma2Wf
6yhw+gaHG4bRdKzu5G/hpyp4SSgcczH6Fbu4iUV8vYUypjs3yro+di+OXEJHfm+F
KBpmpLh2nLKG4wYyEfN/Azf4rAAqk/o90+3Dc9j1tIeiG+Xw99yGFbF2AIX3vcAH
JicgX/cYM4R/clklSlAx3W0Xh+TWwavCSTrty1MQwSs/IiNQO/wz3ORZmoGDxCPx
aJOYkBtacKH2hh4u6fGG+hqQOZ6+zGBdiZ/Iyqehm/4YAMafG5WtpJiMNy62QjhL
PmKN7qQ4oF8EQc0B7llk6xzac7hFmLNNqmumS1Cq+u7wG465IbwIdsYT7dFK1o1t
ojxQeRXwRnnDc5LVgOpZa8wOsVLmgi/KufVgr/p7Adfc0hKZrx841NW8scETp8bZ
tYFu4c15UeUpjdZGcGHSscTp/oPUpeVq0f1wYJHeOKhcfkDeWkFLorrigpuLaN27
DFykxAcfpUg=
=NshZ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to