Your message dated Sun, 25 Sep 2022 11:37:37 +0000
with message-id <[email protected]>
and subject line Bug#999739: fixed in fai 6.0~alpha14
has caused the Debian Bug report #999739,
regarding fai-setup-storage: BTRFS-RAID on NVMe fails to install
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
999739: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999739
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.8.4
Severity: normal
Tags: patch

Dear Maintainer,

I observed an issue trying to setup an BTRFS RAID on NVMe disks. I
have used FAI version 5.8.4, however, I think that the bug is still
present in version 5.10.3.

My disk configuration (I deliberately have the 2nd partition
unconfigured):

    disk_config disk1 disklabel:gpt-bios fstabkey:uuid
    primary     -       32G         -       -
    primary     -       -100%       -       -

    disk_config disk2 sameas:disk1

    disk_config btrfs fstabkey:uuid
    btrfs raid1 /       disk1.1,disk2.1 
rw,degraded,noatime,nodiratime,compress=lzo,subvol=@ createopts="-L root"

Installing this on a machine with two disks /dev/nvme0n1 and
/dev/nvme1n1 terminated with the error:

    Cannot satisfy pre-depends for mkfs.btrfs -d raid1 -L root -f   \
    /dev/nvme1n1p1 /dev/nvme0n1p1: pt_complete_/dev/nvmen1p1, --    \
    system left untouched.

Looking into /usr/share/fai/setup-storage/Commands.pm, sub
"build_btrfs_commands", I noticed that line 365 (`$tmp =~ s/\d//;`)
apparently tries to strip the partition number off a partition path.
This is, unfortunately, too simple for these NVMe disks. I changed the
regular expression to only strip the partition no at the end, including
any preceding "p":

    $tmp =~ s/p?\d+$//;

At least my system could install successfully with this patch. It
would, however, now fail for "/dev/sdpX", so maybe the regex should
explicitly handle NVMe disks.

Best,
Maximilian

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha14
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 25 Sep 2022 11:18:43 +0200
Source: fai
Architecture: source
Version: 6.0~alpha14
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha14) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 bef30b7ffd8c25f8666292c8afdf7a08f21fa362 2094 fai_6.0~alpha14.dsc
 09fcd518ba142fd0d89e5bd94bf26ba2df4d02e7 291024 fai_6.0~alpha14.tar.xz
 31c935b3c25bd2429ad425f0cd7b534738038ad2 16303 fai_6.0~alpha14_amd64.buildinfo
Checksums-Sha256:
 24cdbd24f59c27d35df7a98fb24ceea194d67d9c8189831b0842aa3b5083b6e2 2094 
fai_6.0~alpha14.dsc
 4369a78406d35255621b5b4a41cf5e96e4fddc5c1da6e38319b387add985568e 291024 
fai_6.0~alpha14.tar.xz
 2d2ee9025aeaa3ba4e63aa3d9ed7e26c78287239a987849ba5a14ebb409b0c93 16303 
fai_6.0~alpha14_amd64.buildinfo
Files:
 8774809b06e8a0058f9b0bc206f47bb4 2094 admin optional fai_6.0~alpha14.dsc
 911c7c498cdde59b47a460e2fa16c9c1 291024 admin optional fai_6.0~alpha14.tar.xz
 b2e975f62faaac25ef1cfa24e3697672 16303 admin optional 
fai_6.0~alpha14_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMwKNIRHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeQUYhAApFsuA/c5nZ+R4xdhY9oWplsdB+5gfLDE
/N7nHuFLCWgPHcXCkFURMWNEDmkNzj5Q8kKATG6JlSL3HDUnxEzaadoC7ZO5OLRV
amMz9SW0nWx9kNhbEC12K5pwToTCGfJGsREbTy2b22sAxIJtPNz65oMsxCNtoxNE
5dj11UBzlWErnlWTMRnq7QQPpOjGn8vIdxYLsLaA9TJ+w36sWTjbpI8HZAsK6QUH
c9A5cH9kV/xk2AkiFyG953iCIapzx53smlnvKAFRnCTpcSAXH3bA8bnpc67ByzsJ
OJMRAzSYTk/5uXpNXRQ/Xmb78i6orSxORJ2BkdBanv0SuJM2F3lkm3pQrPvkTYvM
qLVtVkpuzppOGb+WaTQj3KuWoPsGBiOP+58foDkNGBlq0dE41yfuZyD9doNUU7Wd
S33Kc/qywcvZDfiizsfKUYQNIOaPEpMrTH9xXOJ55zqc+YeGcCX2Nnh/TuOm67IS
WPmHAy3/qomlZ74awEIxCP6vrNsDkLXkJoVAGvD/t2kx1mXVjkimczv5CGt9DPnf
rvKKwQUC4ogrjzR79klTuEqW1dLXstwpCltxwFWbPoPlEyzxAF3dFqEtb1H0YKWy
lAKlQtBeLUR9JzTDi4Rl07CPC9p/bY8vO8n9mkixz35DgCYKDlNmuAlM/ypMeugU
SRvt+VFDO+4=
=0Azm
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to