Your message dated Sun, 30 Oct 2022 18:19:27 +0000
with message-id <[email protected]>
and subject line Bug#1023137: fixed in clickhouse 18.16.1+ds-7.3~exp2
has caused the Debian Bug report #1023137,
regarding clickhouse: FTBFS when building from packaging (e.g salsa) git 
repository.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1023137: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023137
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: clickhouse
Version: 18.16.1+ds-7.2
Severity: normal
Tags: patch

When a git repository is present, upstream CMakeLists.txt is checking whether 
the
submodules (which contains 3rd party libraries). As those are stripped in 
Debian,
the build fails.

Attached quilt patch comments out the CMakeList.txt section which checks this, 
so working
with the git repository for e.g bug triaging / patch creation becomes easier.

-- 
tobi

Description: Make CMakeLists.txt ignoring git submodules.
 The embedded boost is removed, so CMake will fail believing that stuff is missing.
Author: Tobias Frost <[email protected]>
Forwarded: not-needed, Debian specific.
Reviewed-by: <name and email of a reviewer, optional>
Last-Update: 2022-10-29 <YYYY-MM-DD, last update of the meta-information, optional>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -17,10 +17,11 @@
     message (WARNING "You are using an unsupported compiler. Compilation has only been tested with Clang 5+ and GCC 7+.")
 endif ()
 
-# Check that submodules are present only if source was downloaded with git
-if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/.git" AND NOT EXISTS "${ClickHouse_SOURCE_DIR}/contrib/boost/boost")
-    message (FATAL_ERROR "Submodules are not initialized. Run\n\tgit submodule update --init --recursive")
-endif ()
+# Interferes when bulding Debian package from git repository.
+## Check that submodules are present only if source was downloaded with git
+#if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/.git" AND NOT EXISTS "${ClickHouse_SOURCE_DIR}/contrib/boost/boost")
+#    message (FATAL_ERROR "Submodules are not initialized. Run\n\tgit submodule update --init --recursive")
+#endif ()
 
 # Write compile_commands.json
 set(CMAKE_EXPORT_COMPILE_COMMANDS 1)

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: clickhouse
Source-Version: 18.16.1+ds-7.3~exp2
Done: Tobias Frost <[email protected]>

We believe that the bug you reported is fixed in the latest version of
clickhouse, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tobias Frost <[email protected]> (supplier of updated clickhouse package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 30 Oct 2022 18:57:29 +0100
Source: clickhouse
Architecture: source
Version: 18.16.1+ds-7.3~exp2
Distribution: experimental
Urgency: medium
Maintainer: Alexander GQ Gerasiov <[email protected]>
Changed-By: Tobias Frost <[email protected]>
Closes: 1023136 1023137
Changes:
 clickhouse (18.16.1+ds-7.3~exp2) experimental; urgency=medium
 .
   * New patch 0000-cmake-ignore-git-submodules.patch to avoid FTBFS when
     working from the packaging git repo. (Closes: #1023137)
   * Skip test 00700_decimal_math fails. Seems to be a rounding error. See
     #1023141.
   * Fix testsuite invocation on archs where a test is disabled.
     (Closes: #1023136)
   * Skip test_unit_tests_dbms, it hangs… See #1023145.
Checksums-Sha1:
 3be0fb3e5c75055d742d512ed520f6aeeb24f448 3225 
clickhouse_18.16.1+ds-7.3~exp2.dsc
 b9b0be2e4a309b3fc89a21c330633c5cfaebf963 26724 
clickhouse_18.16.1+ds-7.3~exp2.debian.tar.xz
 3f4e50b28a7d10c0041595702f14e0c9681e7243 12968 
clickhouse_18.16.1+ds-7.3~exp2_source.buildinfo
Checksums-Sha256:
 00e8e2157452fca841ff281e62e92ab3b461f00e0da2ff1269beaf16babbe24e 3225 
clickhouse_18.16.1+ds-7.3~exp2.dsc
 890c8b91c5f6d3ecbca334a8ceaba3031cbf9034c560822f76d8555437694519 26724 
clickhouse_18.16.1+ds-7.3~exp2.debian.tar.xz
 9369cdd73d2582a13f71f38c57de9eab5661593f2040af52dba18572bb2ef302 12968 
clickhouse_18.16.1+ds-7.3~exp2_source.buildinfo
Files:
 ab9cd2cdd789c901f59b971196dd934a 3225 database optional 
clickhouse_18.16.1+ds-7.3~exp2.dsc
 40825dfe9373ab3a710df1623bd4a2eb 26724 database optional 
clickhouse_18.16.1+ds-7.3~exp2.debian.tar.xz
 a3f0331298e593efe506795c4b194c1b 12968 database optional 
clickhouse_18.16.1+ds-7.3~exp2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE/d0M/zhkJ3YwohhskWT6HRe9XTYFAmNevcEACgkQkWT6HRe9
XTYC6Q/9FG3Vu3kAS3DxG1k/rsAn2JqYMQnko5deLsmOSX9zkp0VMIe8vpqKN3Q1
KqS6L65lB1vNNvFA+ByzcmMXzoD9mhJOKNjGSgK/dVfzGOw5K6TXJvhQiBfky4pU
AMaZM55lQPceJbD+f70vrtfW7kHSu933bxQVOz3L4Rh4ZBuAIunIp6GgLlYi4KPb
2fLPrqayI1WxDfH6bIyCOqgMuW9ZY7wAVS3Nvx4KRZaAquUUl4pBqGOVhH4MiRxf
QQle5TX7n14UEmYIjTSoCBLakGdumQPduu1AoKeD/YnJEoiFn1BWx2A0og4YZmy7
rUQQD0l2LMVe/uwVr9ShWtNVWIkO6wpr8c1MZ1mH/WkJ+X6eUdixvntRz8tHCZ47
pskE6hqlivIrF5jkH1kvOahtS4PAwGDIKjqQJ/4abhGGMY2rNSngdzV137OVKPEl
oyl6LLhIy82ESKh06YUyB2tUKjzVl4NmVfhQ6F1PupeaNGoicLg87u/IgKA3z6Ht
c5bEPrQBAOwBQaEkJebSsM4yTV6KqA8/F3yXKNthn/pwXBy0FtXbhjdvCzvhZvxM
9tAs3T7DaCzlQxzuMA+caeuLJY79/RdsLWZJXz3U4wNxH6JcohMTyB29qFkNwTXP
fDIXLOy9FahlwOvwlDNL/R4g9+kzremTpX8b4Jbrp5U0ytqGp08=
=ngJl
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to