Your message dated Wed, 02 Nov 2022 21:06:14 +0000
with message-id <[email protected]>
and subject line Bug#1010665: fixed in sbuild 0.84.0
has caused the Debian Bug report #1010665,
regarding sbuild-createchroot should not hardcode a default mirror
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1010665: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010665
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sbuild
Version: 0.83.1
Severity: wishlist

sbuild-createchroot has an optional mirror argument, however if this is not
provided it has its own hardcoded mirror it uses when calling debootstrap.

This is unfortunate as debootstrap (and by extension sbuild) will happily work
with other distributions (such as ubuntu).

Included is a patch which makes sbuild let debootrap pick the mirror instead.

-- System Information:
Debian Release: 10.12
 APT prefers oldstable-updates
 APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-9-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
From 5fd7b6e404c8f5cf5c644199cc0626a71f969736 Mon Sep 17 00:00:00 2001
From: Mattias Jernberg <[email protected]>
Date: Fri, 6 May 2022 14:16:46 +0200
Subject: [PATCH] bin/sbuild-createchroot: Do not hardcode mirror argument to
 debootstrap

debootstrap understands distros better than sbuild, for instance it
has profiles for Ubuntu. By not giving the mirror argument when it
wasn't specified debootstrap will make the right choice of mirror
for Ubuntu as well, making it possible to do

  sbuild-createchroot focal /sbuild/focal-root

and having it work magically.
---
 bin/sbuild-createchroot | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/bin/sbuild-createchroot b/bin/sbuild-createchroot
index 7a106ef7..f504b3ff 100755
--- a/bin/sbuild-createchroot
+++ b/bin/sbuild-createchroot
@@ -334,15 +334,15 @@ if (-e $target) {
 }
 $target = abs_path($target);
 my $script = undef;
-my $mirror = "http://deb.debian.org/debian";;
+my $mirror = undef;
 
 $mirror = $ARGV[2] if $#ARGV >= 2;
-$script = $ARGV[3] if $#ARGV == 3;
+$script = $ARGV[3] if $#ARGV >= 3;
 
 if ($conf->get('VERBOSE')) {
     print "I: SUITE: $suite\n";
     print "I: TARGET: $target\n";
-    print "I: MIRROR: $mirror\n";
+    print "I: MIRROR: $mirror\n" if (defined($mirror));
     print "I: SCRIPT: $script\n" if (defined($script));
 }
 
@@ -363,7 +363,8 @@ if ($conf->get('MERGED_USR') ne 'auto') {
 	push @args, $conf->get('MERGED_USR') ?
 	    "--merged-usr" : "--no-merged-usr";
 }
-push @args, "$suite", "$target", "$mirror";
+push @args, "$suite", "$target";
+push @args, "$mirror" if $mirror;
 push @args, "$script" if $script;
 
 # Set the path to debootstrap
-- 
2.20.1


--- End Message ---
--- Begin Message ---
Source: sbuild
Source-Version: 0.84.0
Done: Johannes Schauer Marin Rodrigues <[email protected]>

We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Johannes Schauer Marin Rodrigues <[email protected]> (supplier of updated sbuild 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 02 Nov 2022 21:42:11 +0100
Source: sbuild
Architecture: source
Version: 0.84.0
Distribution: unstable
Urgency: medium
Maintainer: sbuild maintainers <[email protected]>
Changed-By: Johannes Schauer Marin Rodrigues <[email protected]>
Closes: 1006135 1010665 1014574 1016070
Changes:
 sbuild (0.84.0) unstable; urgency=medium
 .
   [ Johannes Schauer Marin Rodrigues ]
   * bin/sbuild-createchroot: die if move() fails
   * bin/sbuild-debian-developer-setup: Don't alias to sid/UNRELEASED if suite
     is not unstable (Closes: #1014574)
   * debian/copyright: update copyright for makefiles and debian/*
   * debian/tests/unshare-qemuwrapper: allow ~/.ssh to exist already
   * debian/tests/unshare-qemuwrapper: bump disk size to 4G (Closes: #1016070)
   * debian/tests/unshare: don't fail if gpghome cannot be removed
   * debian/tests/unshare: gpgconf --kill all before removing gpghome
   * debian/tests/unshare: run with --no-source-only-changes
   * debian/tests/unshare: run with --nolog to output log to stdout
   * lib/Sbuild/Build.pm: automatically add a deb-src entry if necessary
   * lib/Sbuild/ResolverBase.pm: factor out add_extra_repositories()
   * lib/Sbuild/ResolverBase.pm: stop emitting Packages.gz and Sources.gz
   * man/sbuild-qemu-boot.1.in: fix typo Bood -> Boot
   * man/sbuild.1.in: unshare chroot mode is not experimental anymore
 .
   [ Benjamin Drung ]
   * Fix shellcheck issues in autopkgtests
   * Revert "debian/tests/build-procenv: add deb-src repository"
   * Run unshare autopkgtest against target release
   * Set NO_PKG_MANGLE=1 when building dummy packages
   * unshare-qemuwrapper: Cleanup guestfs appliance
   * unshare-qemuwrapper: Disable SSH password authentication
   * unshare-qemuwrapper: Support Ubuntu
   * unshare-qemuwrapper: Use free port
   * unshare-qemuwrapper: Use linux-image-cloud-amd64
   * unshare-qemuwrapper: Use sbuild in temp directory name
 .
   [ Dave Jones ]
   * Ensure umask is consistent with the comparison blobs
 .
   [ Christoph Berg ]
   * run_autopkgtest: Accept exit 2 as pass
 .
   [ Andrea Pappacoda ]
   * sbuild-debian-developer-setup: alias the chroot to UNRELEASED-$arch-sbuild
     (Closes: #1006135)
 .
   [ Mattias Jernberg ]
   * bin/sbuild-createchroot: Do not hardcode mirror argument to debootstrap
     (Closes: #1010665)
 .
   [ Ben Westover ]
   * sbuild-debian-developer-setup: Add option to specify chroot architecture
 .
   [ Jochen Sprickerhof ]
   * Replace adduser by useradd
   * Unshare: create sbuild group
Checksums-Sha1:
 2f872f45f5d4dbefb8990e6e4fadc75867dacbc3 2533 sbuild_0.84.0.dsc
 2238c76f9bc20b1da2d9b7c23a6401590cfa4a7b 258528 sbuild_0.84.0.tar.xz
Checksums-Sha256:
 fdb78430330a612d6142ad43ed4e99a4bb4b7c8122b6abc7314e041c3d0e4b6a 2533 
sbuild_0.84.0.dsc
 9503e107faf3f5eb49dbc18b45e2d3f5ca892ab4dcd3e44c965fb21792162ad6 258528 
sbuild_0.84.0.tar.xz
Files:
 07759f326aa26eb752f70047c51c8fdc 2533 devel optional sbuild_0.84.0.dsc
 912028311b07e8fdf88be221d9a05eeb 258528 devel optional sbuild_0.84.0.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmNi1lkACgkQ8sulx4+9
g+Epdw//d6QcLvZqpdfzCiLod9M3O2cPVjGzowt5vfNY1z+MO4vINIoV6FBdT7MF
hLuiwmbcU8wDS4u1sgNNuhEgI2XgM4+wIbD2rik7+LisoMfshu9Uo2zNBom40T35
eLym/JNlhI/iWOFBJRLAY1Zsa2ieRSqMXX3OcjnRop+kncUqQ0wzN2JeTq6wSUdo
JDIvBC+lMjEY/CAKUpE/ish7eoOOokcXonmn6om2ho5GmB37GH9oT7BN/YUUU5XZ
kI6q4G7r4Og1nsoJcx+KzYZtS4MXZ+aVFOBUMWimsR2hPr0NNUaCAHTejMPcCrMB
/Mzt1IM4ghVwNIBuklgEj8F6++v+DRdiDgjbPfNt/lx8WG5/1GCnLXZ7rdFTNQDh
gnMto95z9DuU3JtMiGDObG+ZvuYxkfh8D9CMBsRfcCpc2uRRvw6a31UD2282Gm57
DFC8UOe4rjoCZQJoh7mIozwNj5bPJcHXSBd5r8EaGdQwQ0LGAnVLjLAVkG/SEzqb
Io/hIm048psoD6bI9lcA94uSuRcyFji8BXjmHZMGrDQctYJt8Axz12PX7OzeGHD6
8s4ehaKKDI9ICDzZklT1n0VmygCh2mMuMeFW+5NkuQziXlFhx+n2ZrLd/VpRcIwz
sRPW+yiUiBMY8De1tXhYnlpqxinm4fGIS+txvLHB9mPX9FmnnRM=
=R8IR
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to