Your message dated Sat, 12 Nov 2022 15:50:31 +0000
with message-id <[email protected]>
and subject line Bug#1014446: fixed in dhcpcd5 9.4.1-11
has caused the Debian Bug report #1014446,
regarding dhcpcd5: dhcpcd-run-hooks fails to skip editor backup files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1014446: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014446
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dhcpcd5
Version: 9.4.1-3
Severity: normal
Tags: patch, upstream
Dear Maintainer,
The script dhcpcd-run-hooks has code to skip hook scripts that should
not be run, either because the file name ends in "~" or because they're
listed in $skip_hooks. However, if $skip_hooks is undefined or null,
the tests are not run at all, which means files with names ending with
"~" will be unexpectedly run.
This was reported to me privately by another Debian user, who had
attempted to manually apply my patch for 1008059, but found it wasn't
working as expected, as they had used an editor which left the old file
as a backup with that ~ extension. The hook script is clearly intended
to skip over such files, but the skip doesn't take effect in the
mainline case.
I've attached a patch that fixes this on Debian. This bug also seems to
be present in the upstream package, and I've provided the same patch at
<https://github.com/NetworkConfiguration/dhcpcd/pull/113>.
-- System Information:
Debian Release: 11.3
APT prefers stable-updates
APT policy: (990, 'stable-updates'), (990, 'stable-security'), (990,
'stable'), (850, 'testing'), (500, 'unstable')
Architecture: arm64 (aarch64)
Foreign Architectures: armhf
Kernel: Linux 5.15.32-v8+ (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CRAP
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages dhcpcd5 depends on:
ii dhcpcd-base 9.4.1-3
ii lsb-base 11.1.0
dhcpcd5 recommends no packages.
Versions of packages dhcpcd5 suggests:
pn dhcpcd-gtk <none>
pn openresolv | resolvconf <none>
-- no debconf information
diff --git a/hooks/dhcpcd-run-hooks.in b/hooks/dhcpcd-run-hooks.in
index a237f6af..84465361 100644
--- a/hooks/dhcpcd-run-hooks.in
+++ b/hooks/dhcpcd-run-hooks.in
@@ -338,9 +338,11 @@ for hook in \
@HOOKDIR@/* \
@SYSCONFDIR@/dhcpcd.exit-hook
do
+ case "$hook" in
+ */*~) continue;;
+ esac
for skip in $skip_hooks; do
case "$hook" in
- */*~) continue 2;;
*/"$skip") continue 2;;
*/[0-9][0-9]"-$skip") continue 2;;
*/[0-9][0-9]"-$skip.sh") continue 2;;
--- End Message ---
--- Begin Message ---
Source: dhcpcd5
Source-Version: 9.4.1-11
Done: Martin-Éric Racine <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dhcpcd5, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin-Éric Racine <[email protected]> (supplier of updated dhcpcd5
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 12 Nov 2022 12:29:49 +0200
Source: dhcpcd5
Architecture: source
Version: 9.4.1-11
Distribution: unstable
Urgency: medium
Maintainer: Martin-Éric Racine <[email protected]>
Changed-By: Martin-Éric Racine <[email protected]>
Closes: 1014446
Changes:
dhcpcd5 (9.4.1-11) unstable; urgency=medium
.
* Merge patch from Git to skip ~ backup hooks (Closes: #1014446).
Checksums-Sha1:
2a62d2fba9660832e73888d7cc79f44b6bf9ac46 1882 dhcpcd5_9.4.1-11.dsc
d5285705e575c36a29c793c339cb97e7a0df72a5 18644 dhcpcd5_9.4.1-11.debian.tar.xz
939170e0e3876dc5c54fd51ebfac1dda3269ee79 5682 dhcpcd5_9.4.1-11_source.buildinfo
Checksums-Sha256:
3b563765a5f8383a6ea8e96545604ea3e36751545d2e2f16021f98163f9c0131 1882
dhcpcd5_9.4.1-11.dsc
155e6667a31a7d4f8de95d922fa38a70449a142bab27b34211f81c45916a03a7 18644
dhcpcd5_9.4.1-11.debian.tar.xz
9ae4c449e0a71be5db63f61a4a99d4a40056a55164c1d579dd0264818eccb84b 5682
dhcpcd5_9.4.1-11_source.buildinfo
Files:
a909260fa57a14c467d27301f0f5bc78 1882 net optional dhcpcd5_9.4.1-11.dsc
3e7fd9532d07944ef93acacb5d037454 18644 net optional
dhcpcd5_9.4.1-11.debian.tar.xz
e6168b6d3346e744f2b3dc71a3e527ce 5682 net optional
dhcpcd5_9.4.1-11_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmNvuTsQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFNNkC/0XyizbeahqBMeBNRFwlfAPIRRKLHfdi/ao
0rY5i9RZfcpnzF3Dg9QTQUWPD8ac9hDzKJnwxPWBZQY0WnoxQdNjMZjV7y2meNKZ
CqFzIxI4f0MVvH+9JhcHiJreRX3ilwOoaAcMSW0n25zbhjISMejD8U0lMgx2NEf0
uawEKSLRgFQxfygruNuuAPOju8BWt1y07utkrlNENG5GPZQGd6gAmUu1oEE2TSN7
YHnHIZ1MtUsdVBQ2STJVsL5P9/2706ZB5Nle/ala6wfRBqQSS12F5EgYKeRgFASc
8I+mQGGGUEND8oc0SBddBbRRtHJ4rnyk7z3IS0TmBGkHclLzBszFc/2/PRk14RoY
ElvXNgrTyuVakZUMOPQ9xgCetMOdNjTxcOFL8FmV0KgcYFTnpKtN9hQQw9LUvMmA
okzaE1K7fGKhLlMqxonveKO8bkbfwriKXlSpBuyvdYBHuyvXRmJhfVMCAs0PonL9
JbzghTon5QJw/gxaIy4FFb9D14L3VLQ=
=LASA
-----END PGP SIGNATURE-----
--- End Message ---
