Your message dated Thu, 29 Dec 2022 01:19:10 +0000
with message-id <[email protected]>
and subject line Bug#1026918: fixed in dgit 10.3
has caused the Debian Bug report #1026918,
regarding dgit: shows warnings if debian/source/include-binaries mentions files
in debian/
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1026918: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026918
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dgit
Version: 10.2
Severity: normal
While uploading this 3.0 (quilt) package
<https://salsa.debian.org/games-team/steam-installer/-/tree/debian/1%251.0.0.75+ds-1>
to NEW, I got this warning:
> Format `3.0 (quilt)', need to check/update patch stack
> canonical suite name is experimental
> warning: package uses dpkg-source include-binaries feature - not all changes
> are visible in patches!
> warning: ignoring bad include-binaries file debian/icons/16/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/24/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/256/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/32/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/48/steam.png: path
> starts with 'debian'
According to dpkg-source(1), all non-text files in a 3.0 (quilt) package[1]
need to be listed in debian/source/include-binaries, whether they're
additions to the upstream source or part of the debian/ directory:
> The build will also fail if it finds binary files in the debian
> sub-directory unless they have been allowed through
> debian/source/include-binaries
so I don't think the "ignoring bad include-binaries file" warnings for
those are correct: those lines are valid and necessary.
All files in debian/ are managed by git in the usual way (no special
patch system or anything like that), so dgit should probably only issue
the warning "not all changes are visible in patches" for binaries in
the upstream part of the package, outside debian/.
smcv
[1] the only non-native format that can include Debian-specific binaries
without uuencode or base64, as far as I'm aware
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'stable-security'), (500,
'oldstable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500,
'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1,
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.0.0-6-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages dgit depends on:
ii apt 2.5.4
ii ca-certificates 20211016
ii coreutils 9.1-1
ii curl 7.86.0-3
ii devscripts 2.22.2
ii dpkg-dev 1.21.13
ii dput 1.1.3
ii git [git-core] 1:2.39.0-1
ii git-buildpackage 0.9.30
ii libdpkg-perl 1.21.13
ii libjson-perl 4.10000-1
ii liblist-moreutils-perl 0.430-2
ii liblocale-gettext-perl 1.07-5
ii libtext-csv-perl 2.02-2
ii libtext-glob-perl 0.11-3
ii libtext-iconv-perl 1.7-8
ii libwww-curl-perl 4.17-8+b1
ii perl [libdigest-sha-perl] 5.36.0-6
Versions of packages dgit recommends:
ii distro-info-data 0.56
ii liburi-perl 5.17-1
ii openssh-client [ssh-client] 1:9.1p1-1
Versions of packages dgit suggests:
ii cowbuilder 0.89
ii pbuilder 0.231
ii sbuild 0.84.2
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: dgit
Source-Version: 10.3
Done: Ian Jackson <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dgit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ian Jackson <[email protected]> (supplier of updated dgit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 29 Dec 2022 00:51:29 +0000
Source: dgit
Architecture: source
Version: 10.3
Distribution: unstable
Urgency: medium
Maintainer: Ian Jackson <[email protected]>
Changed-By: Ian Jackson <[email protected]>
Closes: 935762 993769 1026918
Changes:
dgit (10.3) unstable; urgency=medium
.
dgit useability improvements:
* Silently tolerate mentions of debian/ in debian/source/include-binaries.
Closes:#1026918. [Report from Simon McVittie]
* Scan for duplicated orig tarballs with different names,
avoiding strange dpkg-source errors mentioning format 2.0.
Closes:#993769. [Report from Philip Hands]
* Rename auto quilt mode to try-linear (retaining compat alias),
to clarify that it won't automatically detect branch format.
Closes:#935762. [Report from David Bremner]
* dgit(1): Clarify the non-split-brain --quilt options, explicitly
stating that they expect a patched-applied (dgit view) branch.
.
Tainted object handling (relevant to Debian NEW):
* dgit can now usually discover when --deliberately-* will be needed,
before making signatures and attempting the actual push.
Thus, missing a --deliberately no longer burns a version number.
* This is #944855. However, it depends new infrastructure,
which is (in this version) only queried on a best-effort basis:
* New protocol transaction (over ssh) with dgit repos server,
to allow client to make a policy enquiry, and specifically to
enquire about tainted objects.
* More of the relevant error messages are now translatable via gettext.
.
Supporting changes:
* Modest refactoring to support the new functionality.
* Tests for new functionality, and improved tests in changed areas.
* tests: sbuild-gitish: Pass -v to sbuild for better debuggability.
Checksums-Sha1:
0160c92c44d3727474f81ddc2fcd22ec701ba838 1856 dgit_10.3.dsc
d6784fd162fdace427d2f9c3e0af645505e6bd72 679462 dgit_10.3.tar.gz
Checksums-Sha256:
cbd0fd20fdda0bb62e7bf6fee9a7f05208e0a3d9e8ebdba28e6033c69809bc07 1856
dgit_10.3.dsc
1c228a35d56ee6adac8ff6fd73c9bea9238d272a246ffd3a2a86d84db43ada70 679462
dgit_10.3.tar.gz
Files:
cf5b73a3cf98732093e767af611aa1cb 1856 devel optional dgit_10.3.dsc
89a5e50872c33f77b2c2275d027ec3df 679462 devel optional dgit_10.3.tar.gz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEVZrkbC1rbTJl58uh4+M5I0i1DTkFAmOs5kAACgkQ4+M5I0i1
DTnKQwf/T45tpUg9nD5TNz+sl23EWte6frrBli5qKaJIPWUvd144JyQctsE8JoRH
/Zmh5qY2c6LjVWZgE6uICoNtUzLL4iUvfj0D3PJ9fLF2faV8wb6s+uA7chEJQ3LR
O/0j+Iw77sPYo13d5HMxcBcoCuuB/CAIoUs8efV64oQAbJ1fy1U05HhkgXrqzOyw
t5xZ8BRMsndWgtji9LuTNZm5pGPWkbtQreQ51l0S2wOUC8W6+ZZTn4D7pFJcHMyO
8mUXbcNXyGLC4TTv1WmfWFpJu2I6wYI5G1I4AiLSf4lJJUqqE3RhHGay340hqs1o
Grjaypz6BYPettk+LKukc3yiUYwMwQ==
=tiue
-----END PGP SIGNATURE-----
--- End Message ---