Your message dated Fri, 30 Dec 2022 13:34:07 +0000
with message-id <[email protected]>
and subject line Bug#1021615: fixed in imlib2 1.10.0-1
has caused the Debian Bug report #1021615,
regarding libimlib2: tga loading error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1021615: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021615
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libimlib2
Version: 1.7.4-2
Severity: normal
Tags: patch

imlib2 fails to load some tga images, the bug was first discovered and
determined on: https://codeberg.org/nsxiv/nsxiv/issues/378

it was also discovered that the issue affects multiple versions of imlib2
and may have been present since imlib2 first supported tga images, the bug
does affect the versions of imlib2 from debian stable up to the latest upstream
release at the time of writing (1.9.1), the patch has already been merged into
the upstream, on the meantime here is the patch inlined:


>From 322582c4d02d9ed98badd28218d54c86683d80b2 Mon Sep 17 00:00:00 2001
From: NRK <[email protected]>
Date: Sun, 9 Oct 2022 12:56:57 +0600
Subject: [PATCH] TGA loader: fix indexing in tgaflip

`y` needs to be multiplied by the width, not the height.

ref: https://codeberg.org/nsxiv/nsxiv/issues/378
---
 src/modules/loaders/loader_tga.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/modules/loaders/loader_tga.c
b/src/modules/loaders/loader_tga.c
index 992a8d8..e0312fa 100644
--- a/src/modules/loaders/loader_tga.c
+++ b/src/modules/loaders/loader_tga.c
@@ -481,9 +481,9 @@ tgaflip(uint32_t * in, int w, int h, int fliph, int flipv)
         x2 = fliph ? w - 1 : 0;
         for (x = 0; x < nx; x++, x2 += dx)
           {
-             tmp = in[y * h + x];
-             in[y * h + x] = in[y2 * h + x2];
-             in[y2 * h + x2] = tmp;
+             tmp = in[y * w + x];
+             in[y * w + x] = in[y2 * w + x2];
+             in[y2 * w + x2] = tmp;
           }
      }
 }
--
2.35.1



-- System Information:
Debian Release: bookworm/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.18.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages libimlib2 depends on:
ii  libbz2-1.0       1.0.8-5
ii  libc6            2.34-3
ii  libfreetype6     2.12.1+dfsg-3
ii  libgif7          5.2.1-2.5
ii  libid3tag0       0.15.1b-14
ii  libjpeg62-turbo  1:2.1.2-1
ii  libpng16-16      1.6.37-5
ii  libtiff5         4.4.0-4
ii  libwebp7         1.2.2-2+b1
ii  libx11-6         2:1.8.1-2
ii  libx11-xcb1      2:1.8.1-2
ii  libxcb-shm0      1.15-1
ii  libxcb1          1.15-1
ii  libxext6         2:1.3.4-1
ii  zlib1g           1:1.2.11.dfsg-4

libimlib2 recommends no packages.

libimlib2 suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: imlib2
Source-Version: 1.10.0-1
Done: Markus Koschany <[email protected]>

We believe that the bug you reported is fixed in the latest version of
imlib2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <[email protected]> (supplier of updated imlib2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Dec 2022 14:06:14 CET
Source: imlib2
Architecture: source
Version: 1.10.0-1
Distribution: experimental
Urgency: medium
Maintainer: Markus Koschany <[email protected]>
Changed-By: Markus Koschany <[email protected]>
Checksums-Sha1:
 c11b571b0a29ad8d045a4c934cb704411a236984 2325 imlib2_1.10.0-1.dsc
 dd338ff08970e807500af4f440746406c6cd84f2 500280 imlib2_1.10.0.orig.tar.xz
 8e13b2f4cbd321c66960c227bd0a24ac06eb381a 11040 imlib2_1.10.0-1.debian.tar.xz
 9dfdb4dabab577fe0e0795a22979d4659ebdbb09 12454 imlib2_1.10.0-1_amd64.buildinfo
Checksums-Sha256:
 0e7e9abf8136dfb289c31f62313e8b9ff0c896ee84ec74497c47874880a47bdb 2325 
imlib2_1.10.0-1.dsc
 077e1c1e6a7ffd1e7850b286bde926c9b80223f83c0630cd5f7a3859a425e0a9 500280 
imlib2_1.10.0.orig.tar.xz
 c012c8b8ba59aee18ed11fe7eb18941617944cadb938426fbf54510887c83b0d 11040 
imlib2_1.10.0-1.debian.tar.xz
 347ca55df859f9a5b6ee262e93e9ba5c4e00b6784eb364672b461bd7f4557534 12454 
imlib2_1.10.0-1_amd64.buildinfo
Closes: 1021615 1023644
Changes:
 imlib2 (1.10.0-1) experimental; urgency=medium
 .
   * New upstream version 1.10.0.
     - Fix tga loading error. (Closes: #1021615)
   * Declare compliance with Debian Policy 4.6.2.
   * Drop no-git-tests.patch.
   * Update debian/libimlib2.symbols for new release.
   * Enable support for jpeg-xl. (Closes: #1023644)
   * Enable support for HEIF.
Files:
 edfef3fa280592ac92dbbb3b8356b845 2325 libs optional imlib2_1.10.0-1.dsc
 cf91c6046d3db4ef3e1847f8a4bc1d9c 500280 libs optional imlib2_1.10.0.orig.tar.xz
 12ae9a2db295c854ceeef2b650666991 11040 libs optional 
imlib2_1.10.0-1.debian.tar.xz
 535f43eb05cc34873dea987b8449f387 12454 libs optional 
imlib2_1.10.0-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAmOu4k1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1Hk+IEP/RTafPLvBWpkpnlf/dQfHZGD9CKLD7INr8yW
TWImHZBFF6s07iyYK3e/xC9cum7MfULwraxTpHG+wp6ToLNlHif+AH1QOK7cQNXU
Z8iHm/bW9PBQ449eXIHZO3DcTvKNAN1ZSaNcD+jxUgu0yAdpuqwzc8X/9fYcC1Be
OIaJDsHBmPW2LYIS3Se+yC5vYXSnfnVbz5WLk+sQr0RCqJkeHHmLKUVmfp+8o+yD
aG+oNpaaK/iRLNdpE6ogx3U76ykMFXW5fTGlkRl7UBkhuK49EsBBq7aLNFx+MRcj
5MYPhjPZt3QGdtwErG72VTw3Ri0K+e8gRyFcKSPXTmXYS8iaLjmYWG5uJWuAxF8R
mRxhPzuVHfm6eVdD65AxDlCppt8Jgp1z82PUtQS9xw3bfnrWyn6uOEqARfEdKmNc
ap6d21Cur1CI2DbevFzrcU4W2dIqvoNRHB5m6TvqWZk5Jx03vttOEANqBdl4nSwT
HGhFkVyWvJ+7IZhYLM4j6akBgJTF5MY+Zn+weUj5qbnEyj5BxrWHJdYnD1GXeWCu
HA82DnUk2fSm6WoGJd5Wmpy3UCsCAFNFW8q08Y7VHft6QEwr5TcKwUIpnLUddIJO
us0HjBIoRj7JuGrPXJZPlbEqYAOqUo030HU+0+1cy9GxjIBBVMs07fkX3v2OQpro
FtrAppnT
=Ry5Q
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to