Bug#1027015: marked as done (matrix.h: Compilation failure.)

Debian Bug Tracking System Sat, 31 Dec 2022 19:39:18 -0800

Your message dated Sun, 01 Jan 2023 03:36:56 +0000
with message-id <[email protected]>
and subject line Bug#1027015: fixed in wxwidgets3.2 3.2.1+dfsg-4
has caused the Debian Bug report #1027015,
regarding matrix.h: Compilation failure.
to be marked as done.


This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1027015: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027015
Debian Bug Tracking System
Contact [email protected] with problems

--- Begin Message ---
Package: libwxgtk3.2-dev
Version: 3.2.1+dfsg-1
When including the file /usr/include/wx-3.2/wx/matrix.h compilationfails. Example output from compiling opencpn below.
This is upstream bughttps://github.com/wxWidgets/wxWidgets/issues/22790. The bug isacknowledged and a fix is under way for 3.2.2 or 3.2.3.
Attaching a patch based in the already merged fixes upstream. Theoriginal fixes are quite complex since they have to deal with all sortsof configurations not available on Debian. The patch is simplified, justaiming top solve the actual problem in Debian until next upstreamrelease is available.
[ 11%] Building CXX objectlibs/gdal/CMakeFiles/GDAL.dir/src/ogrfeaturedefn.cpp.ocd /home/mk/OpenCPN/OpenCPN/obj-x86_64-linux-gnu/libs/gdal &&/usr/bin/g++-10 -DHAVE_WEBVIEW -DHAVE_WX_GESTURE_EVENTS -DWXUSINGDLL-D_FILE_OFFSET_BITS=64 -D__WXGTK__ -DocpnUSE_GL -DocpnUSE_SVG-DwxUSE_WEBVIEW=1 -I/home/mk/OpenCPN/OpenCPN/libs/gdal/include/gdal-I/home/mk/OpenCPN/OpenCPN/libs/gdal/include -isystem/usr/lib/x86_64-linux-gnu/wx/include/gtk3-unicode-3.2 -isystem/usr/include/wx-3.2 -g -O2 -ffile-prefix-map=/home/mk/OpenCPN/OpenCPN=.-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time-D_FORTIFY_SOURCE=2 -pthread -O2 -g -DNDEBUG -DPREFIX=\"/usr\"-fvisibility=hidden -Wall -Wno-unused -fexceptions -rdynamic-fno-strict-aliasing -Wno-deprecated-declarations -std=gnu++11 -MD -MTlibs/gdal/CMakeFiles/GDAL.dir/src/ogrfeaturedefn.cpp.o -MFCMakeFiles/GDAL.dir/src/ogrfeaturedefn.cpp.o.d -oCMakeFiles/GDAL.dir/src/ogrfeaturedefn.cpp.o -c/home/mk/OpenCPN/OpenCPN/libs/gdal/src/ogrfeaturedefn.cpp
In file included from /usr/include/wx-3.2/wx/defs.h:550,
                 from /usr/include/wx-3.2/wx/wxprec.h:12,
                 from /home/mk/OpenCPN/OpenCPN/src/chartsymbols.cpp:27:
/usr/include/wx-3.2/wx/matrix.h:44:1: error: expected identifier before‘__attribute__’
   44 | WXDLLIMPEXP_CORE wxTransformMatrix: public wxObject
      | ^~~~~~~~~~~~~~~~
In file included from /home/mk/OpenCPN/OpenCPN/include/bbox.h:9,
                 from /home/mk/OpenCPN/OpenCPN/include/s52s57.h:31,
                 from /home/mk/OpenCPN/OpenCPN/include/s52plib.h:31,
                 from /home/mk/OpenCPN/OpenCPN/include/chartsymbols.h:28,
                 from /home/mk/OpenCPN/OpenCPN/src/chartsymbols.cpp:36:
/usr/include/wx-3.2/wx/matrix.h:44:35: error: expected initializerbefore ‘:’ token
From 03eca5af92d4a395efc65dd8a6e936e33293f5b8 Mon Sep 17 00:00:00 2001
From: Alec Leamas <[email protected]>
Date: Mon, 21 Nov 2022 14:20:15 +0100
Subject: [PATCH] matrix.h: Patch attributes handling (wxwidgets#22790).

Bug: https://github.com/wxWidgets/wxWidgets/issues/22790
Forwarded: not-needed

---
 defs.h   | 21 +++++++++++++++++++++
 matrix.h |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/defs.h b/defs.h
index e048cb7..d491939 100644
--- a/defs.h
+++ b/defs.h
@@ -169,6 +169,27 @@
 #else /* !g++ */
 #   define wxSUPPRESS_GCC_PRIVATE_DTOR_WARNING(name)
 #endif
+/*
+    Some gcc versions choke on __has_cpp_attribute(gnu::visibility) due to the
+    presence of the colon, but we only need this macro in C++ code, so just
+    don't define it when using C.
+ */
+
+#ifdef __cplusplus
+
+/*
+    Special macro used for the classes that are exported and deprecated.
+    It exists because standard [[deprecated]] attribute can't be combined with
+    legacy __attribute__((visibility)), but we can't use [[visibility]] instead
+    of the latter because it can't be use in the same place in the declarations
+    where we use WXDLLIMPEXP_CORE. So we define this special macro which uses
+    the standard visibility attribute just where we can't do otherwise.
+
+    Heavily simplified for wxWidgets and gcc -- Alec Leamas
+ */
+    #define wxDEPRECATED_EXPORT_CORE(msg) \
+	__attribute__((visibility("default")))
+#endif
 
 /*
    Clang Support
diff --git a/matrix.h b/matrix.h
index d18a0d2..a3392b5 100644
--- a/matrix.h
+++ b/matrix.h
@@ -41,7 +41,8 @@ class
 #ifndef WXBUILDING
 wxDEPRECATED_MSG("use wxAffineMatrix2D instead")
 #endif
-WXDLLIMPEXP_CORE wxTransformMatrix: public wxObject
+wxDEPRECATED_EXPORT_CORE("use wxAffineMatrix2D instead")
+wxTransformMatrix: public wxObject
 {
 public:
     wxTransformMatrix();
-- 
2.30.2
--- End Message ---

--- Begin Message ---

Source: wxwidgets3.2
Source-Version: 3.2.1+dfsg-4
Done: Scott Talbert <[email protected]>

We believe that the bug you reported is fixed in the latest version of
wxwidgets3.2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Scott Talbert <[email protected]> (supplier of updated wxwidgets3.2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 31 Dec 2022 09:37:25 -0500
Source: wxwidgets3.2
Architecture: source
Version: 3.2.1+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: wxWidgets Maintainers <[email protected]>
Changed-By: Scott Talbert <[email protected]>
Closes: 1027015
Changes:
 wxwidgets3.2 (3.2.1+dfsg-4) unstable; urgency=medium
 .
   * Fix compilation when using matrix.h (Closes: #1027015)
   * Fix reproducibility issue with usrmerged vs non-usrmerged
   * Update Standards-Version to 4.6.2 (no changes needed)
   * Enable hardening
   * Remove obsolete Build-Depends/Depends
   * d/watch: Switch to GitHub API since releases broken w/ uscan
Checksums-Sha1:
 4dd4d6cf7d6a8c8872c0ea394370a30404704ab8 3039 wxwidgets3.2_3.2.1+dfsg-4.dsc
 19c58737cda0187abf2262a9ddc0e84ff19de774 34576 
wxwidgets3.2_3.2.1+dfsg-4.debian.tar.xz
 35e9dcb5bc7f0e1ea44d3c56233d8723c07b1246 30475 
wxwidgets3.2_3.2.1+dfsg-4_amd64.buildinfo
Checksums-Sha256:
 ac9252a53f5fe3a9905b41aed1635d0bdaf04aa8ad23c78648d28789e585ddca 3039 
wxwidgets3.2_3.2.1+dfsg-4.dsc
 4a3a1c135f8506b38b9c03e323886627312212d746f7f1b05efdf6af653c91f3 34576 
wxwidgets3.2_3.2.1+dfsg-4.debian.tar.xz
 cddb02495e3a91bd355ecda116ec06d930b79f170e27aa578d6712ace34421c2 30475 
wxwidgets3.2_3.2.1+dfsg-4_amd64.buildinfo
Files:
 aa4b5018e4a2db256540efca6ec63f4e 3039 libs optional 
wxwidgets3.2_3.2.1+dfsg-4.dsc
 803ddebe6dbf20179c750bccee09604f 34576 libs optional 
wxwidgets3.2_3.2.1+dfsg-4.debian.tar.xz
 5cfb9815fc9ff79052a4e8abdf43ee9e 30475 libs optional 
wxwidgets3.2_3.2.1+dfsg-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEbnQ09Yl9Q7F/zVe3U9W8ZLUjeKIFAmOw/DIPHHN3dEB0ZWNo
aWUubmV0AAoJEFPVvGS1I3iiRnsQAKHrphcc/C3LvafgHxkotiugs+YqO2oQc8cM
o2L4bcMq8wPKipSY4DdDM5ylWte6Wr/eWNMr+w6ysf1zyGYcreSgCwb4vz65NXW2
EO8YwF87JAfC0KXjrMIBCRyNwVqzM4NbpdTzZ55OsHRN3KE5QLBDuV+IJmYYy81d
EvnYFwP4uH2tduVI12vYAnjrOhF6dGJd67U4aEWWMj7HLxMxm3PWXBlzzuOgsxhS
ZuL2Ki380l8AcWm8G4CFPaW3fd0qW93xGmI9SnO1O/Qy/mKSkMx+0hWA9CQuPGVo
qGncJqygEHb0Yv/QkZL9TFcT99ISgHxN1rRx54qa6Rca/Bynq7vpD/ieH9IRj5RH
SmfF2+1MdpzkLBN8niIo5XQHAu54IIjyYjX+p22Tpgc3vWzVROUnDHhEsfZJ2DHa
fLZt7DrVMEFnYZopyx3Iekxzz0/STz/VSKo6872mmam0KOgpOJ5rcDGO+AbfCVmE
X9P22E2NiYh/thXaPHIhoff/vRbgrm/bxEKfO8ORdt3hsMcFZPiDgpmf4NpKaA9p
HuLhZTbmG4CbVD8dUVbNgpz4FneGipYfqnM8rlUGIk2UoTx+DTN+2wsgIZ4Ppzi3
6h7Gj49TnEXhxj+YVqllwAukVJhBwjAP2CHGeoGDkx79oUoLWXEo1gd8nz9AIes7
B/+wHzP7
=ONQ+
-----END PGP SIGNATURE-----

--- End Message ---

Bug#1027015: marked as done (matrix.h: Compilation failure.)

Reply via email to