Your message dated Fri, 24 Feb 2023 15:49:07 +0000
with message-id <[email protected]>
and subject line Bug#760235: fixed in deluge 2.1.1-3
has caused the Debian Bug report #760235,
regarding deluged: init-script uses start-stop-daemon --background
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
760235: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760235
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: deluged
Version: 1.3.7-1
Severity: normal
Dear Maintainer,
I am really pleased to see that the recent versions of this package come with
an init-script. I have been using deluge for several years now, and had
previously hacked together an init-script myself, with the help of ones posted
on the web. However, is there a reason that the new init-script passes the -d
argument to deluged (telling it not to daemonize) and instead uses the
--background option to start-stop-daemon? On my own system, I have called
deluged without the -d option, and start-stop-daemon without the --background
option, and it seems to work fine. Is there a technical reason that I am not
aware of for doing it this way?
>From the man page for start-stop-daemon:
--background: Typically used with programs that don't detach on their own.
This option will force start-stop-daemon to fork before starting the process,
and force it into the background. WARNING: start-stop-daemon can not check the
exit status if the process fails to execute for any reason. This is a last
resort, and is only meant for programs that either make no sense forking on
their own, or where it's not feasible to add the code for them to do this
themselves.
To be clear, the changes I'm suggesting are simply to modify the init script
to remove the "-d" switch from DAEMON_ARGS, and to remove the "--background"
switch from both invocations of start-stop-daemon. I have attached a patch
file that does exactly this, for reference.
-- System Information:
Debian Release: wheezy/jessie
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (x86_64)
Foreign Architectures: amd64
Kernel: Linux 3.12-0.bpo.1-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages deluged depends on:
ii deluge-common 1.3.6-1.1
ii python 2.7.8-1
ii python-libtorrent 0.15.10-1
deluged recommends no packages.
deluged suggests no packages.
-- no debconf information
diff -rupN deluge-1.3.7/debian/deluged.init deluge-1.3.7-new/debian/deluged.init
--- deluge-1.3.7/debian/deluged.init 2014-08-30 14:45:20.000000000 -0700
+++ deluge-1.3.7-new/debian/deluged.init 2014-09-01 16:19:33.000000000 -0700
@@ -18,7 +18,7 @@ PATH=/sbin:/usr/sbin:/bin:/usr/bin
DESC="Deluge BitTorrent Daemon"
NAME="deluged"
DAEMON=/usr/bin/$NAME
-DAEMON_ARGS="-d -c /var/lib/deluged/config -l /var/log/deluged/daemon.log -L info"
+DAEMON_ARGS="-c /var/lib/deluged/config -l /var/log/deluged/daemon.log -L info"
USER=debian-deluged
MASK=0027
PIDFILE=/var/run/$NAME.pid
@@ -52,11 +52,11 @@ do_start()
# 0 if daemon has been started
# 1 if daemon was already running
# 2 if daemon could not be started
- start-stop-daemon --start --background --quiet --pidfile $PIDFILE --exec $DAEMON \
+ start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON \
--chuid $USER --umask $MASK --test > /dev/null \
|| return 1
- start-stop-daemon --start --background --quiet --pidfile $PIDFILE --make-pidfile --exec $DAEMON \
+ start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile --exec $DAEMON \
--chuid $USER --umask $MASK -- $DAEMON_ARGS \
|| return 2
fi
--- End Message ---
--- Begin Message ---
Source: deluge
Source-Version: 2.1.1-3
Done: Daniel Baumann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
deluge, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated deluge
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 24 Feb 2023 16:19:08 +0100
Source: deluge
Architecture: source
Version: 2.1.1-3
Distribution: experimental
Urgency: medium
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Closes: 760235
Changes:
deluge (2.1.1-3) experimental; urgency=medium
.
* Uploading to experimental.
* Adding note about CVE-2021-3427 to changelog for 2.1.1-1 upload.
* Removing cruft from rules file.
* Removing gir1.2-appindicator3-0.1 from recommends as it's been
replaced with ayatana indicators which is currently not supported.
* Removing superseeded deluged initscript (Closes: #760235).
Checksums-Sha1:
4b1e1cbd5d568aa35f7fba33961819a252d63794 2235 deluge_2.1.1-3.dsc
c6895016866371b0672ecb37f2171189e6eb7b33 24364 deluge_2.1.1-3.debian.tar.xz
a0bc80aabe7341fdf47264954c6edd4536a0684f 8485 deluge_2.1.1-3_amd64.buildinfo
Checksums-Sha256:
c6dd1a9839644a3fd4589c36fc380278a2d88b6e9cffe94e5c9ea5ddbd1e9309 2235
deluge_2.1.1-3.dsc
48edab7488cd30053709bb420d6797400c273b2a30705de6a9d86bd1f1061aef 24364
deluge_2.1.1-3.debian.tar.xz
f15fe36adf4a65cc592b6c0a91a47c30fa79bbaec6efa5ea21946b3e6ff8f4f6 8485
deluge_2.1.1-3_amd64.buildinfo
Files:
b0352bc9437a8ce301571a9fa9cd56cd 2235 net optional deluge_2.1.1-3.dsc
3f885f4e95bcea93626c09c697b6c660 24364 net optional
deluge_2.1.1-3.debian.tar.xz
d030771699289db352020003d2b8c243 8485 net optional
deluge_2.1.1-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEgTbtJcfWfpLHSkKSVc8b+YaruccFAmP41jAACgkQVc8b+Yar
ucfUqg//RSaXh4jJSRA+oWFbQOjnOMwfz6gMNaXIdpCzInFeB3ICGE+cg2nkrPga
xiSsiwBESLJsOXmi3+u+fEVxzCWS1zpc3t3dHGfasuo+1zAZ9csBryfd+EnFixLE
sT4Pep9+KaYy7FcSBfD8R38eECMwcmISr2/nG2Xdf52ue+Hu4ljyhrfEtf6SaM7/
0tcMYNgOU+lBjVlyTkUBqCag3wDqy3DLJktajZY0tQnrMU9xKkDfAUQYAJugdIJM
tBUy9hZEdkcg050Fcm8VkBZ/EyOVHd0JHSap496KdWBu3L0OtFN+iDDLcrh+rlvo
9YHje5pwR1xmphZcaqvY8klnT8c6VXJBPr9ly8z5V1Ij/ztQbnIaUFjMMaK/SU6X
kbxjtbdFM/f2b/YSkgXkaiNaewNYXZj+SFXUIGmr269DwPtdzx90NmSJrh8u68WZ
cnz2o7663oo6AJQFPPZCXHfoYWwAtelXncDd/+hrmDo4FFWMPl/7StyWb8nzDnRY
dnwJG8GF9y5Kxogh7LJ9aQxF9JV3d2xP18MXCbsQGLkVA1/FlkHSK2s7qeEylFk9
15bMIEsBAu+93YOJIVuRnD4w7J1SN14JnELJk1riZn/J2ILl35aSucQxGlklut3j
rEI21b9mRcP/DKFf0qWqTOhYX+sMQlfT8UN/IqF9yyeH08PTvcY=
=xh/2
-----END PGP SIGNATURE-----
--- End Message ---
