Your message dated Sat, 25 Feb 2023 19:31:23 +0100
with message-id <Y/[email protected]>
and subject line Re: Bug#1030678: dhewm3: An additional copyright entry may be
appropriate
has caused the Debian Bug report #1030678,
regarding dhewm3: An additional copyright entry may be appropriate
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1030678: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1030678
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dhewm3
Version: 1.5.2+dfsg-1
Severity: normal
Dear Maintainer,
I've recently been looking at some of the dhewm3 upstream source code as part
of packaging another game based on dhewm3 (quadrilateralcowboy), and today I've
been re-reviewing the copyright entries in my package.
There isn't currently a copyright entry for dhewg (the creator and early author
of the dhewm3 fork) in either my package or dhewm3.
Although dhewg made significant contributions and changes to the codebase,
there _are_ some files that they have not modified, and those have a variety of
filename extensions and exist in a variety of directories.
Suggested resolution:
>From comparing commit d57f438db1abb86d5b719abab572420c02f1fc9b (latest upstream
at time of writing) to commit 15597777fc31d6d9fe0d48848e5c97b07e470b79 (last
pre-fork commit), I believe that every 'CMakeLists.txt', '.c', '.cpp', '.h',
'.m4', and '.py' file in the codebase was updated by dhewg - and so it may be
fair to add a second glob file stanza (after the first, existing iD Software
wildcard glob) to attribute files matching those to both iD Software and also
dhewg.
That won't do a perfect job of attributing all of their changes -- something
that could involve lengthy analysis and might result in an excessively detailed
copyright file -- but I think that it would be an improvement and should cover
the vast majority (if not all) of the elements that produce the resulting
dhewm3 binaries distributed in Debian.
I'm planning to apply the suggested resolution to my packaging of and could
open an equivalent merge request for dhewm3's repository on Salsa too, if that
makes sense to you.
Thanks,
James
[1] - https://salsa.debian.org/jayaddison/quadrilateralcowboy/
--- End Message ---
--- Begin Message ---
Hi James,
On Sat, Feb 25, 2023 at 04:48:31PM +0000, James Addison wrote:
> Package: dhewm3
> Followup-For: Bug #1030678
> X-Debbugs-Cc: [email protected]
>
> (cc'ing tobi as an uploader of previous dhewm3 packages)
>
> I've opened a (single-line, simpler approach) merge request with a copyright
> attribution entry for dhewg in the dhewm3 package:
>
> https://salsa.debian.org/games-team/dhewm3/-/merge_requests/4
greping through the source, there is no mentioning of "dhewg" beside a
changlog entry from 2011.
The job of d/copyright is to reflect the copyright *as recorded* in the sources
by upstream. We generally assume upstream has documented it correctly when
generating this file.
If you believe that the upstream recorded is incaccurate, please address this
directly to upstream to get this sorted. If that leads to a change upstream,
I will follow…
There might be several egitz reasons why someone is not mentioned anymore,
only upstream can answer this…
--
tobi
> (there are one or two potentially useful Janitor-related merge requests that
> might be worth considering at the same time, too)
(Those are cosemtic changes and as Debian has been frozen, those must wait
until bookworm is released.)
--- End Message ---
