Your message dated Wed, 21 Jun 2006 08:47:26 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#354190: fixed in siproxd 1:0.5.13-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: siproxd
Version: 1:0.5.10+cvs20050423-1
Severity: normal
Tags: patch
In proxy.c, functions proxy_request() and proxy_response(), an argument
of type osip_uri_t* is used for a "%s" conversion specification. However,
osip_uri_t is a struct; it seems like what really was meant is its member
"host" of type char*.
This seems to only affect siproxd if debug output is activated,
DBCLASS_PROXY is included in debug_level and a host name read from the
network cannot be resolved. By chance I happened to hit it all the same. ;)
Luckily, on my system, a NUL byte was less than 20 bytes of garbage away.
The code in question is also present in 1:0.5.11-1 (testing, unstable),
as proxy.c is identical to 1:0.5.10+cvs20050423-1 (before applying
debian patches). In current upstream (24Feb2006), the code has been
removed from the two functions in proxy.c, but added to
sip_find_direction() in sip_utils.c, still containing the bug.
Regards, Fabian
diff -du4rN siproxd-0.5.10+cvs20050423/src/proxy.c
siproxd-0.5.10+cvs20050423-format/src/proxy.c
--- siproxd-0.5.10+cvs20050423/src/proxy.c 2005-04-22 00:41:02.000000000
+0200
+++ siproxd-0.5.10+cvs20050423-format/src/proxy.c 2006-02-24
06:46:53.000000000 +0100
@@ -143,9 +143,9 @@
if (urlmap[i].active == 0) continue;
if (get_ip_by_host(urlmap[i].true_url->host, &tmp_addr) == STS_FAILURE) {
DEBUGC(DBCLASS_PROXY, "proxy_request: cannot resolve host [%s]",
- urlmap[i].true_url);
+ urlmap[i].true_url->host);
} else {
DEBUGC(DBCLASS_PROXY, "proxy_request: reghost:%s ip:%s",
urlmap[i].true_url->host, utils_inet_ntoa(from->sin_addr));
if (memcmp(&tmp_addr, &from->sin_addr, sizeof(tmp_addr)) == 0) {
@@ -639,9 +639,9 @@
if (urlmap[i].active == 0) continue;
if (get_ip_by_host(urlmap[i].true_url->host, &tmp_addr) == STS_FAILURE) {
DEBUGC(DBCLASS_PROXY, "proxy_response: cannot resolve host [%s]",
- urlmap[i].true_url);
+ urlmap[i].true_url->host);
} else {
DEBUGC(DBCLASS_PROXY, "proxy_response: reghost:%s ip:%s",
urlmap[i].true_url->host, utils_inet_ntoa(from->sin_addr));
if (memcmp(&tmp_addr, &from->sin_addr, sizeof(tmp_addr)) == 0) {
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: siproxd
Source-Version: 1:0.5.13-1
We believe that the bug you reported is fixed in the latest version of
siproxd, which is due to be installed in the Debian FTP archive:
siproxd_0.5.13-1.diff.gz
to pool/main/s/siproxd/siproxd_0.5.13-1.diff.gz
siproxd_0.5.13-1.dsc
to pool/main/s/siproxd/siproxd_0.5.13-1.dsc
siproxd_0.5.13-1_i386.deb
to pool/main/s/siproxd/siproxd_0.5.13-1_i386.deb
siproxd_0.5.13.orig.tar.gz
to pool/main/s/siproxd/siproxd_0.5.13.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mark Purcell <[EMAIL PROTECTED]> (supplier of updated siproxd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 21 Jun 2006 16:30:00 +0100
Source: siproxd
Binary: siproxd
Architecture: source i386
Version: 1:0.5.13-1
Distribution: unstable
Urgency: low
Maintainer: Debian VoIP Team <[EMAIL PROTECTED]>
Changed-By: Mark Purcell <[EMAIL PROTECTED]>
Description:
siproxd - SIP proxy/redirect/registrar
Closes: 327370 354190 366844
Changes:
siproxd (1:0.5.13-1) unstable; urgency=low
.
* New upstream release
- Fixes: siproxd doesn't work on amd64 without 64bit patches from upstream
(Closes: #366844)
- Fixes: invalid argument for format string (Closes: #354190)
- Fixes: Weird location for registration_file (Closes: #327370)
Files:
4309835cfcf72928ce8a0682fd28a954 908 net optional siproxd_0.5.13-1.dsc
91a572f80dd5a9af5a0f7f207fd34478 223109 net optional siproxd_0.5.13.orig.tar.gz
304a34342f532dbcf44a6d6c6fdf61db 8342 net optional siproxd_0.5.13-1.diff.gz
1db6a23923650e515b0740f867e171e4 76062 net optional siproxd_0.5.13-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFEmWZ1oCzanz0IthIRAlQ+AJ9Mqyv4Grn8Qez3yw7KAhGhcAZQUQCcDCy5
CV0v8+MVoCnUxzUBYN+x/NU=
=+thc
-----END PGP SIGNATURE-----
--- End Message ---
