Your message dated Tue, 11 Apr 2023 16:43:39 -0700
with message-id <87r0sq9e8k.fsf@wireframe>
and subject line Re: php8.2: please make the build (mostly) reproducible
has caused the Debian Bug report #1001648,
regarding php8.2: please make the build (mostly) reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1001648: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001648
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: php8.0
Version: 8.0.3-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
php8.0 could not be built reproducibly.

Patch attached to make the build-defs.h, /usr/bin/php-config8.0 and
test-results.txt.gz reproducible. However, the phar8.0.phar file
remains unreproducible - it seems to embed a bunch of inline, zlibbed
(?) code that I haven't yet looked at yet and I thought I would send
over this much at least.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/rules      2021-03-08 10:04:00.325828387 +0000
--- b/debian/rules      2021-03-08 14:45:35.699308154 +0000
@@ -519,9 +519,16 @@
 
 ifeq (yes,$(RUN_TESTS))
        mkdir -p debian/$(PHP_COMMON)/usr/share/doc/$(PHP_COMMON)/
-       cp test-results.txt debian/$(PHP_COMMON)/usr/share/doc/$(PHP_COMMON)/
+       $(SED) -e's@$(CURDIR)@«BUILDDIR»@g;' test-results.txt > \
+         > debian/$(PHP_COMMON)/usr/share/doc/$(PHP_COMMON)/test-results.txt
 endif
 
+       $(SED) -i -e's@-ffile-prefix-map=[^ ]*[ ]*@@g' \
+           -e's@-fdebug-prefix-map=[^ ]*[ ]*@@g' \
+           -e's@$(CURDIR)@/tmp/buildd/nonexistent@g' \
+           debian/$(PHP_DEV)/usr/include/php/*/main/build-defs.h \
+           debian/$(PHP_DEV)/usr/bin/php-config$(PHP_NAME_VERSION)
+
 override_dh_installinit:
        dh_installinit --restart-after-upgrade
 

--- End Message ---
--- Begin Message ---
Version: 8.2.0~rc1-2

php8.2 (8.2.0~rc1-2) experimental; urgency=medium

  * Use media-types instead of mime-support (Closes: #1010155)
  * Make the build (mostly) reproducible (Closes: #1001648)
  * Export SED := /bin/sed in d/rules (Closes: #1015188)

 -- Ondřej Surý <[email protected]>  Sun, 18 Sep 2022 12:02:59 +0200

On 2021-07-15, Vagrant Cascadian wrote:
> diff --git a/debian/rules b/debian/rules
> index 8aa4d27..8696a51 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -519,9 +519,14 @@ override_dh_install-arch: remove-files-stamp 
> prepare-fpm-pools
>  
>  ifeq (yes,$(RUN_TESTS))
>       mkdir -p debian/$(PHP_COMMON)/usr/share/doc/$(PHP_COMMON)/
> -     cp test-results.txt debian/$(PHP_COMMON)/usr/share/doc/$(PHP_COMMON)/
>  endif
>  
> +     $(SED) -i -e's@-ffile-prefix-map=[^ ]*[ ]*@@g' \
> +             -e's@-fdebug-prefix-map=[^ ]*[ ]*@@g' \
> +             -e's@$(CURDIR)@/tmp/buildd/nonexistent@g' \
> +             debian/$(PHP_DEV)/usr/include/php/*/main/build-defs.h \
> +             debian/$(PHP_DEV)/usr/bin/php-config$(PHP_NAME_VERSION)
> +
>  override_dh_installinit:
>       dh_installinit --restart-after-upgrade

I can confirm debian/rules in the current php8.2 package has the changes
from the above patch.

There are still other unresolved reproducibility issues, but not ones
that would be fixed by this patch and would probably be best to open new
bugs about them, as this bug has a tangled history across numerous php
versioned packages...

Thanks everyone who worked on this, marking as done!

live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to