Your message dated Fri, 05 May 2023 00:05:46 +0000
with message-id <[email protected]>
and subject line Bug#1034529: fixed in vim 2:9.0.1378-2
has caused the Debian Bug report #1034529,
regarding vim-runtime: perl subroutine body fails to indent in bookworm
(regression from bullseye)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1034529: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034529
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: vim-runtime
Version: 2:9.0.1378-1
Severity: normal
X-Debbugs-Cc: [email protected]
Dear Maintainer,
I noticed when editing perl code in vim that pressing enter after the
opening brace of a subroutine no longer indents like you'd expect:
// expected:
sub foo {
_<-- cursor here
// actual:
sub foo {
_<-- cursor here
This worked correctly in debian bullseye (vim 8.2).
The culprit appears to be that syntax/perl.vim has introduced
syn region perlSubDeclaration ...
which seems to confuse GetPerlIndent() in indent/perl.vim. If I add
tests for this region name the issue appears to be fixed:
@@ -133,6 +133,7 @@ function! GetPerlIndent()
\ || synid == "perlHereDoc"
\ || synid == "perlBraces"
\ || synid == "perlStatementIndirObj"
+ \ || synid == "perlSubDeclaration"
\ || synid =~ "^perlFiledescStatement"
\ || synid =~ '^perl\(Sub\|Block\|Package\)Fold'
let brace = strpart(line, bracepos, 1)
@@ -151,6 +152,7 @@ function! GetPerlIndent()
\ || synid == "perlMatchStartEnd"
\ || synid == "perlBraces"
\ || synid == "perlStatementIndirObj"
+ \ || synid == "perlSubDeclaration"
\ || synid =~ '^perl\(Sub\|Block\|Package\)Fold'
let ind = ind - shiftwidth()
endif
But beware that I don't really know how this function works or whether
this is a correct fix, it was just a random guess that seemed to produce
the desired result.
The issue can alternatively be fixed by reverting the
" Functions
...various perlSub* match rules...
syn match perlFunction ...
section of syntax/perl.vim to its previous (vim 8.2) version, except
with perlSignature renamed to perlSubSignature to ensure it gets
highlighted correctly.
-- System Information:
Debian Release: 12.0
APT prefers testing-security
APT policy: (500, 'testing-security'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf
Kernel: Linux 6.0.0-2-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
vim-runtime depends on no packages.
Versions of packages vim-runtime recommends:
ii vim-gtk3 [vim] 2:9.0.1378-1
vim-runtime suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: vim
Source-Version: 2:9.0.1378-2
Done: James McCoy <[email protected]>
We believe that the bug you reported is fixed in the latest version of
vim, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
James McCoy <[email protected]> (supplier of updated vim package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 04 May 2023 06:24:44 -0400
Source: vim
Architecture: source
Version: 2:9.0.1378-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Vim Maintainers <[email protected]>
Changed-By: James McCoy <[email protected]>
Closes: 1034529 1035323
Changes:
vim (2:9.0.1378-2) unstable; urgency=medium
.
* Backport 9.0.1499 to fix CVE-2023-2426 (Closes: #1035323)
* Backport fix for indenting of Perl subroutines (Closes: #1034529)
Checksums-Sha1:
57b93a9208e6ca56c0d7b814c86427ed9cc3055d 3177 vim_9.0.1378-2.dsc
e5792ad611863fdacc2567f66b3c41468bcc18f7 182176 vim_9.0.1378-2.debian.tar.xz
Checksums-Sha256:
c70ac888d9e17d6a0333e941478ec152300a41497fc289930be70ea7156ff13d 3177
vim_9.0.1378-2.dsc
727456f57809b7e3a5c461cb9d26519b1b7cd9a28673cce744d2416560d82be4 182176
vim_9.0.1378-2.debian.tar.xz
Files:
a934f39defa4a8df0aea055aa1e51bce 3177 editors optional vim_9.0.1378-2.dsc
d2b5328d8a8480595f0b6d2f75937479 182176 editors optional
vim_9.0.1378-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQKoBAEBCgCSFiEEkb+/TWlWvV33ty0j3+aRrjMbo9sFAmRURWFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDkx
QkZCRjRENjk1NkJENURGN0I3MkQyM0RGRTY5MUFFMzMxQkEzREIUHGphbWVzc2Fu
QGRlYmlhbi5vcmcACgkQ3+aRrjMbo9sNPQ/9FnXDGG4jgbU2T+TWPeiJUUkPli00
Wj4Re3gLEwn48N7HDyoVBYO+1iomt9IwaMz9GQsrilhcXaFRH075FsoKP070j7cg
4Ev6ZOAGRgfVJwYgjuWjNxUYlkQH98oRhgzmQ1cIekhr8w0v9Wf29625189Qwp1E
X5ZxAmzU6Ax341TnFvKjuVTFAl8KQNdwDLfvB3lR+iyoN5m37junNqiCANoarmqC
SDR6CPDcSga3+QIpC3XmauiH8Dce5ibA7ahi+dPDgrOGNlrOtKjrCnxtewbQcMTL
LQn6iUFIBY7ukiszZ7WoB3kgI9RuR7BMpTVErQh099RZpWq/0Tqz9zJKmlYEPLO8
zRWW9ssEwhn0dpk7cTpjqf1mlBBq615uotvTYXmShpwGkNDrTxlU1HXRNY1Plq9C
ASeCo+hLt/cmnMuOgcS/LcZASJ9KZ6sbvPg6JI8kyOrb/F09jPR7vqGzbRaI9TG/
5Xf0Vp0eqfp8fW1x7ai4NsLbWkk9PchIxA1vjjFqc1lBvPySGYpIFkPPgmNeNupG
KDu6+kTVgXSidrsVxc4RuH2a9IghI2XUJOLAfl7VQ7Av1fQ0mMGB2YQiFTzEBGo9
XNg70b6dtTwxctStYu6VWySF9g0ykcELRtyUnQC+YMEKejzbOLH1klBBL5CnDgtx
CWI6fX8T7AjJwec=
=pFAb
-----END PGP SIGNATURE-----
--- End Message ---
