Your message dated Fri, 23 Jun 2006 07:32:07 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#233894: fixed in adduser 3.90
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: shadow
Severity: important
Tags: patch sid

Hello Karl,

This bug is severity important for two reasons:

1) You forgot to call dh_installdebconf in debian/rules, which means the
passwd.config and passwd.templates aren't installed.
2) You need to have the versioned Build-Depends on debconf be 
(>= 3.0.0), since that's what you use.

I fixed both those problems in the attached patch, plus I added support
for initial groups for the user created during installation.  The
defaults are "audio video cdrom".  This patch was created for the Debian
Desktop subproject; we think the user should have permission to do such
common tasks as play audio and video by default.

Thanks!


diff -uNr shadow-4.0.3/debian/control shadow-4.0.3.hacked/debian/control
--- shadow-4.0.3/debian/control	2002-10-27 20:34:16.000000000 -0500
+++ shadow-4.0.3.hacked/debian/control	2002-10-27 17:18:48.000000000 -0500
@@ -3,7 +3,7 @@
 Priority: required
 Maintainer: Karl Ramm <[EMAIL PROTECTED]>
 Standards-Version: 3.5.7.0
-Build-Depends: autoconf, automake1.5, libtool, bzip2, gettext, libpam0g-dev [!hurd-i386], texinfo, file, debhelper, debconf-utils
+Build-Depends: autoconf, automake1.5, libtool, bzip2, gettext, libpam0g-dev [!hurd-i386], texinfo, file, debhelper (>= 3.0.0), debconf-utils
 
 Package: passwd
 Architecture: any
diff -uNr shadow-4.0.3/debian/control~ shadow-4.0.3.hacked/debian/control~
diff -uNr shadow-4.0.3/debian/passwd.config shadow-4.0.3.hacked/debian/passwd.config
--- shadow-4.0.3/debian/passwd.config	2002-10-27 20:34:16.000000000 -0500
+++ shadow-4.0.3.hacked/debian/passwd.config	2002-10-27 20:31:50.000000000 -0500
@@ -208,6 +208,7 @@
 			COMPARE_PW=''
 			db_input high passwd/user-password-again \
 				&& COMPARE_PW=1 || true
+			db_input medium passwd/initial-groups || true
 		fi
 	;;
 	7)
@@ -224,6 +225,18 @@
 				STATE=5
 				continue
 			fi
+
+			db_get passwd/initial-groups
+			INITIAL_GROUPS="$RET"
+			for group in $INITIAL_GROUPS; do
+			    if ! expr "$group" : '[a-z][a-z0-9]*$' >/dev/null; then
+				db_fset passwd/initial-groups seen false
+				db_fset passwd/username-bad seen false
+				db_input critical passwd/username-bad
+				STATE=5
+				continue
+			    fi
+			done
 			
 			# Compare the two passwords, loop with message if not
 			# identical, or if empty.
@@ -255,6 +268,9 @@
 			# noninteractive mode.
 			db_get passwd/user-fullname
 			adduser --disabled-password --gecos "$RET" "$USER" >/dev/null || true
+			for group in $INITIAL_GROUPS; do
+			    adduser "$USER" "$group" >/dev/null || true
+			done
 			
 			# Clear password from the db, and set the password.
 			db_set passwd/user-password ""
diff -uNr shadow-4.0.3/debian/passwd.templates shadow-4.0.3.hacked/debian/passwd.templates
--- shadow-4.0.3/debian/passwd.templates	2002-10-27 20:34:16.000000000 -0500
+++ shadow-4.0.3.hacked/debian/passwd.templates	2002-10-27 12:59:14.000000000 -0500
@@ -43,12 +43,23 @@
  The username should start with a lower-case letter, which can be followed
  by any combination of numbers and more lower-case letters. 
 
+Template: passwd/initial-groups
+Type: string
+Default: audio video cdrom
+Description: Enter the groups you want the account to be in:
+ Enter a space-separated list of groups you want the initial user
+ account to be in.
+ .
+ The defaults include "audio", which lets the user play sound,
+ "video", which lets the user play video, and "cdrom", which allows
+ mounting CD-ROM type devices.
+
 Template: passwd/username-bad
 Type: note
-Description: Invalid username entered.
- The user name you entered is invalid. Note that usernames must start with
- a lower-case letter, which can be followed by any combination of numbers
- and more lower-case letters. 
+Description: Invalid username or group name entered.
+ The user or group name you entered is invalid. Note that usernames
+ must start with a lower-case letter, which can be followed by any
+ combination of numbers and more lower-case letters.
 
 Template: passwd/user-fullname
 Type: string
diff -uNr shadow-4.0.3/debian/rules shadow-4.0.3.hacked/debian/rules
--- shadow-4.0.3/debian/rules	2002-10-27 20:34:16.000000000 -0500
+++ shadow-4.0.3.hacked/debian/rules	2002-10-27 17:16:25.000000000 -0500
@@ -80,6 +80,7 @@
 	dh_shlibdeps
 	dh_installdeb
 	debconf-mergetemplate debian/passwd.templates* > debian/passwd/DEBIAN/templates
+	dh_installdebconf
 	dh_gencontrol
 	dh_md5sums
 	dh_builddeb -ppasswd
diff -uNr shadow-4.0.3/debian/rules~ shadow-4.0.3.hacked/debian/rules~

--- End Message ---
--- Begin Message ---
Source: adduser
Source-Version: 3.90

We believe that the bug you reported is fixed in the latest version of
adduser, which is due to be installed in the Debian FTP archive:

adduser_3.90.dsc
  to pool/main/a/adduser/adduser_3.90.dsc
adduser_3.90.tar.gz
  to pool/main/a/adduser/adduser_3.90.tar.gz
adduser_3.90_all.deb
  to pool/main/a/adduser/adduser_3.90_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marc Haber <[EMAIL PROTECTED]> (supplier of updated adduser package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 23 Jun 2006 14:23:00 +0000
Source: adduser
Binary: adduser
Architecture: source all
Version: 3.90
Distribution: unstable
Urgency: low
Maintainer: Debian Adduser Developers <[EMAIL PROTECTED]>
Changed-By: Marc Haber <[EMAIL PROTECTED]>
Description: 
 adduser    - Add and remove users and groups
Closes: 147518 166718 212452 233894 239006 240707 240855 351968 357978 366885 
367213 367380 370030 372599 374316
Changes: 
 adduser (3.90) unstable; urgency=low
 .
   * 3.89 is not an NMU, I botched up the changelog. Fixing.
 .
 adduser (3.89) unstable; urgency=low
 .
   * Add additional check to testsuite/test8.pl to make sure system users are
     not added to extra groups. (sg)
   * New translations:
     - lt (Gintautas Miliauskas <[EMAIL PROTECTED]>) (sg) Closes: #374316
   * 3.88 was in experimental for a week without any bug reports.
   * now upload to unstable to let potential breakage begin.
 .
 adduser (3.88) experimental; urgency=low
 .
   [ Marc Haber ]
   * experimental version
   * Update French (fr) program translation.
     Thanks to Thomas Huriaux. Closes: #366885
   * Update French (fr) manpage translation.
     Thanks to Nicolas François. Closes: #367380
   * Apply two small patches to deluser man page.
     Thanks to Florentin Duneau. Closes: #367213
   * Update Italian (it) program and manpage translations.
     Thanks to Luca Monducci. Closes: #370030
   * Standards-Version: 3.7.2, no changed necessary.
 .
   [ Stephen Gran ]
   * allow additional groups to be used for a new user.
     Closes: #147518, #166718, #212452, #233894, #239006, #240707, #240855
   * test 8 now adds a group, and adds the new user to that group - this should
     ensure that the new additional groups feature does not get invoked for
     'adduser to group' code paths
   * Fix "adduser: adduser:" output of error messages.
   * Fix error messages like "foo ", gtx( ..., whch does not produce
     output at all. Closes: #351968
   * Honor system PATH, do not hard-code paths to sub-programs.
     Closes: #357978
   * deluser should match its documentation, and exit 0 when asked to remove a
     system user that doesn't exist. Closes: #372599
Files: 
 472952b16a34235730954de422ba3b45 645 admin important adduser_3.90.dsc
 c1c1bd8dc8700c6457a30145e8f6e18f 217270 admin important adduser_3.90.tar.gz
 5d2f069404c3cf0ba41e9c8d0b444545 161918 admin important adduser_3.90_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEm/nmgZalRGu6PIQRAtouAJ41L1parmxhDT0qKMDs+pRnyhsBRQCgsOPW
I34N2H/1wcqSyCosvgA6lDU=
=nXiV
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to