Your message dated Wed, 31 May 2023 13:04:19 +0000
with message-id <[email protected]>
and subject line Bug#1032932: fixed in git-buildpackage 0.9.31
has caused the Debian Bug report #1032932,
regarding git-buildpackage: --no-sign-tags doesn't take effect if git config
says to sign tags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1032932: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032932
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-buildpackage
Version: 0.9.22
Severity: important
Tags: patch
X-Debbugs-Cc: [email protected]
Dear Maintainer,
My gitconfig contains
[tag]
gpgsign = true
When calling
gbp import-dsc --pristine-tar --no-sign-tags
I get prompted by gpg to sign my tags.
With the `--no-sign-tags` option, I would expect it to instruct git to **not**
sign tags.
The following patch (also available
https://github.com/pexip/os-git-buildpackage/commit/8ef3ec7880caaf167429426142b0aa965ee41dd5)
resolves the issue for me.
diff --git a/gbp/git/repository.py b/gbp/git/repository.py
index e21b19e..90c8395 100644
--- a/gbp/git/repository.py
+++ b/gbp/git/repository.py
@@ -676,6 +676,8 @@ class GitRepository(object):
if sign:
args += ['-s']
args += ['-u', keyid] if keyid else []
+ else:
+ args += ['--no-sign']
args += [name]
args += [commit] if commit else []
self._git_command("tag", args)
-- System Information:
Debian Release: 11.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-17-amd64 (SMP w/16 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages git-buildpackage depends on:
ii devscripts 2.21.3+deb11u1
ii git 1:2.30.2-1
ii man-db 2.9.4-2
ii python3 3.9.2-3
ii python3-dateutil 2.8.1-6pexip3
ii python3-pkg-resources 52.0.0-4
ii sensible-utils 0.0.14
Versions of packages git-buildpackage recommends:
ii cowbuilder 0.89
ii pbuilder 0.231
ii pristine-tar 1.49
ii python3-requests 2.25.1+dfsg-2
Versions of packages git-buildpackage suggests:
pn python3-notify2 <none>
ii sudo 1.9.5p2-3
ii unzip 6.0-26+deb11u1
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: git-buildpackage
Source-Version: 0.9.31
Done: Guido Günther <[email protected]>
We believe that the bug you reported is fixed in the latest version of
git-buildpackage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated git-buildpackage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 31 May 2023 10:59:35 +0200
Source: git-buildpackage
Architecture: source
Version: 0.9.31
Distribution: experimental
Urgency: medium
Maintainer: Guido Günther <[email protected]>
Changed-By: Guido Günther <[email protected]>
Closes: 968329 1030534 1032932 1035838
Changes:
git-buildpackage (0.9.31) experimental; urgency=medium
.
[ Guido Günther ]
* Upload to experimental.
gbp-import-orig when used with --upstream-vcs-tag now strips extensions
like
'dfsg', 'ds' or 'repack' from upstream version numbers and handles the
'really' convention. Let's test this in experimental before uploading to
unstable.
* [cf5b2ad] config: Print sensible error message on duplicate sections.
Don't confuse users with a backtrace.
* [a420bc9] gbp/deb/git: Don't strip ~ patterns unconditionally.
They're needed when packaging upstream beta versions. So use
a positive list instead.
Fixes: a5575e178639a8e167c7f3090263a03b362e05e7
* [9c4841e] d/rules: Check for DEB_BUILD_OPTIONS
* [e358254] dch: Catch d/control parse errors too.
Print a clear error message instead of hiding it in the backtrace.
Thanks to Mechtilde Stehmann for the report
* [4f909d2] pq: Roll back on all errors.
Drop the pq branch on all exceptions not only on the ones gbp throws
itself. This makes sure the result is consistent in such situations (no
patches applied).
* [8dfec59] patch_series: Ignore whitespace lines.
E.g. python-coverage has a form feed in the series file.
Thanks to Ian Jackson for the detailed report (Closes: #1030534)
* [c72464b] gbp-upload: Check if remote exists
.
[ Akbarkhon Variskhanov ]
* [afcd15b] create-remote-repo.xml: Fix minor typo
.
[ Samuel Henrique ]
* [11728ec] rpm/policy: Add missing dash before version in RPM changelog
header.
.
[ Huw Jones ]
* [3434531] repository.create_tag: Explicitly don't sign when sign=False.
This avoids `tag.gpgsign = true` from git-config leaking through.
(Closes: #1032932)
.
[ Richard Laager ]
* [29370b5] import-orig: Parse various Debian version patterns.
This parses common Debian version patterns into the "real" upstream
version. For example, 1.1.8+dfsg1 becomes 1.1.8. This strips epochs,
handles the +really convention, finds git revisions, and strips other +
or ~ patterns. (Closes: #968329)
.
[ Junichi Uekawa ]
* [f0e9d41] docs: gbp-pq manpage: refer to the moved location
gbp-pq manpage refers to a page that says the content has moved.
I think it can refer to the local html copy[1], or the internet copy.
[1] /usr/share/doc/git-buildpackage/manual-html/gbp.patches.html
(Closes: #1035838)
Checksums-Sha1:
e18c5f44c56c6c8c8c6c3a62b2300f7b48038947 2372 git-buildpackage_0.9.31.dsc
0d37aad346857f61cdc57129108ea4aed84ad3f4 3532384 git-buildpackage_0.9.31.tar.xz
917e0095c3ca650aa6aece10e91f2f085ac4f323 13345
git-buildpackage_0.9.31_amd64.buildinfo
Checksums-Sha256:
cc87f1ede300deacc44386494aac30d9fd02dd0f22e5a17543207b859f321df6 2372
git-buildpackage_0.9.31.dsc
cb293e00e425e7e9c3af0a41154602be012d78fd9a6ffecd53b7f702c72436a8 3532384
git-buildpackage_0.9.31.tar.xz
d3ae2bedc7a039c3f4aab24888884ae2c9582c51039e41c919048ec5aa3de912 13345
git-buildpackage_0.9.31_amd64.buildinfo
Files:
8dd024d7b687b43eaf529e0e77bebb22 2372 vcs optional git-buildpackage_0.9.31.dsc
ea33bf627378dfa63f788dfd95b57215 3532384 vcs optional
git-buildpackage_0.9.31.tar.xz
0f3669c6c4ad2149ddcbf591aa645d82 13345 vcs optional
git-buildpackage_0.9.31_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEY/bM35YinQkoayrDJb+GUkr8weMFAmR3QbIACgkQJb+GUkr8
weOyLA/9EDwiWO0vA4yYphh/A5fTDVGuKGnIG2F7eAE0LZKMqBOS4wCgsxpLWYDj
7g6zMP5kjSelvOmFfkIt4xHk9gRDVaxoHS21vNvtVjYKriIWFPuu6erhiIs1ErQ/
FmdtjfldmsScQ/9QELHIyYM9TkuUQtfCBiM1k/9Q6nk+TJfeWGsD3+vEfgsS0Svh
PeY0K1+jlmQ26NbiIL0LRh1wqK1JjkcmGp/HRfs9m1QbfwO8Ab4eSwyu5u7Rg3MW
GxXCQYY5QE0Sw68MJWXQFTyzK5lrbGaJ7rwCVDHiEqA0UjQ66UfxdS5qzLxk2Xmn
cUI5IJBb78O87KFMcKgoM8n82i8hj8hthNIk/BqR5kUs49+bQ5qOUMORWBjmXeOc
66xeIFmUsmlL9DJak5JG0ZDWEgZhG1VNSUcfXWnrtzjQ+h1WnQY4eNVt9IBrawNp
4bTN0MuKY/Smzju3aUk5VJ6JIbfby2YJufYSDo+nKvArT03JnvOcxQZWK1hxrN6E
voEgIoEG+58ma9RiRDUbwYWGg6RDjk+OW7SisnjhBWGT9DDVF2GQ/gTgOvpDD5YM
5i+ZDg/dpFDGlI6wNP7MF3zHOh0EyYieSh4xnihHe9QmgBDic8YvPoK5hqFcUEcs
/D/fyzVvelLsP6ywILErd3lsfZenWiR9Fzwf8DLOq/K2AkQbLH4=
=+cAR
-----END PGP SIGNATURE-----
--- End Message ---
