Your message dated Thu, 22 Jun 2023 23:29:36 +0000 with message-id <[email protected]> and subject line Bug#1038821: Removed package(s) from unstable has caused the Debian Bug report #931085, regarding mailavenger: drops TCP immediately after receiving 'QUIT', without sending the 221 response to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 931085: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931085 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: mailavenger Version: 0.8.5-1 Severity: normal Hi Dererk, It seems that mailavenger does not actually send the '221 {hostname}' message that it is supposed to (despite showing it doing so in its debugging output). This appears to make some SMTP clients decide that the email was not sent (despite having received the '250 ok' after the data, resulting in them sending the same mail repeatedly. One can easily confirm this with swaks, thus: swaks --from [email protected] --to [email protected] --server=my.avenger.host Which will give you a result which ends with something like this: =-=-=-=- ... -> This is a test mailing -> -> -> . <- 250 ok -> QUIT *** Remote host closed connection unexpectedly. =-=-=-=- The thing that makes this "unexpected" is that the 221 response is missing. This would seem to be because the IO is not being flushed when the socket is closed. This can be fixed by adding a flush, as you can see in this git branch: https://salsa.debian.org/philh/mailavenger/tree/premature-close-bug-fixed Specifically in this patch file: https://salsa.debian.org/philh/mailavenger/blob/premature-close-bug-fixed/debian/patches/flush-aio-to-force-sending-of-farewell-p.patch (I've attached that patch to this report, just for completeness) It would not surprise me if there's a better way to do this, but this does at least work. The reason I suspect that there's a better way is that presumably there are other places where the connection is being dropped with unsent messages in the buffers, so it probably ought to be fixed in the code responsible for bringing the connection down. The result of building with this patch is currently running on my smtp server, so one can demonstrate the correct behaviour that this results in with telnet, thus: =-=-=-=- phil@whist ~ % telnet mail.hands.com 25 Trying 78.129.164.123... Connected to mail.hands.com. Escape character is '^]'. 220 free.hands.com ESMTP quit 221 free.hands.com Connection closed by foreign host. =-=-=-=- Note the line "221 free.hands.com" -- this line is missing when running the 0.8.5-1 version. BTW also in that salsa repo, I've added a configuration to run salsa-CI, as well as the beginnings of an autopkgtest test. The autopkgtest does work when run locally, but seems not to work within docker as in the salsa-CI setup, presumably because networking is different within the container -- I'll fix that if I can work out what's up. The following system information is from my laptop, which exhibits the same symptoms as the server, but may well have more recent packages. Feel free to ask for the info from the server if you think it's important. Cheers, Phil. -- System Information: Debian Release: 10.0 APT prefers testing APT policy: (500, 'testing'), (500, 'stable'), (300, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_DIE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages mailavenger depends on: ii adduser 3.118 ii dma [mail-transport-agent] 0.11-1+b1 ii libc6 2.28-10 ii libdb5.3 5.3.28+dfsg1-0.5 ii libgcc1 1:8.3.0-6 ii libpcap0.8 1.8.1-6 ii libssl1.1 1.1.1c-1 ii libstdc++6 8.3.0-6 ii lsb-base 10.2019051400 mailavenger recommends no packages. mailavenger suggests no packages. -- no debconf informationFrom: Philip Hands <[email protected]> Date: Tue, 25 Jun 2019 12:32:00 +0200 X-Dgit-Generated: 0.8.5-1.1~hands1 aeafef4798f48117120eb6e9eef9d11c77ee2dfb Subject: flush aio, to force sending of farewell packet I suspect that there's a better way to do this, as it seems to me that the library should know to flush all IO when the socket is closed. However this is a trivial change, and it does work. --- --- mailavenger-0.8.5.orig/asmtpd/smtpd.C +++ mailavenger-0.8.5/asmtpd/smtpd.C @@ -889,6 +889,7 @@ smtpd::getcmd (str line, int err) } else if (cmd == "quit") { aio << "221 " << opt->hostname << "\r\n"; + aio->flush (); delete this; } else if (cmd == "noop")
--- End Message ---
--- Begin Message ---Version: 0.8.5-2+rm Dear submitter, as the package mailavenger has just been removed from the Debian archive unstable we hereby close the associated bug reports. We are sorry that we couldn't deal with your issue properly. For details on the removal, please see https://bugs.debian.org/1038821 The version of this package that was in Debian prior to this removal can still be found using https://snapshot.debian.org/. Please note that the changes have been done on the master archive and will not propagate to any mirrors until the next dinstall run at the earliest. This message was generated automatically; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]. Debian distribution maintenance software pp. Scott Kitterman (the ftpmaster behind the curtain)
--- End Message ---
