Your message dated Mon, 17 Jul 2023 05:06:00 +0000
with message-id <[email protected]>
and subject line Bug#990533: fixed in f2fs-tools 1.16.0-1
has caused the Debian Bug report #990533,
regarding f2fs-tools: suggestions for the packaging
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
990533: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990533
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:f2fs-tools
Severity: wishlist
Tags: patch
Hello.
Please consider the attached style suggestions for the Debian
packaging.
>From 357cc821b7ed2bd1e6616a6b964780aeedfb2b83 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez <[email protected]>
Date: Thu, 1 Jul 2021 11:09:38 +0200
Subject: [PATCH 1/4] Remove get-orig-source target from debian/rules
uscan is preferred when possible
---
debian/rules | 7 -------
1 file changed, 7 deletions(-)
diff --git a/debian/rules b/debian/rules
index 298b739..d494e69 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,13 +24,6 @@ override_dh_install:
override_dh_strip:
dh_strip --dbgsym-migration='f2fs-tools-dbg (<< 1.12.0-1~)'
-get-orig-source:
- wget http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs-tools.git/snapshot/f2fs-tools-$(DEB_VERSION_UPSTREAM).tar.gz
- gunzip < f2fs-tools-$(DEB_VERSION_UPSTREAM).tar.gz | \
- xz > f2fs-tools-$(DEB_VERSION_UPSTREAM).tar.xz
- rm f2fs-tools-$(DEB_VERSION_UPSTREAM).tar.gz
- mv f2fs-tools-$(DEB_VERSION_UPSTREAM).tar.xz f2fs-tools_$(DEB_VERSION_UPSTREAM).orig.tar.xz
-
# dh_dwz when run on f2fs-tools-udeb ends up installing the
# /usr/lib/debug/.dwz files into the udeb. I think that's a bug,
# but for now, override it by just saying... just don't.
--
2.30.2
>From 93b6af0a23efeab80519595f3649d091c1e21947 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez <[email protected]>
Date: Thu, 1 Jul 2021 11:12:22 +0200
Subject: [PATCH 2/4] Remove redundant libdir option from dh_auto_configure
override
dh_auto_configure already sets this option explicitly
---
debian/rules | 1 -
1 file changed, 1 deletion(-)
diff --git a/debian/rules b/debian/rules
index d494e69..9dd7659 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,7 +12,6 @@ include /usr/share/dpkg/default.mk
override_dh_auto_configure:
dh_auto_configure -- --sbindir=/sbin --disable-shared \
- --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) \
--with-root-libdir=/lib/$(DEB_HOST_MULTIARCH)
override_dh_install:
--
2.30.2
>From 68eb8fa80bfe5409095f6ea04dbd3728027241f6 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez <[email protected]>
Date: Thu, 1 Jul 2021 11:14:00 +0200
Subject: [PATCH 3/4] Stop exporting build flags from debian/rules
dh_auto_* tools already export the build flags, whether debian/rules
knowns about them or not.
In this case, debian/rules does not need to interfer.
The test_printenv target seems to have been introduced in order to
check the removed export.
---
debian/rules | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/debian/rules b/debian/rules
index 9dd7659..9bc4df8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,8 +4,7 @@
export DEB_BUILD_MAINT_OPTIONS ?= hardening=+all
-DPKG_EXPORT_BUILDFLAGS = 1
-include /usr/share/dpkg/default.mk
+include /usr/share/dpkg/architecture.mk
%:
dh $@
@@ -28,6 +27,3 @@ override_dh_strip:
# but for now, override it by just saying... just don't.
override_dh_dwz:
dh_dwz -N f2fs-tools-udeb
-
-test_printenv:
- printenv | sort
--
2.30.2
>From 0a83de005e2e72e02d847454b588d0f63bbc033c Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez <[email protected]>
Date: Thu, 1 Jul 2021 11:33:52 +0200
Subject: [PATCH 4/4] Switch to debhelper 13
dh_missing is now enabled by default
---
debian/control | 2 +-
debian/f2fs-tools-udeb.install | 3 ++-
debian/f2fs-tools.install | 4 +++-
debian/not-installed | 5 +++++
debian/rules | 6 ------
5 files changed, 11 insertions(+), 9 deletions(-)
create mode 100644 debian/not-installed
diff --git a/debian/control b/debian/control
index 994b60d..a177742 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: optional
Maintainer: Filesystems Group <[email protected]>
Uploaders: Vincent Cheng <[email protected]>, Theodore Y. Ts'o <[email protected]>
Build-Depends:
- debhelper-compat (= 12),
+ debhelper-compat (= 13),
libblkid-dev,
libselinux1-dev,
pkg-config,
diff --git a/debian/f2fs-tools-udeb.install b/debian/f2fs-tools-udeb.install
index d48cf30..5779210 100644
--- a/debian/f2fs-tools-udeb.install
+++ b/debian/f2fs-tools-udeb.install
@@ -1 +1,2 @@
-/sbin
+# All but sbin/sg_write_buffer
+sbin/*f2fs*
diff --git a/debian/f2fs-tools.install b/debian/f2fs-tools.install
index c5dbdb2..1b7999a 100644
--- a/debian/f2fs-tools.install
+++ b/debian/f2fs-tools.install
@@ -1,2 +1,4 @@
-sbin/*
+# All but sbin/sg_write_buffer
+sbin/*f2fs*
+
usr/share/man/man8/*.8
diff --git a/debian/not-installed b/debian/not-installed
new file mode 100644
index 0000000..5cb77ca
--- /dev/null
+++ b/debian/not-installed
@@ -0,0 +1,5 @@
+# Policy recommends not to install libtool .la files
+usr/lib/*/libf2fs*.la
+
+# See f2fs-tools.install and f2fs-tools-udeb.install
+sbin/sg_write_buffer
diff --git a/debian/rules b/debian/rules
index 9bc4df8..67c1e09 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,12 +13,6 @@ override_dh_auto_configure:
dh_auto_configure -- --sbindir=/sbin --disable-shared \
--with-root-libdir=/lib/$(DEB_HOST_MULTIARCH)
-override_dh_install:
- find $(CURDIR) -name "*.la" -delete
- rm $(CURDIR)/debian/tmp/sbin/sg_write_buffer
- dh_install
- dh_missing --fail-missing
-
override_dh_strip:
dh_strip --dbgsym-migration='f2fs-tools-dbg (<< 1.12.0-1~)'
--
2.30.2
--- End Message ---
--- Begin Message ---
Source: f2fs-tools
Source-Version: 1.16.0-1
Done: Vincent Cheng <[email protected]>
We believe that the bug you reported is fixed in the latest version of
f2fs-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vincent Cheng <[email protected]> (supplier of updated f2fs-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 16 Jul 2023 21:03:45 -0700
Source: f2fs-tools
Built-For-Profiles: noudeb
Architecture: source
Version: 1.16.0-1
Distribution: unstable
Urgency: medium
Maintainer: Filesystems Group <[email protected]>
Changed-By: Vincent Cheng <[email protected]>
Closes: 990533
Changes:
f2fs-tools (1.16.0-1) unstable; urgency=medium
.
[ Vincent Cheng ]
* New upstream release.
* Updated Standards compliance to 4.6.2.
.
[ Nicolas Boulenguez ]
* Various packaging improvements. (Closes: #990533)
Checksums-Sha1:
462d83754c8e409b7adac2518d38106eb5fa02ce 2269 f2fs-tools_1.16.0-1.dsc
38134d84764b01261506d1534a05314c40d3696d 202368 f2fs-tools_1.16.0.orig.tar.xz
2b352f0ece3c3a1a404ca3541282b544607aef09 6504 f2fs-tools_1.16.0-1.debian.tar.xz
Checksums-Sha256:
6dd37c5aa9eaebff9f5eebed390a895a182e1ed276ce1489ceccb1226c03dc7a 2269
f2fs-tools_1.16.0-1.dsc
fe25b17422f278e5fc0c6ae9977d814fe3122b5bc82dd92a58296fad57263d9c 202368
f2fs-tools_1.16.0.orig.tar.xz
9915fe7e6c771b8353637000b7811b05b187b4513e5e32c50e2b5f3341d32303 6504
f2fs-tools_1.16.0-1.debian.tar.xz
Files:
66f0628476c7363fad925d67199b83d1 2269 admin optional f2fs-tools_1.16.0-1.dsc
3da2cb931b7102628e846b96014a91f8 202368 admin optional
f2fs-tools_1.16.0.orig.tar.xz
6ddd2435a9005fc2b087f8454c71a7cb 6504 admin optional
f2fs-tools_1.16.0-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE1TqBWjy3ZZr4guOVju3MG6ofMv8FAmS0wyUACgkQju3MG6of
Mv8PQRAA6i+MhNyqAS4mNfm/PgS+7cMjtfA3iE4qMFKjr0UFQ8GjEPumH1pcPm1D
REQS4Ba5t5qL32aE449Hatm12bbrv2yRbp36Qq0HcFcXe07hEvUZ3iK48uZ7Ealo
1TACVInZ+ERqYfbdsaqH6JVW34VLSmqYs9AUydBS4Mi/ahOrfzwcQXxwXrpwQ4JG
kVohLnmtISvYWEIqM5wpMRG+hiLPcj8K77WzTovhgCG66x933L1SXYVR/fC6v05Z
k60lSV/5Do4YDcO4eVG10pXpv47Gg48aTR+NW8ID8WXZ0/V6PtBzyRwlkbKsGz/r
YQgSpXSwObeAInwF81ejq7wIrc3ZIVuA0j2LfjZNfvI+xnSIh4t+K9lIIk+LM/5/
u6ezntUCIJ/sZKJb6QlGNOaElaGyjulybEPk2XgWDlDYmZqBQzffzbiSs1UPqq9t
S7rXboj9LQ1lunsa4ukECISigRtEmjMSNJaCNbm3uXy1EAfnq5863XfMHlbEsG/1
Qnzd7G7868qddxbPlm95eYwpq6zq+X6cWqVYY0FmG6wR9NSEVzt/F51KCpQI0ujE
6meLwiKxLp5RKsKriYk5Gtnbeyv2x90NbRYJ6i0TiTettn/5L9QndaVgIO6GZPFE
1il0YBjqDjRe3dOvD9WJylwMQXkz0PFVhupy8rODRT7EZxmMSLA=
=jCvS
-----END PGP SIGNATURE-----
--- End Message ---
