Your message dated Mon, 17 Jul 2023 06:34:05 +0000
with message-id <[email protected]>
and subject line Bug#1033588: fixed in bash-completion 1:2.11-7
has caused the Debian Bug report #1033588,
regarding bash-completion: unquoted tilde in _quote_readline_by_ref causes NSS
lookups
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1033588: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033588
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bash-completion
Version: 1:2.11-2
Severity: minor
X-Debbugs-Cc: none, Łukasz Stelmach <[email protected]>
File: /usr/share/bash-completion/bash_completion
Control: -1 patch
Dear Maintainer,
The second elif in debian/patches/00-fix_quote_readline_by_ref.patch
file compares parameter against ~* string. The tring isn't quoted
because the asterisk is meant to act as a glob pattern. However, before
the glob match happens, the tilde triggers unnecessary NSS lookup for a
user "*". This may causes very annoying delays with network backed NSS
modules.
I am attaching a fixed version of the patch file with the tilde quote.
-- System Information:
Debian Release: 11.6
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.10.0-20-amd64 (SMP w/4 CPU threads)
Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-- no debconf information
--
Miłego dnia,
Łukasz Stelmach
--- a/bash_completion
+++ b/bash_completion
@@ -526,9 +526,15 @@
# @param $2 Name of variable to return result to
_quote_readline_by_ref()
{
- if [[ $1 == \'* ]]; then
+ if [ -z "$1" ]; then
+ # avoid quoting if empty
+ printf -v $2 %s "$1"
+ elif [[ $1 == \'* ]]; then
# Leave out first character
printf -v $2 %s "${1:1}"
+ elif [[ $1 == \~* ]]; then
+ # avoid escaping first ~
+ printf -v $2 ~%q "${1:1}"
else
printf -v $2 %q "$1"
fi
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: bash-completion
Source-Version: 1:2.11-7
Done: Gabriel F. T. Gomes <[email protected]>
We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gabriel F. T. Gomes <[email protected]> (supplier of updated bash-completion
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 16 Jul 2023 23:01:32 -0700
Source: bash-completion
Architecture: source
Version: 1:2.11-7
Distribution: unstable
Urgency: medium
Maintainer: Gabriel F. T. Gomes <[email protected]>
Changed-By: Gabriel F. T. Gomes <[email protected]>
Closes: 1033588 1033642 1033847
Changes:
bash-completion (1:2.11-7) unstable; urgency=medium
.
[Gabriel F. T. Gomes]
* Remove patch for quotes in readline (Closes: #1033847, #1033588).
* Cherry-pick fix for ssh PubkeyAcceptedKeytypes (Closes: #1033642).
.
[Heinrich Schuchardt]
* Add showsrc and source to aptitude completion.
Checksums-Sha1:
b0e2f7f63bb784dda057919ba3729336c858f187 1965 bash-completion_2.11-7.dsc
8e34fc5d104767bf9dfa504b2162509a90370c42 21804
bash-completion_2.11-7.debian.tar.xz
37843d0c1099d23bb960bcf53d0f9340be00a94e 6036
bash-completion_2.11-7_amd64.buildinfo
Checksums-Sha256:
ead09f50904c55725710fa518c9a2ced7fb0ed3164d3c11111e32a8178793b5c 1965
bash-completion_2.11-7.dsc
b0aacd440c522a2954e48defc615790cf9fedefebb85e995c56d613ddac63fc8 21804
bash-completion_2.11-7.debian.tar.xz
97d5577317d6ab78ce58063fa03fbb6165dbe4dfad22a8e919ab9f0539b70f65 6036
bash-completion_2.11-7_amd64.buildinfo
Files:
509fbe9d534ddf7b8f55a1c318e69560 1965 shells standard
bash-completion_2.11-7.dsc
85750ec20a8d145d8025831b1db4b0d3 21804 shells standard
bash-completion_2.11-7.debian.tar.xz
ed802efa9ec02ded44a0e98a2128c228 6036 shells standard
bash-completion_2.11-7_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCgAxFiEE+wUJHFVUA1wadvc8rpsRODhuyvIFAmS025MTHGdhYnJpZWxA
ZGViaWFuLm9yZwAKCRCumxE4OG7K8nEjEAC0WKQQ48CMriuoaXLYGOhq6MhUrGTy
XqJBC+7KWEWUKLleONX7tAIuNaKUxnTb2Xon2iKC+QNVAvlnCL+csY3ONligv1I7
c+HFrMhFJo8EnfCREfIJNreYkc9QGBagW7aVxmCsziUWen7vNuvm2p8Z+hmzKcKu
aQwJ50pBNBTQQ7UUoxvidARTt180OurV9ob7wbum4MvG1qY85/+3IcKi3c+umk8i
nYhAEUM4Cm+w3OvRRBiu7CskF694V9ynzubPRMfUJcd2TDg3Z5Ealt8UuUv4lvPt
3vsypOAfnHngn+zL99TfrY60zVONQwTv2946V5E1agmruQcZAv2r+XfZUfHHCsyE
7YBLlf4I5XyKixjdi3zlM6Rw8hiY2aIvO8g6oqauR1s6xA/1/DG16QdtmAF4xESU
aXFe+Uj2MufXj3sntVLFZth0XYwwORxS6Q3DiLc0e+tHPyb16IfFPD9Zwx8VZPJq
wA1wilLiAQc93CKitobb24laPXgaGR41Low+UDAOzMUCSW21O2ITusEQKI654lGQ
onayYwGoxdKGF6MnftQQm4NLAR4vtCUAmxGblYAzzVWrS51WzeF3ugL2TvBBa6Ed
Ojq/57+uZ7ClG5OhMa+5/SKkEBbdWsU3zqBa+P1qDQwdZJ8UqhpS3DNiYeL//rDX
79qb7LRhxLgaRQ==
=zIiT
-----END PGP SIGNATURE-----
--- End Message ---