Your message dated Tue, 25 Jul 2023 11:47:43 -0700
with message-id <87351bg75c.fsf@wireframe>
and subject line Re: Bug#1024329: u-boot: extlinux.conf prompt value is ignored
has caused the Debian Bug report #1024329,
regarding u-boot: extlinux.conf prompt value is ignored
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1024329: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024329
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: u-boot
Version: 2021.01+dfsg-5
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
Hi vagrant,
during testing on the imx6 colibri board i recognized
that the prompt value of extlinux.conf is ignored.
The attached patch fixes the problem.
Can it be added to debian or shall I try to submit
it upstream first?
cu, Manuel
From: Manuel Traut <[email protected]>
Date: Thu, 17 Nov 2022 16:38:47 +0100
Subject: distro/pxe boot: read prompt value from config
Currently the configuration of prompt in extlinux.conf is
ignored.
Read it from the file, if not given do not fail.
Signed-off-by: Manuel Traut <[email protected]>
---
boot/pxe_utils.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index 8133006..a6c56e0 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -1359,7 +1359,10 @@ static int parse_pxefile_top(struct pxe_context *ctx,
char *p, unsigned long bas
break;
case T_PROMPT:
- eol_or_eof(&p);
+ err = parse_integer(&p, &cfg->prompt);
+ // Do not fail if prompt configuration is missing
+ if (err < 0)
+ eol_or_eof(&p);
break;
case T_EOL:
--- End Message ---
--- Begin Message ---
Version: 2023.04~rc2+dfsg-1
On 2022-11-17, Manuel Traut wrote:
> during testing on the imx6 colibri board i recognized
> that the prompt value of extlinux.conf is ignored.
...
> From: Manuel Traut <[email protected]>
> Date: Thu, 17 Nov 2022 16:38:47 +0100
> Subject: distro/pxe boot: read prompt value from config
>
> Currently the configuration of prompt in extlinux.conf is
> ignored.
>
> Read it from the file, if not given do not fail.
>
> Signed-off-by: Manuel Traut <[email protected]>
Thanks for getting this merged upstream!
This was fixed upstream in v2023.04-rc1, the first upload to debian that
contained the fix was 2023.04~rc2+dfsg-1.
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
