Your message dated Tue, 25 Jul 2023 21:32:26 +0000
with message-id <[email protected]>
and subject line Bug#1039868: fixed in logrotate 3.18.0-2+deb11u2
has caused the Debian Bug report #1039868,
regarding logrotate: logrotate -s /dev/null replaces /dev/null with a regular
file
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1039868: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039868
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: logrotate
Version: 3.18.0-2+deb11u1
Severity: normal
User: [email protected]
Usertags: origin-kali
Dear Maintainer,
this bug affects Debian bullseye (ie. logrotate 3.18). It was fixed
upstream in version 3.19.
The command 'logrotate --state /dev/null ...' happily replaces the
device /dev/null with a regular file, breaking the system badly, in a
non-obvious way.
Steps to reproduce:
# ls -l /dev/null
crw-rw-rw- 1 root root 1, 3 Jun 29 01:43 /dev/null
# logrotate --state /dev/null /etc/logrotate.conf
# ls -l /dev/null
-rw-rw--w- 1 root root 1257 Jun 29 02:19 /dev/null
Steps to recover:
# rm -f /dev/null; mknod -m 0666 /dev/null c 1 3
I looked at the 'bullseye' branch of the Salsa repo [1], I've seen that
you imported a number of patches related to the state file. In
particular, the patch Do-not-lock-state-file-dev-null.patch is what lead
me to shot myself in the foot, since it adds two lines in the manual
page, suggesting to use /dev/null as a state file:
++If \fI/dev/null\fR is given as the state file, then \fBlogrotate\fR will
++not try to lock or write the state file.
However, in your series of upstream patches, I think you missed this one:
https://github.com/logrotate/logrotate/commit/45669264
Given the potential for destruction of 'logrotate -s /dev/null', and
seeing how simple is the patch above, would you consider doing an
upload to fix it in bullseye?
Best,
Arnaud
----
[1] https://salsa.debian.org/debian/logrotate/-/tree/bullseye
--- End Message ---
--- Begin Message ---
Source: logrotate
Source-Version: 3.18.0-2+deb11u2
Done: Christian Göttsche <[email protected]>
We believe that the bug you reported is fixed in the latest version of
logrotate, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christian Göttsche <[email protected]> (supplier of updated logrotate
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 30 Jun 2023 19:45:16 +0200
Source: logrotate
Architecture: source
Version: 3.18.0-2+deb11u2
Distribution: bullseye
Urgency: medium
Maintainer: Christian Göttsche <[email protected]>
Changed-By: Christian Göttsche <[email protected]>
Closes: 1039868
Changes:
logrotate (3.18.0-2+deb11u2) bullseye; urgency=medium
.
* d/patches: cherry-pick usptream fix:
- writeState: do nothing if state file is /dev/null (Closes: #1039868)
Checksums-Sha1:
94dc0273db6004375cea9f801a345537304c9c47 1677 logrotate_3.18.0-2+deb11u2.dsc
9a838853ebce1318b02550027d87ff704ccd38a5 27796
logrotate_3.18.0-2+deb11u2.debian.tar.xz
67cded35563f89d8425a47eb051685f74eb2f534 5727
logrotate_3.18.0-2+deb11u2_source.buildinfo
Checksums-Sha256:
6f8c4f67df17dd5f828959245fe5856133251544afe04492bf9cf1adb43c7c17 1677
logrotate_3.18.0-2+deb11u2.dsc
e0c010ee13536f60e8f0a19f1e4219a5f07d16e378d146b28156ee92cc45ad09 27796
logrotate_3.18.0-2+deb11u2.debian.tar.xz
879acb707864198bebe2107a61e65b028091d5e435e222f71be937a0a565d739 5727
logrotate_3.18.0-2+deb11u2_source.buildinfo
Files:
6bb8156fadea568fb8cd06ce48de990c 1677 admin important
logrotate_3.18.0-2+deb11u2.dsc
d3faad2726918a3868c3e5d8ef0a9011 27796 admin important
logrotate_3.18.0-2+deb11u2.debian.tar.xz
9cc3838da2c38e2ce6c04828a8d58786 5727 admin important
logrotate_3.18.0-2+deb11u2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iIUEARYKAC0WIQTdFzjfLGn8URFmteMDXuYJgEtROQUCZL/5BQ8cam13QGRlYmlh
bi5vcmcACgkQA17mCYBLUTmZ/QEAuENvSxC66GHhSDyrLyODuws+ObrWPF42LJQv
P+EvR10A/iPbF51yT8f+KUiPPvN+S9LAzXweIgVynZylXHffN38G
=t1J+
-----END PGP SIGNATURE-----
--- End Message ---
