Your message dated Thu, 27 Jul 2023 06:23:24 +0000
with message-id <[email protected]>
and subject line Bug#1018860: fixed in pygame 2.1.2+dfsg-6
has caused the Debian Bug report #1018860,
regarding pygame: FTBFS on riscv64: test_tick failed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1018860: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018860
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pygame
Version: 2.1.2+dfsg-4
Severity: normal
Tags: ftbfs, patch
User: [email protected]
Usertags: riscv64
X-Debbugs-Cc: [email protected]
Dear Maintainer,
"test-tick" failed on riscv64 [1] because time.sleep() takes longer than
expected. Here is the relative buildd log:
FAIL: test_tick (pygame.tests.time_test.ClockTypeTest)
Tests time.Clock.tick()
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py",
line 133, in test_tick
self.assertAlmostEqual(average_time, milliseconds, delta=epsilon)
AssertionError: 8.0 != 5.0 within 1.5 delta (3.0 difference)
The expected sleep jitter of time.sleep() (test/time_test.py::50) is
less than 1.5ms, but on riscv64 it is about 2~4ms. I have tested this on
several platforms[2].
According to the code comment, it seems that it is OK to slightly
increase the acceptable sleep jitter. So I increased it to 5ms for
riscv64 in the attached patch.
[1]https://buildd.debian.org/status/fetch.php?pkg=pygame&arch=riscv64&ver=2.1.2%2Bdfsg-4&stamp=1661783036
[2]
_https://github.com/Sakura286/TmpShare/blob/main/20220901-113930-testcase.md_
--
Regards,
--
Sakura286
--- a/test/time_test.py
+++ b/test/time_test.py
@@ -2,6 +2,8 @@
import pygame
import time
+import platform
+
Clock = pygame.time.Clock
@@ -104,7 +106,10 @@
"""
# Adjust this value to increase the acceptable sleep jitter
- epsilon = 1.5
+ if ( 'riscv64' in platform.machine() ):
+ epsilon = 5
+ else:
+ epsilon = 1.5
# Adjust this value to increase the acceptable locked frame-rate jitter
epsilon2 = 0.3
# adjust this value to increase the acceptable frame-rate margin
--- End Message ---
--- Begin Message ---
Source: pygame
Source-Version: 2.1.2+dfsg-6
Done: Vincent Cheng <[email protected]>
We believe that the bug you reported is fixed in the latest version of
pygame, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vincent Cheng <[email protected]> (supplier of updated pygame package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 26 Jul 2023 22:12:48 -0700
Source: pygame
Built-For-Profiles: noudeb
Architecture: source
Version: 2.1.2+dfsg-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <[email protected]>
Changed-By: Vincent Cheng <[email protected]>
Closes: 1018860 1026483 1027310
Changes:
pygame (2.1.2+dfsg-6) unstable; urgency=medium
.
* d/p/fix_sdl_test_ftbfs.patch: Relax strict pixel match tests in
test_src_alpha_sdl2_blitter. (Closes: #1026483)
* d/p/s390x_time_test.patch: Skip flaky tests on s390x. (Closes: #1027310)
* d/p/increase-acceptable-sleep-jitter-on-riscv64.patch: Fix flaky tests
on riscv64. (Closes: #1018860)
* Standards-Version: 4.6.2 (no changes required)
Checksums-Sha1:
7a004b9af7be110557837508353d6cb5af1a258a 2512 pygame_2.1.2+dfsg-6.dsc
5e940fecf88dc045e59ddc5f32672b915e11b924 16728
pygame_2.1.2+dfsg-6.debian.tar.xz
Checksums-Sha256:
3b16bfa1a382d9976265720f3c9ac6de4c41016960a5d9201f812322c9532022 2512
pygame_2.1.2+dfsg-6.dsc
e3b91caf179903197c288cd61f588fc0f4c0d4fd7447cf7e344ef77f348c1bc5 16728
pygame_2.1.2+dfsg-6.debian.tar.xz
Files:
8796c8850d4690d9eae44a386e9b2e9c 2512 python optional pygame_2.1.2+dfsg-6.dsc
4357a2a588f671d2b3bc35134f757f46 16728 python optional
pygame_2.1.2+dfsg-6.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE1TqBWjy3ZZr4guOVju3MG6ofMv8FAmTCBoIACgkQju3MG6of
Mv9XbA/+Ih7i4cai+E/lMGQY3GP0gePh5HxExvIzkaFEJhhZeZ0gqrOA8f03V6sy
njkUZ6htLG1FdN0kZJ48GIyNFN3PzzquHwo/wjAmPuW307Hhh38WQQ3cGNKtdf47
L8DUgGCb9Md/k4fT7SUTrrpVJPqsj3PKxeEXfaMG6KYeAoagV2GDAgcuvg6X5kzI
+R+ta2p0lLZrQz7HgvZr97aAHf07nJ1Psd5DYqIYAFAuXs3zMTl3CTREM5cCFc2e
NrBVTM9sP1EvOXh1jTZYi1gkm8g1g+UN/gi9kx8c3b+0A1+OmGAO5RWugjgnzQkb
7/eC2MGvrsj1UxI5R4yGUizquqGCaHd6BSTuFjrd5FR7PTlVLy8LOWhrekXu62VE
rwzpOor5JPIPIndU6qPKhymASA0eRXg28oLw+EIfWrrxn6Ya9e2GytJdlOVlhQVZ
QdyaeAQpzIg26YL0MZf28sKvFmaSaIuPIsiS2Px2L5/FbpmXNboh8hnJ8kxwYTel
q0LdNSuK5MFfteTmaEqV+fS+uUKfrZGZR2jMlk9dVS98r3H/Y9C5umS4XZRnuHkq
sRs7aObcfZzbjU2ymeMLYFoWbjGbVMgG6hJvaIJpI/8peDiMniHHA2eAXZQnEbD/
hjPH3A1jUO1c/BF9FOCv3JGAmtGYmfs6qYTJJNEPGV7G91Vc+RM=
=qerZ
-----END PGP SIGNATURE-----
--- End Message ---
