Your message dated Thu, 27 Jul 2023 06:23:24 +0000 with message-id <[email protected]> and subject line Bug#1027310: fixed in pygame 2.1.2+dfsg-6 has caused the Debian Bug report #1027310, regarding pygame: FTBFS on s390x (time_test fails) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 1027310: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027310 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: pygame Version: 2.1.2+dfsg-5 Severity: serious Tags: patch upstream Dear Maintainer, Your package FTBFS on s390x: ====================================================================== FAIL: test_get_time (pygame.tests.time_test.ClockTypeTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py", line 83, in test_get_time self.assertAlmostEqual(delay_miliseconds, c1, delta=delta) AssertionError: 100.0 != 182 within 50 delta (82.0 difference) ====================================================================== FAIL: test_tick (pygame.tests.time_test.ClockTypeTest) Tests time.Clock.tick() ---------------------------------------------------------------------- Traceback (most recent call last): File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py", line 155, in test_tick self.assertAlmostEqual(end - start, 1, delta=epsilon2) AssertionError: 2.06333065032959 != 1 within 0.3 delta (1.0633306503295898 difference) ====================================================================== FAIL: test_delay (pygame.tests.time_test.TimeModuleTest) Tests time.delay() function. ---------------------------------------------------------------------- Traceback (most recent call last): File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py", line 249, in test_delay self._wait_delay_check(pygame.time.delay, millis, iterations, delta) File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py", line 373, in _wait_delay_check self.assertAlmostEqual(wait_time, millis, delta=delta) AssertionError: 278 != 50 within 150 delta (228 difference) ====================================================================== FAIL: test_set_timer (pygame.tests.time_test.TimeModuleTest) Tests time.set_timer() ---------------------------------------------------------------------- Traceback (most recent call last): File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.10_pygame/build/pygame/tests/time_test.py", line 321, in test_set_timer self.assertNotIn(timer_event, pygame.event.get()) AssertionError: <Event(32851-UserEvent {})> unexpectedly found in [<Event(32851-UserEvent {})>] ---------------------------------------------------------------------- Ran 10 tests in 17.945s FAILED (failures=4) https://buildd.debian.org/status/fetch.php?pkg=pygame&arch=s390x&ver=2.1.2%2Bdfsg-5&stamp=1672327165&raw=0 https://buildd.debian.org/status/logs.php?pkg=pygame&arch=s390x Unfortunately this issue cannot be reproduced on the s390x porterbox where these tests succeed. The attached patch works around the issue by skipping these tests on s390x. Kind Regards, BasDescription: Skip tests that fail on s390x. Author: Bas Couwenberg <[email protected]> --- a/test/time_test.py +++ b/test/time_test.py @@ -1,5 +1,6 @@ import unittest import pygame +import platform import time Clock = pygame.time.Clock @@ -64,6 +65,7 @@ class ClockTypeTest(unittest.TestCase): c2 = c.get_time() self.assertAlmostEqual(c1, c2, delta=delta) + @unittest.skipIf(platform.machine() == 's390x', "Fails on s390x") def test_get_time(self): # Testing parameters delay = 0.1 # seconds @@ -94,6 +96,7 @@ class ClockTypeTest(unittest.TestCase): ) #'time' module elapsed time converted to milliseconds self.assertAlmostEqual(d0, c1, delta=delta) + @unittest.skipIf(platform.machine() == 's390x', "Fails on s390x") def test_tick(self): """Tests time.Clock.tick()""" """ @@ -240,6 +243,7 @@ class ClockTypeTest(unittest.TestCase): class TimeModuleTest(unittest.TestCase): __tags__ = ["timing"] + @unittest.skipIf(platform.machine() == 's390x', "Fails on s390x") def test_delay(self): """Tests time.delay() function.""" millis = 50 # millisecond to wait on each iteration @@ -271,6 +275,7 @@ class TimeModuleTest(unittest.TestCase): # Assert almost equality of the ticking time and time difference self.assertAlmostEqual(ticks_diff, time_diff, delta=delta) + @unittest.skipIf(platform.machine() == 's390x', "Fails on s390x") def test_set_timer(self): """Tests time.set_timer()""" """
--- End Message ---
--- Begin Message ---Source: pygame Source-Version: 2.1.2+dfsg-6 Done: Vincent Cheng <[email protected]> We believe that the bug you reported is fixed in the latest version of pygame, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Vincent Cheng <[email protected]> (supplier of updated pygame package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Wed, 26 Jul 2023 22:12:48 -0700 Source: pygame Built-For-Profiles: noudeb Architecture: source Version: 2.1.2+dfsg-6 Distribution: unstable Urgency: medium Maintainer: Debian Python Team <[email protected]> Changed-By: Vincent Cheng <[email protected]> Closes: 1018860 1026483 1027310 Changes: pygame (2.1.2+dfsg-6) unstable; urgency=medium . * d/p/fix_sdl_test_ftbfs.patch: Relax strict pixel match tests in test_src_alpha_sdl2_blitter. (Closes: #1026483) * d/p/s390x_time_test.patch: Skip flaky tests on s390x. (Closes: #1027310) * d/p/increase-acceptable-sleep-jitter-on-riscv64.patch: Fix flaky tests on riscv64. (Closes: #1018860) * Standards-Version: 4.6.2 (no changes required) Checksums-Sha1: 7a004b9af7be110557837508353d6cb5af1a258a 2512 pygame_2.1.2+dfsg-6.dsc 5e940fecf88dc045e59ddc5f32672b915e11b924 16728 pygame_2.1.2+dfsg-6.debian.tar.xz Checksums-Sha256: 3b16bfa1a382d9976265720f3c9ac6de4c41016960a5d9201f812322c9532022 2512 pygame_2.1.2+dfsg-6.dsc e3b91caf179903197c288cd61f588fc0f4c0d4fd7447cf7e344ef77f348c1bc5 16728 pygame_2.1.2+dfsg-6.debian.tar.xz Files: 8796c8850d4690d9eae44a386e9b2e9c 2512 python optional pygame_2.1.2+dfsg-6.dsc 4357a2a588f671d2b3bc35134f757f46 16728 python optional pygame_2.1.2+dfsg-6.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE1TqBWjy3ZZr4guOVju3MG6ofMv8FAmTCBoIACgkQju3MG6of Mv9XbA/+Ih7i4cai+E/lMGQY3GP0gePh5HxExvIzkaFEJhhZeZ0gqrOA8f03V6sy njkUZ6htLG1FdN0kZJ48GIyNFN3PzzquHwo/wjAmPuW307Hhh38WQQ3cGNKtdf47 L8DUgGCb9Md/k4fT7SUTrrpVJPqsj3PKxeEXfaMG6KYeAoagV2GDAgcuvg6X5kzI +R+ta2p0lLZrQz7HgvZr97aAHf07nJ1Psd5DYqIYAFAuXs3zMTl3CTREM5cCFc2e NrBVTM9sP1EvOXh1jTZYi1gkm8g1g+UN/gi9kx8c3b+0A1+OmGAO5RWugjgnzQkb 7/eC2MGvrsj1UxI5R4yGUizquqGCaHd6BSTuFjrd5FR7PTlVLy8LOWhrekXu62VE rwzpOor5JPIPIndU6qPKhymASA0eRXg28oLw+EIfWrrxn6Ya9e2GytJdlOVlhQVZ QdyaeAQpzIg26YL0MZf28sKvFmaSaIuPIsiS2Px2L5/FbpmXNboh8hnJ8kxwYTel q0LdNSuK5MFfteTmaEqV+fS+uUKfrZGZR2jMlk9dVS98r3H/Y9C5umS4XZRnuHkq sRs7aObcfZzbjU2ymeMLYFoWbjGbVMgG6hJvaIJpI/8peDiMniHHA2eAXZQnEbD/ hjPH3A1jUO1c/BF9FOCv3JGAmtGYmfs6qYTJJNEPGV7G91Vc+RM= =qerZ -----END PGP SIGNATURE-----
--- End Message ---
