Your message dated Mon, 7 Aug 2023 20:35:41 +0200
with message-id <[email protected]>
and subject line Re: Bug#1023497: libarcus: FTBFS with protobuf 3.21
has caused the Debian Bug report #1023497,
regarding libarcus: FTBFS with protobuf 3.21
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1023497: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023497
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libarcus
Version: 5.0.0-1
Severity: important
Usertags: protobuf3_21
Tags: ftbfs patch experimental
Hi,
I do plan to start the Protobuf 3.29 transition which is already
available from experimental. While your package in Sid compiles as
expected, the experimental version is not. As it's needed for the
cura-engine package, the version which is in experimental I provide
you a simple patch.
Please be prepared to apply it and upload to Sid when the Protobuf
transition starts.
Thanks,
Laszlo/GCS
Description: warning is no longer an option for SetTotalBytesLimit()
Just remove the second argument.
Author: Laszlo Boszormenyi (GCS) <[email protected]>
---
Last-Update: 2022-11-05
--- libarcus-5.0.0.orig/src/Socket_p.h
+++ libarcus-5.0.0/src/Socket_p.h
@@ -128,9 +128,6 @@ namespace Arcus
static const int keep_alive_rate = 500; //Number of milliseconds between sending keepalive packets
- // This value determines when protobuf should warn about very large messages.
- static const int message_size_warning = 400 * 1048576;
-
// This value determines when protobuf should error out because the message is too large.
// Due to the way Protobuf is implemented, messages large than 512MiB will cause issues.
static const int message_size_maximum = 500 * 1048576;
@@ -548,7 +545,7 @@ namespace Arcus
google::protobuf::io::ArrayInputStream array(wire_message->data, wire_message->size);
google::protobuf::io::CodedInputStream stream(&array);
- stream.SetTotalBytesLimit(message_size_maximum, message_size_warning);
+ stream.SetTotalBytesLimit(message_size_maximum);
if(!message->ParseFromCodedStream(&stream))
{
error(ErrorCode::ParseFailedError, "Failed to parse message:" + std::string(wire_message->data));
--- End Message ---
--- Begin Message ---
Version: 5.0.0-2
Re: László Böszörményi
> I do plan to start the Protobuf 3.29 transition which is already
> available from experimental. While your package in Sid compiles as
> expected, the experimental version is not. As it's needed for the
> cura-engine package, the version which is in experimental I provide
> you a simple patch.
> Please be prepared to apply it and upload to Sid when the Protobuf
> transition starts.
Already done as part of #1023497.
Christoph
--- End Message ---
