Your message dated Wed, 23 Aug 2023 17:04:18 +0000
with message-id <[email protected]>
and subject line Bug#1041868: fixed in alsa-lib 1.2.9-2
has caused the Debian Bug report #1041868,
regarding Include patch fixing SNDRV_PCM_IOCTL_SW_PARAMS ioctl on
src/pcm/pcm_hw.c
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1041868: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041868
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: alsa-libs
Severity: normal
Version: 1.2.9-1
Tags: patch
Howdy, ALSA team!
I had some unrelated software (src:direwolf) break on me, which turns
out is a bug in ALSA.
Commit 2115cdb4dc314d66e92a9e04413bcedc543da007 (first part of 1.2.9
AFAICT) introduced a change to src/pcm/pcm_hw.c where sw_params is
passed by value rather than as a pointer in the ioctl call. Whoopsies.
This means for users of specific hardware (I am one such person!), ALSA
was returnning bad address (well, ALSA was returning the kernel being
grumpy) which horked writing audio to ALSA.
I took the attached patch from the upstream repo
(commit a5d8af8e4ef02340531092ea388dd1b668182409) and rebuilt alsa-libs.
This fixes the issue that presented with my hardware, and I was able to
transmit normally.
Thanks to Dan Cross for the fix
paultag
--
⢀⣴⠾⠻⢶⣦⠀ Paul Tagliamonte <paultag>
⣾⠁⢠⠒⠀⣿⡁ https://people.debian.org/~paultag | https://pault.ag/
⢿⡄⠘⠷⠚⠋ Debian, the universal operating system.
⠈⠳⣄⠀⠀ 4096R / FEF2 EB20 16E6 A856 B98C E820 2DCD 6B5D E858 ADF3
From a5d8af8e4ef02340531092ea388dd1b668182409 Mon Sep 17 00:00:00 2001
From: Dan Cross <[email protected]>
Date: Wed, 14 Jun 2023 21:09:10 +0000
Subject: [PATCH] pcm: fix minor bug in ioctl
Commit 2115cdb added a new call to the `SNDRV_PCM_IOCTL_SW_PARAMS`
ioctl on line 675 of src/pcm/pcm_hw.c, but passed the `sw_params`
argument by value; this should be passed by pointer.
I ran across this in the context of the direwolf software modem
for amateur radio; debugging details are in
https://groups.io/g/direwolf/message/8286
Fixes #329
Signed-off-by: Dan Cross <[email protected]>
---
src/pcm/pcm_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/pcm/pcm_hw.c b/src/pcm/pcm_hw.c
index b468a071..f488023a 100644
--- a/src/pcm/pcm_hw.c
+++ b/src/pcm/pcm_hw.c
@@ -672,7 +672,7 @@ static int snd_pcm_hw_prepare(snd_pcm_t *pcm)
if (hw->prepare_reset_sw_params) {
snd_pcm_sw_params_current_no_lock(pcm, &sw_params);
- if (ioctl(hw->fd, SNDRV_PCM_IOCTL_SW_PARAMS, sw_params) < 0) {
+ if (ioctl(hw->fd, SNDRV_PCM_IOCTL_SW_PARAMS, &sw_params) < 0) {
err = -errno;
SYSMSG("SNDRV_PCM_IOCTL_SW_PARAMS failed (%i)", err);
return err;
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: alsa-lib
Source-Version: 1.2.9-2
Done: Jordi Mallach <[email protected]>
We believe that the bug you reported is fixed in the latest version of
alsa-lib, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jordi Mallach <[email protected]> (supplier of updated alsa-lib package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 23 Aug 2023 18:24:39 +0200
Source: alsa-lib
Architecture: source
Version: 1.2.9-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ALSA Maintainers <[email protected]>
Changed-By: Jordi Mallach <[email protected]>
Closes: 1041868
Changes:
alsa-lib (1.2.9-2) unstable; urgency=medium
.
* Add upstream patch to fix SNDRV_PCM_IOCTL_SW_PARAMS ioctl. Thanks
to Paul Tagliamonte for the report and Dan Cross for the upstream
fix (closes: #1041868).
Checksums-Sha1:
d2ebdd73f1f29dbdd48748df1f487882e726e1fb 2875 alsa-lib_1.2.9-2.dsc
6b9d8998ec79d17a5e99fe9a176e0b4390341bf3 33196 alsa-lib_1.2.9-2.debian.tar.xz
cec5a092d0a0dc218fee3e0e391eeaaf297178e9 11633 alsa-lib_1.2.9-2_amd64.buildinfo
Checksums-Sha256:
e7487361c63856bd490fdf604bcafa9d1fe5e3cf4e54ac6cc0753343998a3835 2875
alsa-lib_1.2.9-2.dsc
435cb0af049bfa80ffd75193a77e41894162fd5031f8e4ae9a161883b8f538f7 33196
alsa-lib_1.2.9-2.debian.tar.xz
5b22f81c29f332521a243e79a6597c64c08ce1954aeff8974c78e49b8ddd0e71 11633
alsa-lib_1.2.9-2_amd64.buildinfo
Files:
738f83399144bf1d3062496544b66a1d 2875 libs optional alsa-lib_1.2.9-2.dsc
4806926a7ec7fc2086c7ca43b9e61f57 33196 libs optional
alsa-lib_1.2.9-2.debian.tar.xz
ece5d27dd05a3ce99445ec22c9b8e8b1 11633 libs optional
alsa-lib_1.2.9-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE6BdUhsApKYN8KGoWJVAvb8vjywQFAmTmM7kACgkQJVAvb8vj
ywTQzA//SQO3FHBseajQLxRXjc9sz+jFtL1Cc8ox7dK7FGzNlqsMr4p3G5dQf5hi
XOQnwPxtGjOzkefk3+ff9n1UG0WbGw8226s/iLdnWunOOftwBCnaH8uoJTuxzCI+
D0Yx/UOMqIrRUEnMBQ6If4PmOMoX//Rbt6t1n0lzuKQPwxgqKDpf2MGWU0Y9981n
G/3HY/nObr9We+rslxoejBQsYHS8uU0MK1t4tQW4eagEZzGJ9PU55HKHzeNfk8Jj
F/dwNDGCG95yD+gGFVQ4kpIMfxS0as84ek5ATIX/w6rAGqdFgDJQUjtckQXWmcdK
ObXZGjp2Iulk7LqNbJ4eCvrobSWn+5jjBuLkKddA28BdIwjQol+y3ewEYYeZGRi/
fx1kRXXUaM9TXEflyAO5AN4q/XVVOLKessTilEXczEU9WQ5KnI4J0hk3iLCm05qT
T+blRKPyhDmVU7TQpE8bN0+uRYgDjsSwWgx8lN8OKj5ovV164zIVEFFHqaEYtwvp
Rb8kjVUbwuLR/0YluliMxW4RfDzhA6JCb67yaw91xf5SaSAd5rQgbcfu+/SepHCV
AzVTMkPuMNvzGoOAp9koEgk/UcDf/CTdjcl3HmYfbYpdlfim6tSlcjAprLSqZ5tr
3eKbVdyNukSmAYaBBDc2Flhu/GRNIcHB9eQWmnIQCNH3j96/rsA=
=PB5W
-----END PGP SIGNATURE-----
--- End Message ---
