Your message dated Sat, 09 Dec 2023 19:35:44 +0000
with message-id <[email protected]>
and subject line Bug#1037527: fixed in intelrdfpmath 2.0u2-9
has caused the Debian Bug report #1037527,
regarding intelrdfpmath: FTBFS in Ubuntu due to compiler strictness
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1037527: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037527
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: intelrdfpmath
Version: 2.0u2-8
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu mantic ubuntu-patch
Dear maintainers,
The intelrdfpmath package is failing to build on all architectures in Ubuntu
because some test cases are being built with -Werror, and this is currently
stricter on Ubuntu than on Debian:
[...]
make[2]: Entering directory '/<<PKGBUILDDIR>>/TESTS'
x86_64-linux-gnu-gcc -O0 -D__intptr_t_defined -DLINUX -Werror
-DDECIMAL_CALL_BY_REFERENCE=0 -DDECIMAL_GLOBAL_ROUNDING=0
-DDECIMAL_GLOBAL_EXCEPTION_FLAGS=0 -UBID_BIG_ENDIAN -UHPUX_OS -o readtest
readtest.c ../LIBRARY/libbidgcc000.a -lm
readtest.c: In function ‘print_mismatch’:
readtest.c:1397:24: error: ‘ ’ directive writing 1 byte into a region of size
between 0 and 1023 [-Werror=format-overflow=]
1397 | sprintf (line, "%s %s %s %s\n", func, op1, op2, op3);
| ^
readtest.c:1397:3: note: ‘sprintf’ output 5 or more bytes (assuming 3074) into
a destination of size 1024
1397 | sprintf (line, "%s %s %s %s\n", func, op1, op2, op3);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [makefile:126: readtest] Error 1
[...]
(https://launchpad.net/ubuntu/+source/intelrdfpmath/2.0u2-8/+build/26010059)
While not currently a build failure in Debian, we can expect it to become
one with a future compiler update.
Unfortunately, using snprintf() to enforce bounds checking of the target
array doesn't avert this error, because format-truncation is also applied to
the buffer in snprintf(). But the attached patch lets the package build, by
both using snprintf() for more explict safety wrt buffer handling, and
turning off this particular error from gcc.
I've uploaded this to Ubuntu to let the package build there.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru intelrdfpmath-2.0u2/debian/patches/series
intelrdfpmath-2.0u2/debian/patches/series
--- intelrdfpmath-2.0u2/debian/patches/series 2023-02-08 06:20:15.000000000
-0800
+++ intelrdfpmath-2.0u2/debian/patches/series 2023-06-13 10:35:51.000000000
-0700
@@ -3,3 +3,4 @@
abs-declaration.patch
wchar_t.patch
mongo-inteldfp-s390x.patch
+snprintf-not-sprintf.patch
diff -Nru intelrdfpmath-2.0u2/debian/patches/snprintf-not-sprintf.patch
intelrdfpmath-2.0u2/debian/patches/snprintf-not-sprintf.patch
--- intelrdfpmath-2.0u2/debian/patches/snprintf-not-sprintf.patch
1969-12-31 16:00:00.000000000 -0800
+++ intelrdfpmath-2.0u2/debian/patches/snprintf-not-sprintf.patch
2023-06-13 10:39:53.000000000 -0700
@@ -0,0 +1,38 @@
+Description: use snprintf not sprintf to make the compiler happy
+ With the gcc currently in Ubuntu, the package build fails because the
+ compiler can't tell whether this sprintf() will overflow the target.
+ Just use snprintf() to ensure that it can't.
+ .
+ But -Werror=format-truncation triggers *anyway* even on snprintf, so
+ disable this error as well.
+Author: Steve Langasek <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2023683
+Last-Update: 2023-06-13
+Forwarded: no
+
+Index: intelrdfpmath-2.0u2/TESTS/readtest.c
+===================================================================
+--- intelrdfpmath-2.0u2.orig/TESTS/readtest.c
++++ intelrdfpmath-2.0u2/TESTS/readtest.c
+@@ -1394,7 +1394,7 @@
+
+ printf ("// Input operand strings: %s %s %s\n", istr1, istr2, istr3);
+ fail_res++;
+- sprintf (line, "%s %s %s %s\n", func, op1, op2, op3);
++ snprintf (line, 1024, "%s %s %s %s\n", func, op1, op2, op3);
+ printf ("// Ulp error: %e\n", ulp+ulp_add);
+ printf ("// Full input string: %s\n", full_line);
+ printf ("// Input string number: %d\n", line_counter);
+Index: intelrdfpmath-2.0u2/TESTS/makefile
+===================================================================
+--- intelrdfpmath-2.0u2.orig/TESTS/makefile
++++ intelrdfpmath-2.0u2/TESTS/makefile
+@@ -78,7 +78,7 @@
+ ifeq ($(CC),icc)
+ COPT = -Werror -Qoption,cpp,--extended_float_types
+ else
+-COPT = -Werror
++COPT = -Werror -Wno-error=format-truncation
+ endif
+ endif
+
--- End Message ---
--- Begin Message ---
Source: intelrdfpmath
Source-Version: 2.0u2-9
Done: Stephen Kitt <[email protected]>
We believe that the bug you reported is fixed in the latest version of
intelrdfpmath, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated intelrdfpmath package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 09 Dec 2023 20:12:09 +0100
Source: intelrdfpmath
Architecture: source
Version: 2.0u2-9
Distribution: unstable
Urgency: medium
Maintainer: Christian Stalp <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Closes: 1037527 1052604
Changes:
intelrdfpmath (2.0u2-9) unstable; urgency=medium
.
* Disable -Werror in tests. Closes: #1037527.
* Add LoongArch support. Thanks to Meng Sang for the patch! Closes:
#1052604.
* Update Christian’s email address.
Checksums-Sha1:
0b77209543fe99e0a5a53f9e1dc5af31d05a0d3f 2001 intelrdfpmath_2.0u2-9.dsc
6e8288f4434db07fd7359b7a922f8a1dd6ce4611 7324
intelrdfpmath_2.0u2-9.debian.tar.xz
07ccc3fcdc1f0151848186a6a02cfd0f4faa9b26 6400
intelrdfpmath_2.0u2-9_source.buildinfo
Checksums-Sha256:
d039da7b9bc3d3978fe1a8934380eb82113feb6ea5ef97829ebf9b740b4b0175 2001
intelrdfpmath_2.0u2-9.dsc
79f092260e5b083ffdcb7ec0b04217c4a6948055d183fc0ef7f4c3a378ebe54f 7324
intelrdfpmath_2.0u2-9.debian.tar.xz
b4031ae8125380e56bebf205f5f420b561861fe845d6e6928544772f4cc253ce 6400
intelrdfpmath_2.0u2-9_source.buildinfo
Files:
370fdbe800a6f8e534a76be63142046d 2001 libdevel optional
intelrdfpmath_2.0u2-9.dsc
f8a78533a116cf9d97c538714d69f9a3 7324 libdevel optional
intelrdfpmath_2.0u2-9.debian.tar.xz
081be989163659f4ce15798513557719 6400 libdevel optional
intelrdfpmath_2.0u2-9_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmV0vgwACgkQgNMC9Yht
g5yZuA/8CmEYG5DhAosbRNMNKwghDuAFoC8p8uXeLtKsvEhaeuu8ZzznYHhAf9ko
/uuQoRqxIN9njbsbIrG7qHjhUpXq9JSADRx73MyeTpMW659H43UUbzCRD+CpljcU
9yGJqCTY9A5tJ6nEDhZlhZVQoBIM+mgWMFw/sjQMwUL9V7Uk4CBs+HWATjnSa7T2
QwJj33Dn8dlaQ9UiJ3/lb32V2mKipwNhe/fQI++yuXB1/i0qGOUQB2rNNqpm6ASQ
QU/jUR3s02TwnGiDQiTjd9yRx4I0VjXKeh9cyVT/Y69MN9RfzxL9paW4quFDkPHS
jw+chsZFESng92XFQPlAvIWXzJbv9kfO5QMZIKWhA2BvCXpsePSK3cDDMY6EUKck
TtfEckjPV/rJHpQDRJzGU+D+oCBINwqPSPtNvCu3EmYmeo9FUWDXbyXRB7jSdPng
ZWXueKXQGvLYPbJ9Yw97l5xy5tf5B2RcR5y5qt6I+11dQX8TtqhK53zYT/7OHCiU
TO3bRjHHnNhcRadvN4HKGqUCHCLtsDaKw7oirjML2BhTqcbNLZAjtQLfikchRnVA
7GsgXT95OnXcjTuda0Hz9EB+QtrPt6KoCMgYvySQwOUSaUky397MdQdWrcUlj9C0
veseukZldMoQMNBsl5Mu6oDA2sevUW37Eg+WfN1RprJUMagPcCo=
=Jfku
-----END PGP SIGNATURE-----
--- End Message ---
