Your message dated Sat, 23 Dec 2023 18:42:02 +0000
with message-id <[email protected]>
and subject line Bug#1052357: Removed package(s) from unstable
has caused the Debian Bug report #1020614,
regarding openbox-menu: cannot find icons with dots in their name
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1020614: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020614
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: openbox-menu
Version: 0.8.0+hg20161009-3.1
Severity: minor
Tags: patch
Dear fellow developer,
openbox-menu contains a few lines of code to remove file extensions in
icon names found in desktop files. It removes everything after the last
dot, which prevents gtk_icon_theme_lookup_icon() to find an icon if its
name contains a dot, which is the case in more and more applications,
for example nearly all GNOME applications, Remmina, Wireshark or even XTerm.
Moreover, it seems that nowadays gtk_icon_theme_lookup_icon() is
perfectly capable to retrieve icons which contain a file extension.
The provided patch removes the few lines of code which remove file
extensions before the gtk_icon_theme_lookup_icon() query, allowing
openbox-menu to correctly retrieve all icons.
Regards,
--
Raphaël Halimi
Description: Don't remove file extensions in icon names
It seems that nowadays gtk_icon_theme_lookup_icon() is perfectly capable to
retrieve icons which contain a file extension, so removing them is not needed
anymore. Removing everything after the last dot prevented to find icons which
contained a dot in their name, and more packages have such icons for example
nearly all GNOME applications, Remmina, Wireshark or even XTerm.
Author: Raphaël Halimi <[email protected]>
Last-Update: 2022-09-24
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/src/utils.c
+++ b/src/utils.c
@@ -189,7 +189,6 @@
{
GtkIconInfo *icon_info = NULL;
gchar *icon = NULL;
- gchar *tmp_name = NULL;
const gchar *name = menu_cache_item_get_icon (MENU_CACHE_ITEM(item));
@@ -198,16 +197,11 @@
if (g_path_is_absolute (name))
return g_strdup (name);
- /* We remove the file extension as gtk_icon_theme_lookup_icon can't
- * lookup a theme icon for, ie, 'geany.png'. It has to be 'geany'.
- */
- tmp_name = strndup (name, strrchr (name, '.') - name);
#ifdef WITH_SVG
- icon_info = gtk_icon_theme_lookup_icon (icon_theme, tmp_name, 16, GTK_ICON_LOOKUP_GENERIC_FALLBACK);
+ icon_info = gtk_icon_theme_lookup_icon (icon_theme, name, 16, GTK_ICON_LOOKUP_GENERIC_FALLBACK);
#else
- icon_info = gtk_icon_theme_lookup_icon (icon_theme, tmp_name, 16, GTK_ICON_LOOKUP_NO_SVG | GTK_ICON_LOOKUP_GENERIC_FALLBACK);
+ icon_info = gtk_icon_theme_lookup_icon (icon_theme, name, 16, GTK_ICON_LOOKUP_NO_SVG | GTK_ICON_LOOKUP_GENERIC_FALLBACK);
#endif
- g_free (tmp_name);
}
if (!icon_info) /* 2nd fallback */
--- End Message ---
--- Begin Message ---
Version: 0.8.0+hg20161009-3.1+rm
Dear submitter,
as the package openbox-menu has just been removed from the Debian archive
unstable we hereby close the associated bug reports. We are sorry
that we couldn't deal with your issue properly.
For details on the removal, please see https://bugs.debian.org/1052357
The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.
Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.
This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].
Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)
--- End Message ---
