Your message dated Sat, 30 Dec 2023 00:49:00 +0000
with message-id <[email protected]>
and subject line Bug#1021522: fixed in crack 5.0a-13.1
has caused the Debian Bug report #1021522,
regarding crack: reproducible-builds: date in various binaries
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1021522: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021522
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: crack
Severity: normal
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]
The date is embedded in various binaries:
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/crack.html
/usr/lib/Crack/stdlib-cracker
Fri·Nov·10·06:59:40·-12·2023
vs.
Sun·Oct··9·02:42:03·+14·2022
There are two different patches to fix this issue, the first patches the
upstream src/util/Makefile to not embed a date at all, and is the
preferred approach from a reproducible builds perspective.
The second patch uses the SOURCE_DATE_EPOCH environment variable to
specify the date to use in the embedded files, if for some reason these
files require a date in order to function correctly.
According to my local tests, with this patch applied, and a soon-to-be
submitted patch to fix build paths, crack should build reproducibly on
tests.reproducible-builds.org!
Thanks for maintaining crack!
live well,
vagrant
From 14c413afff3bb0bdbcbe5113adfd569d0f496fe0 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <[email protected]>
Date: Mon, 10 Oct 2022 00:10:18 +0000
Subject: [PATCH 2/4] src/util/Makefile: Remove embedded timestamps.
https://reproducible-builds.org/docs/timestamps/
---
src/util/Makefile | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/util/Makefile b/src/util/Makefile
index b2a96c3..f09bb9f 100644
--- a/src/util/Makefile
+++ b/src/util/Makefile
@@ -42,25 +42,21 @@ $(XDIR)/stdlib-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB)
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB)
- date > $@
$(XDIR)/libdes-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../libdes/libdes.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../libdes/libdes.a
- date > $@
$(XDIR)/ufc-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -DINITDES -DFCRYPT -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../ufc-crypt/libufc.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../ufc-crypt/libufc.a
- date > $@
$(XDIR)/gnu-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../crypt/libufc.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../crypt/libufc.a
- date > $@
#------------------------------------------------------------------
--
2.37.2
From eae675adc4369871379c238fd7550d96d79512a2 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <[email protected]>
Date: Mon, 10 Oct 2022 00:12:03 +0000
Subject: [PATCH 4/4] src/util/Makefile: Use SOURCE_DATE_EPOCH to set date.
https://reproducible-builds.org/docs/source-date-epoch/
---
src/util/Makefile | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/util/Makefile b/src/util/Makefile
index b2a96c3..1ea15be 100644
--- a/src/util/Makefile
+++ b/src/util/Makefile
@@ -20,6 +20,8 @@ EXE= $(XDIR)/dawg \
#------------------------------------------------------------------
+DATESTAMP = $(shell LC_ALL=C date --utc --date=@$(SOURCE_DATE_EPOCH))
+
all: $(EXE)
@echo all made in util
@@ -42,25 +44,25 @@ $(XDIR)/stdlib-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB)
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB)
- date > $@
+ echo "$(DATESTAMP)" > $@
$(XDIR)/libdes-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../libdes/libdes.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../libdes/libdes.a
- date > $@
+ echo "$(DATESTAMP)" > $@
$(XDIR)/ufc-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -DINITDES -DFCRYPT -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../ufc-crypt/libufc.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../ufc-crypt/libufc.a
- date > $@
+ echo "$(DATESTAMP)" > $@
$(XDIR)/gnu-cracker: cracker.c $(XLIB)
$(CC) $(CFLAGS) -c elcid.c
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/cracker cracker.c elcid.o $(XLIB) ../crypt/libufc.a
$(CC) $(CFLAGS) $(LDFLAGS) -o $(XDIR)/dictfilt dictfilt.c elcid.o $(XLIB) ../crypt/libufc.a
- date > $@
+ echo "$(DATESTAMP)" > $@
#------------------------------------------------------------------
--
2.37.2
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: crack
Source-Version: 5.0a-13.1
Done: Vagrant Cascadian <[email protected]>
We believe that the bug you reported is fixed in the latest version of
crack, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vagrant Cascadian <[email protected]> (supplier of updated crack
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 19 Dec 2023 15:43:43 -0800
Source: crack
Architecture: source
Version: 5.0a-13.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Vagrant Cascadian <[email protected]>
Closes: 952791 1021521 1021522
Changes:
crack (5.0a-13.1) unstable; urgency=medium
.
* Non-maintainer upload.
.
[ Vagrant Cascadian ]
* debian/Crack.make: Use dpkg-buildflags to set default CFLAGS.
(Closes: #1021521)
* src/util/Makefile: Remove embedded timestamps. (Closes: #1021522)
.
[ Helmut Grohne ]
* Fix FTCBFS: Let dpkg's buildtools.mk seed CC. (Closes: #952791)
Checksums-Sha1:
76908378e168ce7d20d12846e1ac3357edd09023 1583 crack_5.0a-13.1.dsc
dc3160b0836428bcdfe657eed4a8b98a45887ab3 25672 crack_5.0a-13.1.debian.tar.xz
Checksums-Sha256:
a945f1e282f91db6206234daaae9ac78095a5fb2474761d753423bdde64694de 1583
crack_5.0a-13.1.dsc
905d3a2ae099b5b22a10e6049959c5c93e0a31f3148a356dce76f960e3b4cccc 25672
crack_5.0a-13.1.debian.tar.xz
Files:
6cdbb615558ff2a0143d04612ea8b83c 1583 admin optional crack_5.0a-13.1.dsc
08b238cccca4027a85d4fbea9f33884d 25672 admin optional
crack_5.0a-13.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZYIuVSAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqnvzAQCuu3pOdNYwMcEQ
OrwCuJZ/BAqsUo8rkobuyJKRI0cRMAEA8O+zC28yU/VQssHk1hY9rvaZMnl96p6p
HViLVDBoRgw=
=O0ny
-----END PGP SIGNATURE-----
--- End Message ---
