Your message dated Mon, 1 Jan 2024 12:57:31 +0000
with message-id <[email protected]>
and subject line Re: Bug#1028432: debcargo patch to build with clap 4.
has caused the Debian Bug report #1028432,
regarding debcargo patch to build with clap 4.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1028432: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028432
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rust-debcargo
I've attached a patch which makes debcargo build with clap 4, debcargo
builds and it's cargo tests run succesfully, but I haven't actually done any
testing of the command line interface with this patch.
Fabian and I have agreed on irc that it probablly doesn't make sense to
switch debcargo to clap 4 in bookworm. I'm posting this patch here to
preserve it for trixie.
--- debcargo.orig/Cargo.toml
+++ debcargo/Cargo.toml
@@ -39,3 +39,3 @@
[dependencies.clap]
-version = "3"
+version = "4"
features = [
--- debcargo.orig/src/bin/debcargo.rs
+++ debcargo/src/bin/debcargo.rs
@@ -1,3 +1,3 @@
use ansi_term::Colour::Red;
-use clap::{crate_version, AppSettings, Parser};
+use clap::{crate_version, CommandFactory, FromArgMatches, Parser};
@@ -50,3 +50,3 @@
-#[test]
+/*#[test]
fn verify_app() {
@@ -54,11 +54,10 @@
Opt::into_app().debug_assert()
-}
+}*/
fn real_main() -> Result<()> {
- let m = Opt::clap()
+ let m = Opt::command()
.version(crate_version!())
- .global_setting(AppSettings::ColoredHelp)
.get_matches();
use Opt::*;
- match Opt::from_clap(&m) {
+ match Opt::from_arg_matches(&m).unwrap() {
Update => invalidate_crates_io_cache(),
--- End Message ---
--- Begin Message ---
Version: 2.6.1-3
Debian now has 2.6.1 packaged. This might mark this bug donw.
However, the version of src:rust-cargo in Debian (0.66) and used by debcargo
(0.63, relaxed to 0.66 with patch) hasn't switched, so debcargo still has clip 3
in its build graph. 0.67 made the switch. Fabian pushed packaging of 0.70 to
debcargo-conf, but that requires coordination with src:cargo and downstream
crates.
rust-cargo and rust-debcargo have now both been updated to versions that use
clap 4. Closing this bug.
--- End Message ---
