Your message dated Wed, 07 Feb 2024 20:35:09 +0000
with message-id <[email protected]>
and subject line Bug#1063394: fixed in hannah 2.0.1+ds1-0.3
has caused the Debian Bug report #1063394,
regarding hannah FTCBFS: hard codes the build architecture pkg-config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1063394: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063394
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: hannah
Version: 2.0.1+ds1-0.2
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
hannah fails to cross build from source, because the upstream
Makefile.am hard codes the build architecture pkg-config. Using
pkg-config in Makefile.am usually is a bad idea. Rather, such aspects
should be detected at configure time and indeed the configure.ac
performs the necessary detection already. All that is missing is
transferring the detected values from configure.ac to Makefile.am. I'm
attaching a patch for your convenience.
Helmut
--- hannah-2.0.1+ds1.orig/Makefile.am
+++ hannah-2.0.1+ds1/Makefile.am
@@ -11,7 +11,7 @@
# Additional CFLAGS
AM_CPPFLAGS = $(SDL_CFLAGS) -DDATA_INSTALL_DIR=\"$(DATA_INSTALL_DIR)\"
# LIBS comes after the G++ sources, so library files need to go here
-LIBS = $(shell pkg-config --libs sdl2 SDL2_image SDL2_mixer SDL2_ttf)
+LIBS = $(SDL2_image_LIBS) $(SDL2_mixer_LIBS) $(SDL2_ttf_LIBS)
# the create_file_list.sh script generates the below include file listing all files and their output directories
include hannah_files.mk
# Additional files that need to be included in a release
--- hannah-2.0.1+ds1.orig/configure.ac
+++ hannah-2.0.1+ds1/configure.ac
@@ -5,7 +5,10 @@
AC_PROG_CXX
AM_PATH_SDL2([2.0.5])
PKG_CHECK_MODULES([SDL2_image], [SDL2_image])
+AC_SUBST([SDL2_image_LIBS])
PKG_CHECK_MODULES([SDL2_mixer], [SDL2_mixer])
+AC_SUBST([SDL2_mixer_LIBS])
PKG_CHECK_MODULES([SDL2_ttf], [SDL2_ttf])
+AC_SUBST([SDL2_ttf_LIBS])
AC_CONFIG_FILES(Makefile)
AC_OUTPUT
--- End Message ---
--- Begin Message ---
Source: hannah
Source-Version: 2.0.1+ds1-0.3
Done: Alexandre Detiste <[email protected]>
We believe that the bug you reported is fixed in the latest version of
hannah, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alexandre Detiste <[email protected]> (supplier of updated hannah package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 07 Feb 2024 20:48:43 +0100
Source: hannah
Architecture: source
Version: 2.0.1+ds1-0.3
Distribution: unstable
Urgency: medium
Maintainer: Margarita Manterola <[email protected]>
Changed-By: Alexandre Detiste <[email protected]>
Closes: 1044187 1063394
Changes:
hannah (2.0.1+ds1-0.3) unstable; urgency=medium
.
* Non-maintainer upload.
* refresh upstream copyright year as seen inside the game
* allow cross-building (Closes: #1063394)
* clean more (Closes: #1044187)
Checksums-Sha1:
979ba652dab5953715dfa87df64f429e37ccc4cf 2016 hannah_2.0.1+ds1-0.3.dsc
8f0be9912fef5bb956b7d8073da46f789962b342 6308
hannah_2.0.1+ds1-0.3.debian.tar.xz
385e00b928ab7d1ef9be2993f73f331f48f9f26b 14419
hannah_2.0.1+ds1-0.3_source.buildinfo
Checksums-Sha256:
204cf38ddd72c0cdc378d5b280f67fc8fe4e4d630cee0081a799d8f00781df1d 2016
hannah_2.0.1+ds1-0.3.dsc
42480ee186f317c1de1f1254911437db50dcb175d3227d314b09ec6e0dd9c3a0 6308
hannah_2.0.1+ds1-0.3.debian.tar.xz
ec2d72a3e01f89174487477fb461e3a31bc7d8ccff01d0f0e7c127a9c5385e6c 14419
hannah_2.0.1+ds1-0.3_source.buildinfo
Files:
c292bc030f2f9f975190e7969a3d29c6 2016 games optional hannah_2.0.1+ds1-0.3.dsc
93ca20f2381530f3d10eecbb93de2a2d 6308 games optional
hannah_2.0.1+ds1-0.3.debian.tar.xz
61ce343ff945a116bd299c1e5a2cacbb 14419 games optional
hannah_2.0.1+ds1-0.3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmXD3voRHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBoPZQ/+KEm66+FV8QWrRmvr1xa5/PsMmzoqPL/Y
5HRK8GWC/ztu+E0bVGYBQ8mic1iU95wzYsWokwmSzGyggxwHlEw6xM30bC/L+ZOJ
XRpNTnrG8g3i5gShxpqqeQEx0dpULb9SIHHERDBoCLjRvtqE+gpfpRhxLgibKkXE
FjI1UXPGSSmBuK/HpCa0WjbZDWRAfyLMJvVnXAuVrOgUrdatTweDseZLAvGCyxXf
KZUYVBUAHyR7/Z/Qv3G0h+5b1cinHpzp/GkuyhSUGRYdltfHNusfRCC7flIE1Z6S
gfdsrdhc72wtO8u+mP8gzMcVET1GFMLCfSLaXgOYBLs/3OyXnBj0RHoBt3nPu8R2
FT2guJKrk3jm4vomt2vuT+cuY9yWrZPFQB/eV6qE+JwvziaB7P+1VapZz6+tkU4c
Oc3wBHyR43B9PkDmYbv2mbQYD4FmqAr3De8WsMlf4b3LzM7kUcwraCwHqC2FZ+f/
660kTo9lDh7yjbbT8NiKAgVAYdJKNJMvBtxFdO4Sf9rtEMc0VgLlrzQtfBGb/BQM
sykgyApYACWSDAFCBdmSQSMsrpEkjkXZSdEtY1bFuZKeJh6rKU7pC5XFHidc6Bvl
+CxcCymAsLLi07R5q8Nq+4MOuiwlSpV4N09GBEx0qFiyp4rF1P1JgPikTEjiCRTJ
jhHc3LVJ7MQ=
=Gdlc
-----END PGP SIGNATURE-----
--- End Message ---
