Your message dated Fri, 09 Feb 2024 12:34:08 +0000
with message-id <[email protected]>
and subject line Bug#1053343: fixed in e2guardian 5.5.4-1
has caused the Debian Bug report #1053343,
regarding e2guardian: wrong default config file on 32-bit archs, fails to start
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1053343: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053343
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: e2guardian
Version: 5.3.5-4.1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu mantic ubuntu-patch
Dear maintainers,
Attempting to deploy e2guardian on an Ubuntu 20.04 armhf system, I found
that the service was failing to start with a SIGABRT when trying to spawn a
thread. Painfully tracking this down through the code, I discovered that it
defaulted to trying to spawn 500 worker threads.
And the default config file says not to do this on 32-bit archs, because
it's too many.
Considering e2guardian.conf is generated at build-time ANYWAY, there's no
good reason not to have the default httpworkers value set to something
appropriate for the architecture the package is built on.
Please see the attached patch.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru e2guardian-5.3.5/debian/patches/32-bit-correct-worker-count.patch
e2guardian-5.3.5/debian/patches/32-bit-correct-worker-count.patch
--- e2guardian-5.3.5/debian/patches/32-bit-correct-worker-count.patch
1969-12-31 16:00:00.000000000 -0800
+++ e2guardian-5.3.5/debian/patches/32-bit-correct-worker-count.patch
2023-10-02 00:12:39.000000000 -0700
@@ -0,0 +1,44 @@
+Description: automatically set correct worker count on 32-bit archs
+ The upstream e2guardian.conf has a message telling users they need to
+ adjust the default number of http workers on 32-bit systems. Instead
+ we should just do this automatically.
+ .
+ Ideally this would be done at runtime by the program itself, and the
+ default value could simply be commented out.
+Author: Steve Langasek <[email protected]>
+Forwarded: no
+Last-Update: 2023-10-02
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2037958
+
+Index: e2guardian/configs/e2guardian.conf.in
+===================================================================
+--- e2guardian.orig/configs/e2guardian.conf.in
++++ e2guardian/configs/e2guardian.conf.in
+@@ -577,7 +577,7 @@
+ # On 32-bit systems reduce this to 300 to avoid exceeding the <4GB
+ # virtual memory limit and on Linux decrease the thread stack size from
+ # 10MB to 2MB (ulimit -s 2048)
+-httpworkers = 500
++httpworkers = @httpworkers@
+
+ # Process options
+ # (Change these only if you really know what you are doing).
+Index: e2guardian/configure.ac
+===================================================================
+--- e2guardian.orig/configure.ac
++++ e2guardian/configure.ac
+@@ -675,6 +675,14 @@
+ AC_FINALIZE_VAR(DGCONFFILE,"${dgsysconfdir}/${PACKAGE_NAME}.conf")
+ AC_SUBST(DGCONFFILE)
+
++AC_CHECK_SIZEOF([void *])
++if test $ac_cv_sizeof_void_p = 8; then
++ httpworkers=500
++else
++ httpworkers=300
++fi
++AC_SUBST(httpworkers, "$httpworkers")
++
+ AC_CONFIG_FILES([Makefile
+ data/Makefile
+ data/languages/Makefile
diff -Nru e2guardian-5.3.5/debian/patches/series
e2guardian-5.3.5/debian/patches/series
--- e2guardian-5.3.5/debian/patches/series 2023-08-30 01:40:56.000000000
-0700
+++ e2guardian-5.3.5/debian/patches/series 2023-10-01 23:58:06.000000000
-0700
@@ -5,3 +5,4 @@
0001_CVE-2021-44273_fix-hostname-validation-in-certificates.patch
0002_uint32-ListContainer.cpp.patch
0003_uint32-ListContainer.hpp.patch
+32-bit-correct-worker-count.patch
--- End Message ---
--- Begin Message ---
Source: e2guardian
Source-Version: 5.5.4-1
Done: Mike Gabriel <[email protected]>
We believe that the bug you reported is fixed in the latest version of
e2guardian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <[email protected]> (supplier of updated e2guardian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 09 Feb 2024 12:59:02 +0100
Source: e2guardian
Architecture: source
Version: 5.5.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Edu Packaging Team
<[email protected]>
Changed-By: Mike Gabriel <[email protected]>
Closes: 1053343
Changes:
e2guardian (5.5.4-1) unstable; urgency=medium
.
* New upstream release.
* debian/patches:
+ Add 1003_pcre2.patch. Build against pcre2 rather than deprecated pcre
library.
+ Drop patches applied upstream.
+ Update 1001_spelling-fixes.patch and re-submit as upstream PR against
v5.5 branch.
+ Rebase 1002_fix-maxcontentramcachescansize.patch against v5.5 and re-
submit upstream as regression fix. (Shipped in v5.4, but not v5.5).
+ Cherry-pick 0001_possible-fix-for-794.patch from upstream. Detect
incomplete headers and bail out.
+ Add 1004_32-bit-correct-worker-count.patch. Reduce httpworkers count to
300 on 32bit architectures. Thanks to Steve Langasek for providing the
idea and a patch. (Closes: #1053343).
* debian/rules:
+ Add dh_clean override and allow rebuilding the package.
* debian/e2guardian.examples:
+ Drop contrib/monitor_helper_sample. File not available in upstream
sources
anymore.
* debian/control:
+ Add to B-D: libpcre2-dev.
+ In B-D, move from pkg-config to pkgconf.
* debian/copyright:
+ Update auto-generated copyright.in file.
+ Update copyright attributions, rework entire file.
Checksums-Sha1:
268198aaae738eefafe5a48ddeced66bc4fc891c 2142 e2guardian_5.5.4-1.dsc
19eddd1e4391ec056f2d5a69a4ad9a624d144b88 2146465 e2guardian_5.5.4.orig.tar.gz
4d91ff80721eb69c91c932bc8a597ffd99b44e15 15248 e2guardian_5.5.4-1.debian.tar.xz
75ef10807430942af78a787dedc223439caae786 7107
e2guardian_5.5.4-1_source.buildinfo
Checksums-Sha256:
3f7905310e1d051f4550f068040452b28c521dfbaf829ce000c9711738d6e79c 2142
e2guardian_5.5.4-1.dsc
8bc8d1cb1482f40cac0bda5be27f9a8ee504260db8930a0afbb8cd998e1c374a 2146465
e2guardian_5.5.4.orig.tar.gz
093cb124a5ae012778762fc6d0ee7c18c07d128a604045874ea416b25f1fcbe2 15248
e2guardian_5.5.4-1.debian.tar.xz
b35050a647c9795bffa08dedbfe5885af52b4029e106580b8203d7f2beb09ba8 7107
e2guardian_5.5.4-1_source.buildinfo
Files:
546db23ec7b4ab595bce03be5642cf6c 2142 web optional e2guardian_5.5.4-1.dsc
97b66cc13d4be6965ceb5b634394c41d 2146465 web optional
e2guardian_5.5.4.orig.tar.gz
f5977f60d8a1f64bebb8d4a66fcea837 15248 web optional
e2guardian_5.5.4-1.debian.tar.xz
b05fe17ed0cb92d225c936b11de559a6 7107 web optional
e2guardian_5.5.4-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmXGGP0VHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxkh0P/RJ22dgdrKFSgp8//l5M9H0UN/13
6Eb3rSRWY439wI+f948XHWfZCWmZL4E4mHpYyMpNWBtcwjqf/DGZmUiHzkfQ+z2O
FJgoy3ecwxebP0HZ78KuJszyMs7lIOKwBzcPxNU87U6AOa7VRqiPsI7pI0e+koHJ
SHjXgz5fxCZtoueX3cmJWIwxI24GV3AhlQFYG5EWShscUPnqQ+NR6ED7alG1aV7j
aAKggSBqr3mubkvkkZuvYNIypNeWPQi5hwM1JsJvE2scsdRhWsitR2eFS+7k6aGs
800ZQFumEH770d/GAcaDxg6G8xp/O342edDNS9riU6fbt21yCDV8MQnng9Ve/2bx
c7fdIXaGSfnxJ+cuRFaO4hFCXJPWC6xQZp6Z71f8Yh5g+/z4IST3lodjhgRXZmOj
c4d0OpCCgRx+RIV51aGv0AM7uda+DPGVrN+jhc2kbvf/9s1A/jTmVpZVYdMUNiwF
TtST9hAaYHSBIU5BthWZ5+YmcSpZOtjrzP3OnLdsatK+dFaOaVVcMwrc9WXIlGdo
EbzXT/GW6u2KFJG1NComefa3VWMtxL9wD+R3jbshE0EEhwcjt+ItSINARVa5GUor
iAnl3u4eCY6A67JfXl0JXj5Ed3/cGntyQXfKq6CFHG7RkvjDGTS/gG4KAF6lKfig
ZLBBjot4qv6s5rxs
=Qgn2
-----END PGP SIGNATURE-----
--- End Message ---
