Your message dated Mon, 19 Feb 2024 17:16:34 +0100
with message-id 
<caknhny-ccjm+s+cffxcawqrmcclkok1gcwhwd3ogido9ocz...@mail.gmail.com>
and subject line Re: Bug#1018795: dh-dlang: support for mapping dpkg-buildflags 
for ldc but it's not used
has caused the Debian Bug report #1018795,
regarding dh-dlang: support for mapping dpkg-buildflags for ldc but it's not 
used
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1018795: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018795
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-dlang
Version: 0.6.5
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu kinetic ubuntu-patch

Hi Matthias,

I noticed in Ubuntu when trying to rebuild most packages against ldc 1.30.0
that they were now failing to build with current dh-dlang, because including
/usr/share/dh-dlang/dlang-flags.mk caused dpkg-buildflags' LDFLAGS to be
exported and these flags are not understood by ldc (specifically:
-Wl,-Bsymbolic-functions and -Wl,-z,relro on Ubuntu).  This can be seen in
Debian in the failed build of gir-to-d:

[...]
../meson.build:1:0: ERROR: Unable to detect linker for compiler `ldc2 
-L=--version /tmp/tmpsh_a2h39.d -Wl,-z,relro -O -g -release -wi --allinst`
stdout: 
stderr: ldc2: Unknown command line argument '-Wl,-z,relro'.  Try: 'ldc2 --help'
ldc2: Did you mean '--icp-lto'?
[...]

  
(https://buildd.debian.org/status/fetch.php?pkg=gir-to-d&arch=amd64&ver=0.22.0-3%2Bb1&stamp=1661202072&raw=0)

Paradoxically, there is support in dh-dlang for mapping these flags for ldc,
but this support is not included automatically in dlang-flags.mk.

I've applied the attached patch in Ubuntu, which fixes the build problem.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
[email protected]                                     [email protected]
diff -Nru dh-dlang-0.6.5build2/dlang-flags.mk 
dh-dlang-0.6.5ubuntu1/dlang-flags.mk
--- dh-dlang-0.6.5build2/dlang-flags.mk 2019-09-29 12:14:32.000000000 -0700
+++ dh-dlang-0.6.5ubuntu1/dlang-flags.mk        2022-08-30 10:09:35.000000000 
-0700
@@ -34,5 +34,8 @@
         endif
     endif
 endif
+
+include /usr/share/dh-dlang/ldc-transform-ldflags.mk
+
 export DFLAGS
 export DC

--- End Message ---
--- Begin Message ---
Am Mo., 19. Feb. 2024 um 17:09 Uhr schrieb Jeremy BĂ­cha
<[email protected]>:
>
> The meson bug https://bugs.debian.org/1017087 has been marked done for
> a while. Can we close this bug too?

Yes, I overlooked this! This was fixed in Meson and is working fine
for years now :-)

Best,
    Matthias

-- 
I welcome VSRE emails. See http://vsre.info/

--- End Message ---

Reply via email to