Your message dated Wed, 06 Mar 2024 20:37:13 +0000
with message-id <[email protected]>
and subject line Bug#1064907: fixed in firebird3.0 3.0.11.33703.ds4-3
has caused the Debian Bug report #1064907,
regarding firebird3.0: overrides CXXFLAGS when building on arm64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1064907: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064907
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: firebird3.0
Version: 3.0.11.33703.ds4-2
Tags: patch
User: [email protected]
Usertags: pac-bti
Dear Maintainer,
Whilst trying to figure out why a rebuild of firebird3.0 on arm64 does
not fully enable BTI [1] I have noticed that there is an issue with the
way the build process uses CXXFLAGS on arm64.
CFLAGS seems to be respected, and all hardening flags such as
-fstack-clash-protection and -mbranch-protection=standard are there:
cc -c -ggdb -fPIC -MMD -MP -W -Wall -Wno-unused-parameter -g
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security
-mbranch-protection=standard -fno-strict-aliasing -O3 -Wdate-time
-D_FORTIFY_SOURCE=2 src/tests/test1/CTest.c -o
/<<PKGBUILDDIR>>/temp/Release/cloop/release/tests/test1/CTest.o
The same cannot be said about CXXFLAGS, no hardening flag is in use:
g++ -c -ggdb -fPIC -MMD -MP -W -Wall -Wno-unused-parameter -std=gnu++03
-Wdate-time -D_FORTIFY_SOURCE=2 -O3 src/cloop/Expr.cpp -o
/<<PKGBUILDDIR>>/temp/Release/cloop/release/cloop/Expr.o
To fix this, honour-buildflags.patch needs to be updated to ensure
CXXFLAGS is not overridden in prefix.linux_arm64. See attached patch.
diff -Nru firebird3.0-3.0.11.33703.ds4/debian/changelog firebird3.0-3.0.11.33703.ds4/debian/changelog
--- firebird3.0-3.0.11.33703.ds4/debian/changelog 2023-09-26 12:25:06.000000000 +0200
+++ firebird3.0-3.0.11.33703.ds4/debian/changelog 2024-02-27 16:31:04.000000000 +0100
@@ -1,3 +1,10 @@
+firebird3.0 (3.0.11.33703.ds4-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Do not override CXXFLAGS on arm64. (Closes: #-1)
+
+ -- Emanuele Rocca <[email protected]> Tue, 27 Feb 2024 16:31:04 +0100
+
firebird3.0 (3.0.11.33703.ds4-2) unstable; urgency=medium
* Bump policy-compliance version to 4.6.2 (no changes needed)
diff -Nru firebird3.0-3.0.11.33703.ds4/debian/patches/out/honour-buildflags.patch firebird3.0-3.0.11.33703.ds4/debian/patches/out/honour-buildflags.patch
--- firebird3.0-3.0.11.33703.ds4/debian/patches/out/honour-buildflags.patch 2023-09-26 12:10:03.000000000 +0200
+++ firebird3.0-3.0.11.33703.ds4/debian/patches/out/honour-buildflags.patch 2024-02-27 16:31:04.000000000 +0100
@@ -8,8 +8,10 @@
linking.
Author: Damyan Ivanov <[email protected]>
---- a/builds/posix/Makefile.in
-+++ b/builds/posix/Makefile.in
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/Makefile.in
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/Makefile.in
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/Makefile.in
@@ -641,7 +641,7 @@ MAKE_HEADER_Src = $(addprefix $(SRC_ROOT
MAKE_HEADER_Bin = ./makeHeader
@@ -19,8 +21,10 @@
$(CP) $^ .
$(MAKE_HEADER_Bin) <ibase.h >$@
$(RM) -f ibase.h
---- a/extern/btyacc/Makefile
-+++ b/extern/btyacc/Makefile
+Index: firebird3.0-3.0.11.33703.ds4/extern/btyacc/Makefile
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/extern/btyacc/Makefile
++++ firebird3.0-3.0.11.33703.ds4/extern/btyacc/Makefile
@@ -42,7 +42,7 @@ OTHERS = README README.BYACC \
all: $(PROGRAM)
@@ -30,8 +34,10 @@
clean:; rm -f $(OBJS)
---- a/builds/posix/make.defaults
-+++ b/builds/posix/make.defaults
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/make.defaults
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/make.defaults
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/make.defaults
@@ -166,8 +166,8 @@ LD = @CXX@
LIB_LINK = $(CXX) $(GLOB_OPTIONS) $(CXXFLAGS)
@@ -43,8 +49,10 @@
LINK_LIBS = @LIBS@
STATICLINK_LIBS = @LIBS@
---- a/builds/posix/prefix.linux
-+++ b/builds/posix/prefix.linux
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/prefix.linux
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux
@@ -19,7 +19,7 @@
# 2 Oct 2002, Nickolay Samofatov - Major cleanup
@@ -54,8 +62,10 @@
OPTIMIZE_FLAGS=-O3 -march=i586 -mtune=i686 -fno-omit-frame-pointer
WARN_FLAGS=-Wall -Wno-switch -Wno-parentheses -Wno-unknown-pragmas -Wno-unused-variable -Wno-narrowing
---- a/builds/posix/prefix.linux_amd64
-+++ b/builds/posix/prefix.linux_amd64
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_amd64
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/prefix.linux_amd64
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_amd64
@@ -19,7 +19,7 @@
# 2 Oct 2002, Nickolay Samofatov - Major cleanup
@@ -65,8 +75,10 @@
OPTIMIZE_FLAGS=-O3 -fno-omit-frame-pointer
WARN_FLAGS=-Wall -Wno-switch -Wno-parentheses -Wno-unknown-pragmas -Wno-unused-variable -Wno-invalid-offsetof -Wno-narrowing -Wno-unused-local-typedefs -Wno-class-memaccess
---- a/builds/posix/prefix.linux_generic
-+++ b/builds/posix/prefix.linux_generic
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_generic
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/prefix.linux_generic
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_generic
@@ -19,7 +19,7 @@
# 2 Oct 2002, Nickolay Samofatov - Major cleanup
@@ -76,3 +88,16 @@
PROD_FLAGS=-ggdb -O3 $(COMMON_FLAGS)
DEV_FLAGS=-ggdb -p -Wall -Wno-switch $(COMMON_FLAGS) -Wno-non-virtual-dtor
+Index: firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_arm64
+===================================================================
+--- firebird3.0-3.0.11.33703.ds4.orig/builds/posix/prefix.linux_arm64
++++ firebird3.0-3.0.11.33703.ds4/builds/posix/prefix.linux_arm64
+@@ -22,7 +22,7 @@
+ #DEV_FLAGS=-ggdb -DLINUX -DARM64 -pipe -p -MMD -fPIC -Wall -fsigned-char -fmessage-length=0 -Wno-non-virtual-dtor -DFB_SEND_FLAGS=MSG_NO
+
+ COMMON_FLAGS=-ggdb -DFB_SEND_FLAGS=MSG_NOSIGNAL -DLINUX -DARM64 -pipe -p -MMD -fPIC -fmessage-length=0 -fno-delete-null-pointer-checks -fsigned-char
+-CXXFLAGS=-std=gnu++03
++CXXFLAGS+=-std=gnu++03
+ OPTIMIZE_FLAGS=-O3 -fno-omit-frame-pointer
+ WARN_FLAGS=-Wall -Wno-switch -Wno-parentheses -Wno-unknown-pragmas -Wno-unused-variable -Wno-invalid-offsetof -Wno-narrowing -Wno-unused-local-typedefs -Wno-non-virtual-dtor
+
--- End Message ---
--- Begin Message ---
Source: firebird3.0
Source-Version: 3.0.11.33703.ds4-3
Done: Damyan Ivanov <[email protected]>
We believe that the bug you reported is fixed in the latest version of
firebird3.0, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Damyan Ivanov <[email protected]> (supplier of updated firebird3.0 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 05 Mar 2024 14:04:53 +0000
Source: firebird3.0
Architecture: source
Version: 3.0.11.33703.ds4-3
Distribution: unstable
Urgency: medium
Maintainer: Damyan Ivanov <[email protected]>
Changed-By: Damyan Ivanov <[email protected]>
Closes: 1064907
Changes:
firebird3.0 (3.0.11.33703.ds4-3) unstable; urgency=medium
.
* honour CXXFLAGS on arm64 (Closes: #1064907)
Checksums-Sha1:
9d2b3f90e275cde17be72ca508fe0fbe9a1f279f 2761
firebird3.0_3.0.11.33703.ds4-3.dsc
830865a3d70a77135e9967c4f6a51678cccc768a 102292
firebird3.0_3.0.11.33703.ds4-3.debian.tar.xz
Checksums-Sha256:
283aae2bd2646483210621a915d831b1eea15b5c81aa7dd0f33236271556c692 2761
firebird3.0_3.0.11.33703.ds4-3.dsc
855c5d36e64d6970edbf5e1a9d261401153038a7b617aed77f690bf64cf1c71d 102292
firebird3.0_3.0.11.33703.ds4-3.debian.tar.xz
Files:
3c5427828726f58d15ab0c889d4a1c6a 2761 database optional
firebird3.0_3.0.11.33703.ds4-3.dsc
2e92bbb11efb8108faeb00f788a461e0 102292 database optional
firebird3.0_3.0.11.33703.ds4-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEErqDETssFbpNjDZ0z276dTZnSoAQFAmXozJIACgkQ276dTZnS
oAT+vRAApEkyxRUZHe4UsIgIqwRBR5l9W5flxZZyPWK+forp1Ix2ex2utIUrNemb
ZMAqpfOi759bVEiGe94TxwiCpP+LBH9+V0y8F52JBXxsz76nSk8z6CclHG7jB7V0
WjYAk0xid/DpQYA2CHD2fUhU8zumzrH3meKUYCDLaEmLEnBzKSbAe22lWM6iFalq
zcuWVuETrYNlkW0L2TP9Lj4O4QT4EGvj705CwS1YXe1sIA+yhWXmdd+tBwAbL2Z6
+ZBDjDC1tqFzr4M6TJeBDg4lmQHUxhrN3lGa1J1w8F6Idpr8yKK84gRKg59yXOJ7
nqLiuKBJz/AcM/V8lxGCWeDRGBQt+aN+JiGVX6+pnPWxJUvHsL+FYTf1zNfJaAml
MD2yIO4U0cITHfKwNHnY87H1K5NZrwEL0745T5D1eDSRIE68d2tx/2n4FZynfJXa
wP+BUaSZjkgKyw+snxi4mT4RLE3WtgdbSvLRJRHKXJqxHGPWzFc7CawlwOznzZJD
woJg1Jr4fQWSCg1MdR7uaofGr5PvQGdbOVoQjgN2kpqWl7QKK37/+h0UIQwEP4UN
RxU2ieGIXclI3rAGsC0xNEzNv3a8yqKl1aBIEaagXn6d9bD0r8uYjhLDAbFBpeK0
Sy2DuJk3jY9Mncdxcs1YBY8D5K6zBd9w0fdO4dKXb8I3ejoWnNw=
=Fm7r
-----END PGP SIGNATURE-----
pgpvQdjdosWeC.pgp
Description: PGP signature
--- End Message ---
