Your message dated Thu, 18 Apr 2024 08:39:13 +0000
with message-id <[email protected]>
and subject line Bug#1058835: fixed in openrazer 3.8.0+dfsg-1
has caused the Debian Bug report #1058835,
regarding openrazer: use udev.pc to place udev rules
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1058835: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058835
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: openrazer
Version: 3.7.0+dfsg-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: dep17m2

Dear Maintainer,

your package installs files related to udev, into /lib. These
files need to be moved to /usr/lib as part of Debian's usr-merge
effort [1].

Attached you will find a patch using udev.pc to place the udev files
(using pkg-config). This works today in unstable and also for
bookworm, and is safe to do now.
Once udev.pc in unstable points to /usr/lib, your package will
benefit automatically after a binNMU or any other upload.

If during the trixie cycle your package will undergo structural
changes or any other file moves, please see the wiki and upload
to experimental first when these changes are done.

Later during the trixie cycle I expect this bug class to raise in
priority.

Thank you for considering,
Chris

[1] https://wiki.debian.org/UsrMerge
diff -Nru openrazer-3.7.0+dfsg/debian/changelog openrazer-3.7.0+dfsg/debian/changelog
--- openrazer-3.7.0+dfsg/debian/changelog	2023-11-24 15:47:09.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/changelog	2023-12-16 23:55:45.000000000 +0100
@@ -1,3 +1,10 @@
+openrazer (3.7.0+dfsg-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use udev.pc to place udev files. (Closes: #-1)
+
+ -- Chris Hofstaedtler <[email protected]>  Sat, 16 Dec 2023 23:55:45 +0100
+
 openrazer (3.7.0+dfsg-1) unstable; urgency=medium
 
   * New upstream version 3.7.0+dfsg
diff -Nru openrazer-3.7.0+dfsg/debian/control openrazer-3.7.0+dfsg/debian/control
--- openrazer-3.7.0+dfsg/debian/control	2023-11-24 15:47:09.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/control	2023-12-16 23:55:45.000000000 +0100
@@ -5,8 +5,10 @@
 Build-Depends: debhelper-compat (= 13),
                dh-python,
                dh-sequence-dkms,
+               pkgconf,
                python3,
-               python3-setuptools
+               python3-setuptools,
+               systemd-dev,
 Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/debian/openrazer
 Vcs-Git: https://salsa.debian.org/debian/openrazer.git
diff -Nru openrazer-3.7.0+dfsg/debian/openrazer-driver-dkms.install openrazer-3.7.0+dfsg/debian/openrazer-driver-dkms.install
--- openrazer-3.7.0+dfsg/debian/openrazer-driver-dkms.install	2023-11-24 15:47:09.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/openrazer-driver-dkms.install	2023-12-16 23:55:17.000000000 +0100
@@ -1,3 +1,3 @@
-lib/udev/
+${env:deb_udevdir}/
 usr/src/
 usr/share/metainfo/io.github.openrazer.openrazer.metainfo.xml
diff -Nru openrazer-3.7.0+dfsg/debian/patches/series openrazer-3.7.0+dfsg/debian/patches/series
--- openrazer-3.7.0+dfsg/debian/patches/series	2023-11-24 15:47:09.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/patches/series	2023-12-16 23:52:17.000000000 +0100
@@ -1 +1,2 @@
 skip-without-CONFIG_USB.patch
+udevdir.patch
diff -Nru openrazer-3.7.0+dfsg/debian/patches/udevdir.patch openrazer-3.7.0+dfsg/debian/patches/udevdir.patch
--- openrazer-3.7.0+dfsg/debian/patches/udevdir.patch	1970-01-01 01:00:00.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/patches/udevdir.patch	2023-12-16 23:55:29.000000000 +0100
@@ -0,0 +1,31 @@
+Align udev variable in Makefile with udev.pc, and how this is typically done
+using pkg-config.
+
+Probably suitable for upstream.
+
+Index: openrazer-3.7.0+dfsg/Makefile
+===================================================================
+--- openrazer-3.7.0+dfsg.orig/Makefile
++++ openrazer-3.7.0+dfsg/Makefile
+@@ -12,8 +12,8 @@
+ 
+ # PREFIX is used to prefix where the files will be installed under DESTDIR
+ PREFIX?=/usr
+-# UDEV_PREFIX is specifically a prefix for udev files
+-UDEV_PREFIX?=$(PREFIX)
++# UDEVDIR is specifically a prefix for udev files
++UDEVDIR?=$(shell pkg-config --variable=udevdir udev)
+ # DESTDIR is used to install into a different root directory
+ DESTDIR?=/
+ # Specify the kernel directory to use
+@@ -108,8 +108,8 @@ remove_dkms:
+ udev_install:
+ 	@echo -e "\n::\033[34m Installing OpenRazer udev rules\033[0m"
+ 	@echo "====================================================="
+-	install -m 644 -v -D install_files/udev/99-razer.rules $(DESTDIR)$(UDEV_PREFIX)/lib/udev/rules.d/99-razer.rules
+-	install -m 755 -v -D install_files/udev/razer_mount $(DESTDIR)$(UDEV_PREFIX)/lib/udev/razer_mount
++	install -m 644 -v -D install_files/udev/99-razer.rules $(DESTDIR)$(UDEVDIR)/rules.d/99-razer.rules
++	install -m 755 -v -D install_files/udev/razer_mount $(DESTDIR)$(UDEVDIR)/razer_mount
+ 
+ appstream_install:
+ 	@echo -e "\n::\033[34m Installing OpenRazer AppStream metadata\033[0m"
diff -Nru openrazer-3.7.0+dfsg/debian/rules openrazer-3.7.0+dfsg/debian/rules
--- openrazer-3.7.0+dfsg/debian/rules	2023-11-24 15:47:09.000000000 +0100
+++ openrazer-3.7.0+dfsg/debian/rules	2023-12-16 23:55:03.000000000 +0100
@@ -1,4 +1,5 @@
 #!/usr/bin/make -f
+export deb_udevdir = $(shell pkg-config --variable=udevdir udev | sed s,^/,,)
 
 %:
 	dh $@ --with python3
@@ -14,7 +15,7 @@
 override_dh_auto_install:
 	$(MAKE) ubuntu_install install-systemd \
 	     DESTDIR=$(CURDIR)/debian/tmp \
-	     UDEV_PREFIX="" \
+	     UDEVDIR=/$(deb_udevdir) \
 	     $(NULL)
 
 override_dh_dkms:

--- End Message ---
--- Begin Message ---
Source: openrazer
Source-Version: 3.8.0+dfsg-1
Done: Dylan Aïssi <[email protected]>

We believe that the bug you reported is fixed in the latest version of
openrazer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <[email protected]> (supplier of updated openrazer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 18 Apr 2024 09:56:34 +0200
Source: openrazer
Architecture: source
Version: 3.8.0+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Dylan Aïssi <[email protected]>
Changed-By: Dylan Aïssi <[email protected]>
Closes: 1058835
Changes:
 openrazer (3.8.0+dfsg-1) unstable; urgency=medium
 .
   [ Dylan Aïssi ]
   * New upstream version 3.8.0+dfsg
   * Standards-Version: 4.7.0 (no changes required)
 .
   [ Chris Hofstaedtler ]
   * Use udev.pc to place udev files. (Closes: #1058835)
Checksums-Sha1:
 2341af72c3a6632d701a5d2866f29d431c22f0b0 2246 openrazer_3.8.0+dfsg-1.dsc
 81a39b03fd27a3bdfbf1526e129d0a196a0ca5f7 176928 
openrazer_3.8.0+dfsg.orig.tar.xz
 0c06845aed016047c7c8e9028ff927fdfcb1c570 11648 
openrazer_3.8.0+dfsg-1.debian.tar.xz
 e96ec434d42153f4d63767040a457aa551d16ca7 8090 
openrazer_3.8.0+dfsg-1_amd64.buildinfo
Checksums-Sha256:
 323775b2bc7130aab9a2648286f9e7af40d48a2f817cff9300b7e87249efa3f4 2246 
openrazer_3.8.0+dfsg-1.dsc
 8a7feead92f6bc286627bf91ce5aec28e25684a134c4ad0b566f009a585f673d 176928 
openrazer_3.8.0+dfsg.orig.tar.xz
 3983de8019bd9d1a18ed9624730f1b0454985d46f8f901e7941948b34a218208 11648 
openrazer_3.8.0+dfsg-1.debian.tar.xz
 25a129f9170f0528a2a8b861e5340a8ecdb5e5c58ca82ba2cb65677349e07b99 8090 
openrazer_3.8.0+dfsg-1_amd64.buildinfo
Files:
 0e91f48522d12d4828bb4ee1fdee5a3e 2246 misc optional openrazer_3.8.0+dfsg-1.dsc
 5a16751ac1c033a409b786b6c3b52ee4 176928 misc optional 
openrazer_3.8.0+dfsg.orig.tar.xz
 1261df192b354e0c9f81d1a92eef0b29 11648 misc optional 
openrazer_3.8.0+dfsg-1.debian.tar.xz
 a92d3869c1e9735b3491d2d0ec40779c 8090 misc optional 
openrazer_3.8.0+dfsg-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmYg1CoACgkQYS7xYT4F
D1Q0Tg/+L/DgF5mUv3+tnqnWSgW5lUoc0yY0YxbuCw+qX6+8yLWTeRAAi+Sx7cVJ
S73m+aoxgrBsa+e3hae3C7VpcPBFxadJw7aak4CJw+4nJ9Y/ct23VtDx429XQMgC
ysNYWAYhuNe39mI9aSDMk2dEf6PaOh9Guhe1BIpIiDkDgUbekeSG58HzWG9trxYl
PN2BuSufNGIrV8LL1WtTnoRnBMq6UMCO/psR3SB/qVrjIdm2rHZ1XtvVRhrun92d
3wj85v1OKki2GTFVTX+wJwe4Z1ZNOKEhPR3Epj9355wl1vwGj+gFZDSJ2ob//XOB
EzSh7loBVJq30lPdCWld0ZTrQAI7y/K1QxgUJyUyWGXTZ+KV6ZbRMj2f3f9r3ZSb
hf4uxoVJGyUWPkmaWAEa9gGXgKifFuOrWvCM7cm18HrwpDPRzQ48M86nsw79natk
mgxKcT5+UJ8luJZasuVtTi8fixJussy/iCPIqcIls7QIDP6ehuMJGZ7PXQlHRz5r
G4bJjfNvKto7mlXlrknbPki7d5hKk2E9BUj7r7eNYSDPm3zGw99Xvvo8SUDDfGDd
S7HU2D6Mb8kXhO4pMF8XdIkn9G4Y9KhtRtaGRjao9rvUTpvnf0SzRx0p9D9NfKrI
p6NP9vyUOGN33/J1zq84T3+Eut9jJV2DmGVpJBpoiVhVC0lbekA=
=cf1m
-----END PGP SIGNATURE-----

Attachment: pgparn0jBtFxb.pgp
Description: PGP signature


--- End Message ---

Reply via email to