Your message dated Sat, 08 Jun 2024 10:53:30 +0000
with message-id <[email protected]>
and subject line Bug#1072039: fixed in xmake 2.9.2+ds-2
has caused the Debian Bug report #1072039,
regarding xmake build bug means it no longer uses cjson
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1072039: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072039
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xmake
Version: 2.9.1+ds-1
Severity: normal
X-Debbugs-Cc: [email protected]
Dear Maintainer,
xmake upstream ships with a vendored lua-cjson, which Debian removes as parts of
debian/patches/convert_local_source_to_external_dependencies.patch and the
commit dd807d0489aa3d0f2b584e7b379cdb62e82967f8 on 2023 Aug 24.
Unfortunately, that commit removed the only source of definition for the C
preprocessor symbol XM_CONFIG_API_HAVE_LUA_CJSON, and the patch would have
unhooked it anyway. This symbol is still being tested for in
core/src/xmake/engine.c . As a result, the built xmake binary does not end up
using lua-cjson, but rather falls back to its built-in core/base/json.lua
parser.
As a consequence, for example, xmake loses lua-cjson's support for parsing
non-standard hexadecimal numeric literals ("0x1234").
I believe the intention of the aforementioned patches was not to stop using
lua-cjson, just to use Debian's packaged version thereof, and so both
1. the build infrastructure must be taught to find the appropriate -llua*-cjson
flag (presumably -llua5.4-cjson if we're building for 5.4 and... something
else? if we're building for luajit?), and...
2. either...
1. the build system should cause the C preprocessor to define
XM_CONFIG_API_HAVE_LUA_CJSON, or
2. The test for that symbol in core/src/xmake/engine.c should be removed as
part of applying debian/patches.
A baseline test of functionality is that the resulting xmake binary should
contain the string "cjson", as that symbol is exposed to Lua as a global when
the lua-cjson library is enabled.
Thank you for your time,
--nwf;
-- System Information:
Debian Release: 12.5
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500,
'stable'), (50, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-10-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND,
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages xmake depends on:
ii libc6 2.36-9+deb12u7
ii liblua5.4-0 5.4.6-3+b1
ii liblz4-1 1.9.4-1
ii libncurses6 6.4-4
ii libreadline8t64 8.2-4
ii libsv1 1.1-1
ii libtinfo6 6.4-4
ii xmake-data 2.9.1+ds-1
Versions of packages xmake recommends:
ii doxygen 1.9.4-4
xmake suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: xmake
Source-Version: 2.9.2+ds-2
Done: Lance Lin <[email protected]>
We believe that the bug you reported is fixed in the latest version of
xmake, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lance Lin <[email protected]> (supplier of updated xmake package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 08 Jun 2024 17:17:06 +0700
Source: xmake
Architecture: source
Version: 2.9.2+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Lance Lin <[email protected]>
Changed-By: Lance Lin <[email protected]>
Closes: 1072039
Changes:
xmake (2.9.2+ds-2) unstable; urgency=medium
.
* Fix build to use lua-cjson (Closes: #1072039).
- d/control: Replace lua-cjson with lua-cjson-dev in build depends.
- d/rules: Append link to 'lua5.4-cjson'.
- d/patches: Update patch to define symbol for lua-cjson if linker
flag is passed.
Checksums-Sha1:
feeb12545de6b038ca4017e4e6aee542d4b4e37d 2041 xmake_2.9.2+ds-2.dsc
ac1020f18c6911f5a4c69afe75733ddd06ae8ad1 6052 xmake_2.9.2+ds-2.debian.tar.xz
bcc630cccf97099b9223dad015dfbd0edb76af7d 7000 xmake_2.9.2+ds-2_amd64.buildinfo
Checksums-Sha256:
d2ed82e9806951581d2e5e56df133080fa765f4b7bf5f0b48f84a605bbcbe7e9 2041
xmake_2.9.2+ds-2.dsc
4b0483e1e73212d27a64113e09b7f8d733c9963d1f095313b7451192d7ca8469 6052
xmake_2.9.2+ds-2.debian.tar.xz
0bc2789fa69570c5d00599afa76e603c5de51396b621709e5001b732ef919e48 7000
xmake_2.9.2+ds-2_amd64.buildinfo
Files:
dfc8d530a3e831db68c45d540a47526c 2041 devel optional xmake_2.9.2+ds-2.dsc
d689913a0f9da3cd20475684a0f6a6a4 6052 devel optional
xmake_2.9.2+ds-2.debian.tar.xz
df0ce3f3159bf5f085198d26068a4e1c 7000 devel optional
xmake_2.9.2+ds-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEESjHbWh7kCWyHOZiAkDZJKUwz+bcFAmZkMIsACgkQkDZJKUwz
+bcKtA/8DfDp9naK1UTMajBTijd4Kc93+X4pHSbs91na2+JkWukbEue1U9ZyhaxU
CtlSMmXUkqrfqj5Kxxqt2MAGw3VvViiTqhMe7EQsQ8V0hDVtzM0xt5BO5JqmojAY
/kbR4unvM62qnt2It2FCSDswxxK5lpLco5QgxdQEGMTgdOy0A4+dTZ6Cdq9t+35b
0LVgLbUzfLTmQA5tRd4fzbk7QooX92vTf7p1V3LouXt+cvF/zOAOFvJRUiHxj5A4
CYPRvPL4/WLwpWWj3QEGioQUqAvO9+2sNfYmFQ+nYn8oeGstlI5Mq52HJDjo4Hcd
piJ8nrRNFka3IGp++M/vx2ecyoatZt6EufunHSfzJ+y4lbtGhTlZDbwoeGkLyoBd
ZUGUjgZPv02HYk3Xb1nxJA0QxfeQ++3pEZ3ZVwSvNoOmVDybJVCs32RAcqTcVXmj
IFmw8sydPm0CtFLdf7Uw4Zgxo3gy1TY4zPHE+pcEv6VFefLirsgQt45jTBbeG22D
pae/3J5ieU8ShGPBT/BUJv1RAgL16kmBAp8/Y+7Mi7L/T+DS+dfgovQ4zT2PioJ6
nRs3Bc2tYPfRg32TX3hXdGJiRGIfmt2WOVnfCxFAPZaKyDwKEWjD7IbQa2Fi48pH
dcV4NLtxQPLdEvE3GRVaWlqNS+XdcMMiJ7kba+lh09T4kov0Ib0=
=/hPk
-----END PGP SIGNATURE-----
pgpOtl8HhWruq.pgp
Description: PGP signature
--- End Message ---
