Your message dated Tue, 18 Jun 2024 23:50:31 +0000
with message-id <[email protected]>
and subject line Bug#1071028: fixed in viewnior 1.8-4
has caused the Debian Bug report #1071028,
regarding viewnior: FTBFS with exiv2 0.28
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1071028: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071028
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: viewnior
Version: 1.8-3
Severity: important
Tags: patch ftbfs
Control: forwarded -1 https://github.com/hellosiyan/Viewnior/pull/134
Hi,
viewnior fails to build with the new stable series of the Exiv2 library,
i.e. 0.28.x; that version is available in experimental as of this
writing.
There are two upstream PRs to address this problem, i.e. PR 130 [1] and
PR 134, and sadly they have been sitting there for some months now
(viewnior does not seem an actively developed project). I chose PR 134,
as I find it as cleaner approach, I extracted the patch/commit from it,
and verified that it builds fine with both Exiv2 0.27 and Exiv2 0.28;
you can find it attached to this bug. Would you review this patch, and
upload it so that viewnior rebuilds cleanly once a newer Exiv2 is
uploaded to unstable?
In addition to the actual fix, I attached an update of the libexiv2-dev
build dependency, which is the result of the backported patch.
[1] https://github.com/hellosiyan/Viewnior/pull/130
[2] https://github.com/hellosiyan/Viewnior/pull/134
Thanks,
--
Pino
Author: Robert-André Mauchin <[email protected]>
Description: Fix build with >=exiv2-0.28.0, raise minimum to 0.27.0
- enables use of EXIV2_TEST_VERSION macro
- add compatibility for exiv2-0.28.0
Forwarded: https://github.com/hellosiyan/Viewnior/pull/134
Last-Update: 2023-11-11
diff --git a/meson.build b/meson.build
index 8f91fb5..9ef9f09 100644
--- a/meson.build
+++ b/meson.build
@@ -28,7 +28,7 @@ viewnior_deps = [
dependency('gio-2.0', version: glib_ver),
dependency('shared-mime-info', version: '>= 0.20'),
dependency('gdk-pixbuf-2.0', version: '>= 0.21'),
- dependency('exiv2', version: '>= 0.21'),
+ dependency('exiv2', version: '>= 0.27'),
]
#
diff --git a/src/uni-exiv2.cpp b/src/uni-exiv2.cpp
index 0d14b9f..d03edd7 100644
--- a/src/uni-exiv2.cpp
+++ b/src/uni-exiv2.cpp
@@ -22,12 +22,21 @@
#include <exiv2/exiv2.hpp>
#include <iostream>
+#include <memory>
#include "uni-exiv2.hpp"
+#if EXIV2_TEST_VERSION(0,28,0)
+ typedef Exiv2::Error Exiv2Error;
+ typedef Exiv2::Image::UniquePtr ImagePtr;
+#else
+ typedef Exiv2::AnyError Exiv2Error;
+ typedef Exiv2::Image::AutoPtr ImagePtr;
+#endif
+
#define ARRAY_SIZE(array) (sizeof array/sizeof(array[0]))
-static Exiv2::Image::AutoPtr cached_image;
+static ImagePtr cached_image;
extern "C"
void
@@ -35,7 +44,7 @@ uni_read_exiv2_map(const char *uri, void (*callback)(const
char*, const char*, v
{
Exiv2::LogMsg::setLevel(Exiv2::LogMsg::mute);
try {
- Exiv2::Image::AutoPtr image = Exiv2::ImageFactory::open(uri);
+ ImagePtr image = Exiv2::ImageFactory::open(uri);
if ( image.get() == 0 ) {
return;
}
@@ -80,7 +89,7 @@ uni_read_exiv2_map(const char *uri, void (*callback)(const
char*, const char*, v
}
}
}
- } catch (Exiv2::AnyError& e) {
+ } catch (Exiv2Error& e) {
std::cerr << "Exiv2: '" << e << "'\n";
}
}
@@ -103,7 +112,7 @@ uni_read_exiv2_to_cache(const char *uri)
}
cached_image->readMetadata();
- } catch (Exiv2::AnyError& e) {
+ } catch (Exiv2Error& e) {
std::cerr << "Exiv2: '" << e << "'\n";
}
@@ -121,7 +130,7 @@ uni_write_exiv2_from_cache(const char *uri)
}
try {
- Exiv2::Image::AutoPtr image = Exiv2::ImageFactory::open(uri);
+ ImagePtr image = Exiv2::ImageFactory::open(uri);
if ( image.get() == 0 ) {
return 2;
}
@@ -133,7 +142,7 @@ uni_write_exiv2_from_cache(const char *uri)
cached_image.reset(NULL);
return 0;
- } catch (Exiv2::AnyError& e) {
+ } catch (Exiv2Error& e) {
std::cerr << "Exiv2: '" << e << "'\n";
}
--
2.43.0
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Build-Depends:
debhelper-compat (= 13),
meson,
intltool (>= 0.35.0),
- libexiv2-dev,
+ libexiv2-dev (>= 0.27.0),
libgtk-3-dev
Standards-Version: 4.6.2
Homepage: https://siyanpanayotov.com/project/viewnior/
--- End Message ---
--- Begin Message ---
Source: viewnior
Source-Version: 1.8-4
Done: Dominik Szmek <[email protected]>
We believe that the bug you reported is fixed in the latest version of
viewnior, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dominik Szmek <[email protected]> (supplier of updated viewnior package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 12 Jun 2024 22:24:42 +0200
Source: viewnior
Architecture: source
Version: 1.8-4
Distribution: experimental
Urgency: medium
Maintainer: Dominik Szmek <[email protected]>
Changed-By: Dominik Szmek <[email protected]>
Closes: 1071028
Changes:
viewnior (1.8-4) experimental; urgency=medium
.
* Bump dependency on exiv2 to use 0.28.
thanks to Pino Toscano <[email protected]>.
Closes: #1071028
Checksums-Sha1:
9237abc1833d19412fdf63ff98c64fa4a0385f38 1894 viewnior_1.8-4.dsc
ef2b5c7c90fb8ed6fd958d8f0c33601e665a18ac 14668 viewnior_1.8-4.debian.tar.xz
8ee4845067e69ad783af7c2b8440a1d5eba15044 15600 viewnior_1.8-4_amd64.buildinfo
Checksums-Sha256:
06e080132dfaadcb01f7491bcd2d6d547331b88f6d97f940f07bb11b441ef30a 1894
viewnior_1.8-4.dsc
e58c5d5bcad71f2b408c0e38f4b180593a579eb05a25b9144b8b63acd9e6975d 14668
viewnior_1.8-4.debian.tar.xz
0d986339b5086173969e8a17a9ea90bc5122fdcefd4ffba325685551ef53df54 15600
viewnior_1.8-4_amd64.buildinfo
Files:
3c2d737c7697dc9bb1e22e9174b0bbb4 1894 graphics optional viewnior_1.8-4.dsc
b54b25947d6387e61496a6825d65cc5f 14668 graphics optional
viewnior_1.8-4.debian.tar.xz
b4aa10ab092ede6f192636c39f37b95f 15600 graphics optional
viewnior_1.8-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEdzOzKNJ5X1viMlrdAVCdXKtK/T8FAmZyGZwACgkQAVCdXKtK
/T+eww//ZkUEDHwrzyCrMiwz8sE5cHwfcvrd1ImYIwQc8uIWaGxzANJNiOtLdCAR
R13Jqtf+sO3yz5EzijzotbPXJT2IyRLU5mH6w6e6JNigrS9/741lEwEJA5YTt+zm
LwXVyyNdHTNDVKClwF2uQDMjbnYNMwjl+zc5Y6TaoY94s+gMaZiPjYAYptVS7Xpx
jYpKu5rGS07hTvuV9fMMza+V4cGaJGc3N3nLj8bllres8tMiwXsulsDHUr5Mwhlg
O0MZ5Nmgf7uFT1Lqi+70HwINnAezKOYI9rSVqtYVNY50/UNZR5bONbNZRSzAyXkQ
7/Mf/XxeZj1UAEQ97xXc+bQ1CsAAw7ehulnP3vrNaypksNR0E35rTl55w0Lkqv51
gDglsqDzWcPx/8ndFgHFc7q+uvBmXHqsnWjeMEZ+AI6bkuJfVUr/7UorVASKZnwB
7c75QtOmWrcI2oVZbdDbaYn0XnFB2wyGMBd+gb7/9IZEYswNVJPFFchM+pZ0nEkt
GajqDqz0KspYBh6OzF0G0X3OIV6TPiJ+BxgkA8cQKU/tX9tZyYKSTHkdWn3oJlBE
QCN/LdNJYwXwiVXPs8uDpF6iPOd11tWMiCsXNXD8uHpNyx18UXAO0zsEIfNJ+eew
TcaeWPZhCSvbxtwdSGM9141N7ZuLPjuohUaG6evoTvdB/eHRCig=
=x/G6
-----END PGP SIGNATURE-----
pgpQ5f7LAz0nq.pgp
Description: PGP signature
--- End Message ---
