Your message dated Thu, 11 Jul 2024 16:29:29 +0000
with message-id <[email protected]>
and subject line Bug#1063565: fixed in weex 2.8.4.3
has caused the Debian Bug report #1063565,
regarding different build results based on timestamps of configure.in and 
aclocal.m4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1063565: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063565
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:weex
Version: 2.8.4.2
Tags: patch

The weex's Makefile _may_ run aclocal/autoconf/configure in dh_auto_build
depending on the timestamp comparison of files configure.in and aclocal.m4
(for details, manually run `dh_auto_configure` then check `make --debug`).

Non-maintainers might be unaware of this, and get unexpected build results,
e.g., _not_ link against `libssl` (which even segfaults in 2.8.3! LP: #1811817),
if they just `cp/scp -r` files, for example (not the most precise
copy, arguably,
but also unexpected to _silently_ produce such a different result and impact).

Ideally, `dh_autoreconf` would update `configure` in `dh_auto_configure`,
but it still fails (bug 929050) and needs more work that is very specific to
the project/package, apparently, and thus better handled by maintainers.

So, for now, in order to make the builds more deterministic and not implicitly
rely on the timestamps of the two files, let's just ensure `debian/rules` does
explicitly update the timestamp as required to keep current build behavior.

Thanks,
Mauricio

test steps:

$ dpkg-source -x weex_2.8.4.2.dsc
$ cp -r weex-2.8.4.2 weex-2.8.4.2-copy
$ ls -l --full-time weex-2.8.4.2{,-copy}/{aclocal.m4,configure.in}
-rw-rw-r-- 1 ubuntu ubuntu 183326 2024-02-09 15:10:04.563181675 +0000
weex-2.8.4.2-copy/aclocal.m4
-rw-rw-r-- 1 ubuntu ubuntu   2134 2024-02-09 15:10:04.563181675 +0000
weex-2.8.4.2-copy/configure.in
-rw-rw-r-- 1 ubuntu ubuntu 183326 2014-09-19 21:35:12.000000000 +0000
weex-2.8.4.2/aclocal.m4
-rw-rw-r-- 1 ubuntu ubuntu   2134 2017-02-08 14:03:36.000000000 +0000
weex-2.8.4.2/configure.in

original directory:

$ cd weex-2.8.4.2
$ dpkg-buildpackage -b -uc
...
dh_auto_configure
...
checking for SSL_library_init in -lssl... no
...
dh_auto_build
...
checking for OPENSSL_init_ssl in -lssl... yes
...

$ ldd ./debian/weex/usr/bin/weex | grep libssl
libssl.so.3 => /lib/x86_64-linux-gnu/libssl.so.3 (0x00007ff1214d9000)

copy directory:

$ cd ../weex-2.8.4.2-copy
$ dpkg-buildpackage -b -uc
...
dh_auto_configure
...
checking for SSL_library_init in -lssl... no
...
dh_auto_build
...

$ ldd ./debian/weex/usr/bin/weex | grep libssl
$


-- 
Mauricio Faria de Oliveira

Attachment: weex-touch-configurein.debdiff
Description: Binary data


--- End Message ---
--- Begin Message ---
Source: weex
Source-Version: 2.8.4.3
Done: Ludovic Drolez <[email protected]>

We believe that the bug you reported is fixed in the latest version of
weex, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ludovic Drolez <[email protected]> (supplier of updated weex package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 11 Jul 2024 16:46:52 +0200
Source: weex
Architecture: source
Version: 2.8.4.3
Distribution: unstable
Urgency: medium
Maintainer: Ludovic Drolez <[email protected]>
Changed-By: Ludovic Drolez <[email protected]>
Closes: 1051065 1063565
Changes:
 weex (2.8.4.3) unstable; urgency=medium
 .
   * Upstream tar updated. Closes: #1051065
   * d/rules: `touch configure.in` for `dh_auto_build`, so that `make`
     runs `missing --run autoconf` and `configure` runs again (do not
     rely on timestamps of `configure.in` vs. `aclocal.m4`), for more
     deterministic builds. Closes: #1063565
     by Mauricio Faria de Oliveira <[email protected]>
Checksums-Sha1:
 68b295b2988167c63bc76b348e24bfba60142e00 1110 weex_2.8.4.3.dsc
 3e5c2af18934a9166c7a6023f038ded5d6134c1c 337504 weex_2.8.4.3.tar.gz
 6e3eec05c8747f339ec72fd5d79b432a66e46cab 6639 weex_2.8.4.3_amd64.buildinfo
Checksums-Sha256:
 a8ab5d6bd9586f7de9caa8e01978a41c068ad2486fdcae7c2bcd85f919861b31 1110 
weex_2.8.4.3.dsc
 bd530f056395fc1ce54c952eec0af498a5b2b8245a5afbfeb1c268beb07111b8 337504 
weex_2.8.4.3.tar.gz
 ff28a715f370ad9d99cebf24268f124235901cbc7ab3049e0d5e736316861812 6639 
weex_2.8.4.3_amd64.buildinfo
Files:
 2e7897530beefa22718e5e88be0cbd9f 1110 net optional weex_2.8.4.3.dsc
 2c10cbc312ac5ccc37a5d50dc5960a92 337504 net optional weex_2.8.4.3.tar.gz
 e017738b4cdbf8688e98e471af4937c1 6639 net optional weex_2.8.4.3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFHBAEBCAAxFiEEKrWNbKjxjlSqtxlZi3UoEkf5wXwFAmaP+/8THGxkcm9sZXpA
ZGViaWFuLm9yZwAKCRCLdSgSR/nBfC5gB/9LRs7XR7DoMV9uHhQyTa/R3rRAlkvf
TjyCuBKFsehpW3pGXIh/TTeGRFLxv09R1nfXKJFCDluTn0Xtcuer4Hr+a3HKI3DB
ndDXVPbmDG99CVn2SI1YXhqm5SMpKk0CDrDwL8xbFEmi+m8JbxpdbJvvzGh6FTcK
Kwrdf5argCKHcKvBi/3DOGOj6bbvBDB6zlHQCmtuyZdJlekztzFjDxV1OKhcmx8g
Wi5ojlFaI0dpLHc9MatCUumt5NGF5XwnNMopGoW3ZvtDDtuOMjmduZqdOP2SWr3J
BgqxLc0ks8z1hDCfyRKSX66a/07AJTqIsQS/NTUQahJ50Omg7gpwKNQI
=v2bI
-----END PGP SIGNATURE-----

Attachment: pgpHSzUgun2tg.pgp
Description: PGP signature


--- End Message ---

Reply via email to