Your message dated Fri, 12 Jul 2024 06:07:04 +0000
with message-id <[email protected]>
and subject line Bug#1070849: fixed in onetbb 2021.12.0-1
has caused the Debian Bug report #1070849,
regarding onetbb: FTBFS: Fix testcases failed on loong64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1070849: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070849
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: onetbb
Version: 2021.11.0-2
Severity: normal
Tags: FTBFS patch
User: [email protected]
Usertags: loong64

Dear maintainers,

Compiling the onetbb failed for loong64 in the Debian Package Auto-Building environment.
The error log is as follows,
```
99% tests passed, 1 tests failed out of 137

Total Test time (real) = 233.63 sec

The following tests FAILED:
    133 - test_malloc_whitebox (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util
```
The full log can be found at https://buildd.debian.org/status/logs.php?pkg=onetbb&ver=2021.11.0-2&arch=loong64.

For loongarch64, the size of the huge page I got from /proc/meminfo is 32768 kB.
```
$ cat /proc/meminfo |grep Hugepagesize
Hugepagesize:      32768 kB
$ uname -m
loongarch64
```

I have adjusted the page size of HUGE_PAGE_SIZE for loongarch64 in onetbb package.
I have built successfully on my local ENV and test cases passed.
```
137/137 Test #137: test_malloc_new_handler .................. Passed    0.04 sec
100% tests passed, 0 tests failed out of 137
Total Test time (real) = 332.60 sec
```

The pull request for loongarch64 has been merged in onetbb upstream.
https://github.com/oneapi-src/oneTBB/pull/850/files.
https://github.com/oneapi-src/oneTBB/pull/1230/files.

Meanwhile, you can also consider the patch I attached.
Your opinions are welcome.

Thanks,
Dandan Zhang

Description: Adjust HUGE_PAGE_SIZE size for loongarch64 
Last-Update: 2024-05-10

--- onetbb-2021.11.0.orig/src/tbbmalloc/tbbmalloc_internal.h
+++ onetbb-2021.11.0/src/tbbmalloc/tbbmalloc_internal.h
@@ -102,7 +102,11 @@ void suppress_unused_warning( const T& )
 /*
  * Default huge page size
  */
+#if defined __loongarch64
+static const size_t HUGE_PAGE_SIZE = 32 * 1024 * 1024;
+#else
 static const size_t HUGE_PAGE_SIZE = 2 * 1024 * 1024;
+#endif
 
 /********** End of global default constants *********/
 
--- onetbb-2021.11.0.orig/test/tbbmalloc/test_malloc_whitebox.cpp
+++ onetbb-2021.11.0/test/tbbmalloc/test_malloc_whitebox.cpp
@@ -1257,7 +1257,11 @@ void TestTHP() {
     scalable_allocation_mode(USE_HUGE_PAGES, 1);
     REQUIRE_MESSAGE(hugePages.isEnabled, "Huge pages should be enabled via scalable_allocation_mode");
 
+#if defined __loongarch64
+    const int HUGE_PAGE_SIZE = 32 * 1024 * 1024;
+#else
     const int HUGE_PAGE_SIZE = 2 * 1024 * 1024;
+#endif
 
     // allocCount transparent huge pages should be allocated
     const int allocCount = 10;

--- End Message ---
--- Begin Message ---
Source: onetbb
Source-Version: 2021.12.0-1
Done: Mo Zhou <[email protected]>

We believe that the bug you reported is fixed in the latest version of
onetbb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mo Zhou <[email protected]> (supplier of updated onetbb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 12 Jul 2024 01:16:04 -0400
Source: onetbb
Architecture: source
Version: 2021.12.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Mo Zhou <[email protected]>
Closes: 1070849
Changes:
 onetbb (2021.12.0-1) unstable; urgency=medium
 .
   [ zhangdandan ]
   * Fix testcases failed on loong64 (Closes: #1070849)
 .
   [ Mo Zhou ]
   * Upload to unstable.
Checksums-Sha1:
 f0c20e08ea5258ba8cb93f27fb7434d6f3df3155 2517 onetbb_2021.12.0-1.dsc
 3160100002b9b243f947767f11579b61ed84a841 19064 onetbb_2021.12.0-1.debian.tar.xz
 a26b7696e808206f95b072913740cd9ee8e4db29 9262 
onetbb_2021.12.0-1_source.buildinfo
Checksums-Sha256:
 53b86bb66a96a1c8dfecf94edd352df20e7defbfa86aedc4a69cb226cfa6025e 2517 
onetbb_2021.12.0-1.dsc
 5a9f5b71e2eeecb6aedb16e55d91a10d248e80e6ff367560df7222131998fb16 19064 
onetbb_2021.12.0-1.debian.tar.xz
 871848561106d83b266998099661cfc268574d823671d0db7e0fe76d70f351b0 9262 
onetbb_2021.12.0-1_source.buildinfo
Files:
 2b81f8f57a1a7861eb517d2f7766967f 2517 libs optional onetbb_2021.12.0-1.dsc
 89bcb49073fd781e70fdaf05d0d2324e 19064 libs optional 
onetbb_2021.12.0-1.debian.tar.xz
 81b26a5d7669d79c7b16f334297b5f01 9262 libs optional 
onetbb_2021.12.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAmaQxGcRHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaopdMhAAkbDMwrWWQNjyyUo0jz7R8a0eW98J/Fbi
EqxhP6lctKjMDvPzOimux9zaadyv2w3xGqRoYaNnxqIxnlQm0C5sXkC1Ce8mmix1
DQzqReM0hMi33YfSp/sxoqiljusM21sGPfAq1MJ65oe1uFJ+SnVP5L4t0bfD9Bwz
GIxnI9JnTA15lXfhRsSFc/5JmiAbIR/nNSHb0+sd0PLzwhdwDnXCbaGpstHivtoY
N0fTdSaULbjfO2+mGR0i1IndUi7hCWBuEL57l6LPA8BAVExUbvIcL4ITPF0VRh3d
zGoFDzGtkgs4o9FyhjQjJuwENIzOS0abwFO0faMrYfiYttPeYkRVkSf6YSfznG8J
UWoFs3C4MH32HyIO88Jv7B8rZCwrn1hyLBdVqUgEnsCTF5cww/hLGWv6/6yZ1WLi
4uiWRH1TYjhmPu7JNqkqcQ7JKJfXO7CisEobrcojQp4eF5QuOZ9BPv9BZsXSXEtj
m9IVdEzVTrCodLjjmbEYuRCGdS/l9ZdPK7Pfg4hZwNt49VeeuAbrEmRNbPqGmB9J
m4ZDr3nAX3YvZKPsB/4MHaxzPQzcfWfAubX85lH+L3ycQtMlLOhMrc8bSp4PDLyp
3nMZWRFE1Ggqd8zEVh6HnbpCkzy1zyTp7DxKUf/ryqir0lnOpJp6bD7clUubr4y7
VKgHC/9ofiw=
=7o1F
-----END PGP SIGNATURE-----

Attachment: pgp6Ub0Z6vtcX.pgp
Description: PGP signature


--- End Message ---

Reply via email to