Your message dated Sat, 03 Aug 2024 15:53:51 +0000
with message-id <[email protected]>
and subject line Bug#1063459: fixed in pushover 1.1-5
has caused the Debian Bug report #1063459,
regarding pushover FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1063459: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063459
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pushover
Version: 1.1-3
Tags: patch
User: [email protected]
Usertags: ftcbfs
pushover fails to cross build from source for multiple reasons. The
immediate failure is a failure to find SDL2_image.pc using the build
architecture pkg-config. What initially looks like wrongly hard coding a
build architecture pkg-config turns out to be a correct use: It actually
needs SDL2_image for a build-time utility and SDL2_image is not used at
all for host objects. Therefore, the relevant build dependency should be
annotated :native. Once this is fixed, a build architecture compiler
invocation fails to understand host architecture compiler flags.
Recently, Debian started employing architecture-dependent compiler flags
such as -mbranch-protection=standard (arm64) and this fails all over the
place. I propose extending the build system to tell "_NATIVE" flags
apart like it does with compilers already. The defaults are chosen such
that backwards-compatibility is retained. Once passing these from
debian/rules, pushover actually cross builds. Do you mind applying this
patch?
Helmut
diff --minimal -Nru pushover-1.1/debian/changelog pushover-1.1/debian/changelog
--- pushover-1.1/debian/changelog 2023-12-16 14:25:10.000000000 +0100
+++ pushover-1.1/debian/changelog 2024-02-08 12:40:44.000000000 +0100
@@ -1,3 +1,12 @@
+pushover (1.1-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + libsdl2-image-dev is used for the build architecture.
+ + cross.patch: Distinguish build and host compiler flags.
+
+ -- Helmut Grohne <[email protected]> Thu, 08 Feb 2024 12:40:44 +0100
+
pushover (1.1-3) unstable; urgency=medium
* source upload to allow migration of NEW packages
diff --minimal -Nru pushover-1.1/debian/control pushover-1.1/debian/control
--- pushover-1.1/debian/control 2023-12-16 14:01:18.000000000 +0100
+++ pushover-1.1/debian/control 2024-02-08 12:39:59.000000000 +0100
@@ -15,7 +15,7 @@
libboost-dev,
libboost-filesystem-dev,
libboost-system-dev,
- libsdl2-image-dev,
+ libsdl2-image-dev:native,
libsdl2-mixer-dev,
libsdl2-ttf-dev,
Standards-Version: 4.6.2
diff --minimal -Nru pushover-1.1/debian/patches/cross.patch
pushover-1.1/debian/patches/cross.patch
--- pushover-1.1/debian/patches/cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ pushover-1.1/debian/patches/cross.patch 2024-02-08 12:40:44.000000000
+0100
@@ -0,0 +1,23 @@
+--- pushover-1.1.orig/Makefile
++++ pushover-1.1/Makefile
+@@ -29,9 +29,11 @@
+ CXX = $(CROSS)$(CXX_NATIVE)
+ CXX_NATIVE = g++
+ CXXFLAGS = -Wall -Wextra -g -O2 -std=c++17
++CXXFLAGS_NATIVE ?= $(CXXFLAGS)
+ EXEEXT = $(if $(filter %-w64-mingw32.static-,$(CROSS)),.exe,)
+ INSTALL = install
+ LDFLAGS =
++LDFLAGS_NATIVE ?= $(LDFLAGS)
+ MSGFMT = msgfmt
+ MSGMERGE = msgmerge
+ PKG_CONFIG = $(CROSS)$(PKG_CONFIG_NATIVE)
+@@ -84,7 +86,7 @@
+ .SECONDARY: _tmp/dominoes/assembler
+ _tmp/dominoes/assembler: $(ASSEMBLER_SOURCES)
+ @mkdir -p $(dir $@)
+- $(CXX_NATIVE) $(CXXFLAGS) $(LDFLAGS) $$($(PKG_CONFIG_NATIVE) --cflags
$(ASSEMBLER_PKGS)) -o $@ $< $$($(PKG_CONFIG_NATIVE) --libs $(ASSEMBLER_PKGS))
++ $(CXX_NATIVE) $(CXXFLAGS_NATIVE) $(LDFLAGS_NATIVE)
$$($(PKG_CONFIG_NATIVE) --cflags $(ASSEMBLER_PKGS)) -o $@ $<
$$($(PKG_CONFIG_NATIVE) --libs $(ASSEMBLER_PKGS))
+
+ DOMINOES_SOURCES := src/dominoes/domino.ini $(wildcard src/dominoes/*.pov)
+ .SECONDARY: _tmp/dominoes/povray_done
diff --minimal -Nru pushover-1.1/debian/patches/series
pushover-1.1/debian/patches/series
--- pushover-1.1/debian/patches/series 2023-11-30 23:34:29.000000000 +0100
+++ pushover-1.1/debian/patches/series 2024-02-08 12:40:44.000000000 +0100
@@ -1 +1,2 @@
datadir.patch
+cross.patch
diff --minimal -Nru pushover-1.1/debian/rules pushover-1.1/debian/rules
--- pushover-1.1/debian/rules 2023-12-02 02:28:55.000000000 +0100
+++ pushover-1.1/debian/rules 2024-02-08 12:40:44.000000000 +0100
@@ -9,7 +9,7 @@
dh $@
override_dh_auto_build:
- $(MAKE) BINDIR=/usr/games DATADIR=/usr/share/games CXX=$(CXX)
CXXFLAGS='$(CPPFLAGS) $(CXXFLAGS) -Wall -Wextra -g -O2 -std=c++17'
LDFLAGS='$(LDFLAGS)' PKG_CONFIG=$(PKG_CONFIG) PKG_LUA=lua-5.4
+ $(MAKE) BINDIR=/usr/games DATADIR=/usr/share/games CXX=$(CXX)
CXXFLAGS='$(CPPFLAGS) $(CXXFLAGS) -Wall -Wextra -g -O2 -std=c++17'
LDFLAGS='$(LDFLAGS)' PKG_CONFIG=$(PKG_CONFIG) PKG_LUA=lua-5.4
CXXFLAGS_NATIVE='$(CPPFLAGS_FOR_BUILD) $(CXXFLAGS_FOR_BUILD) -Wall -Wextra -g
-O2 -std=c++17' LDFLAGS_NATIVE='$(LDFLAGS_FOR_BUILD)'
override_dh_auto_test:
echo "checks needs portable_datadir and are disabled"
--- End Message ---
--- Begin Message ---
Source: pushover
Source-Version: 1.1-5
Done: Alexandre Detiste <[email protected]>
We believe that the bug you reported is fixed in the latest version of
pushover, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alexandre Detiste <[email protected]> (supplier of updated pushover package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 03 Aug 2024 16:55:04 +0200
Source: pushover
Architecture: source
Version: 1.1-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Alexandre Detiste <[email protected]>
Closes: 1063459 1075402
Changes:
pushover (1.1-5) unstable; urgency=medium
.
* Fix FTBFS with GCC-14 (Closes: #1075402)
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #1063459)
+ libsdl2-image-dev is used for the build architecture.
+ cross.patch: Distinguish build and host compiler flags.
Checksums-Sha1:
3a8605dd9d8fb1637f415f4d205fbe2661dc122e 2259 pushover_1.1-5.dsc
fbbfa48801a2042ef6e10107d77b6b825782a313 5556 pushover_1.1-5.debian.tar.xz
4492f4808b793d477085adb2a600796f92e296aa 15136 pushover_1.1-5_source.buildinfo
Checksums-Sha256:
a99d5f1dce750417ce6f9fd3ff54324257af354235fc8f7d29fbd51775068af8 2259
pushover_1.1-5.dsc
1fce238866f5493107e833ec002160967bae47c7a36983b51442b791f6dd0fb4 5556
pushover_1.1-5.debian.tar.xz
a8f8ac2862cd28135d9105bcdc689aafeccdd0b540d59a33275eb13cb5c80b84 15136
pushover_1.1-5_source.buildinfo
Files:
6e54c1c61b82974c637d221db82f7e60 2259 games optional pushover_1.1-5.dsc
85a06d24177082cf2ab594ca41463e4d 5556 games optional
pushover_1.1-5.debian.tar.xz
c491a2489c03ce805f84f766f47f9ea8 15136 games optional
pushover_1.1-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmauSzwRHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBpJRxAAwrg76KjUHqdRphVUisFHmqoKRJTvwtRt
dsvIdV83h44IWgfCt+6fglA4aG0jI0DjYsKAEas5cCbb7J2QkCZNUUqfSBMLqZ4b
o/E5BzzeDMyb61yQ2QxaomYFta2Lvq3uLAZWwOn53BrTNG0A+zH4Se0l8CsbqI1P
S4PCD4FpBiJYW9ubq5bY2NnAi8XwxaXW4+rhV1M3odZ7c0XvIhR26eXmp1QW7RIh
GxD2mag4+/7mzcYaYEnF8BC8LkD9kr6WXDo/9AKEQYl0LdIHCVaXAmb/jJ9BTBZA
aP26ojgjkKG0zmKNCwrhNxy3yQgZGuUH2KtqI9j4da4kEPRpTeCN4brFrFIF/0R4
8Tk1b+jFDlAOfMPiqgmL0dFbpZLCJupcownPG/MnFalUhT1jVcC+mxooyx4p99k2
vmLiHhjKIRc10cMTfqmB9EqWlFTIcq/YuX0f6hIQJzwb+rtH/j9m/MwPevI0e7vV
XrO1by7YoTX4GVqlOtWgotOyrTYYO53Yox4noQIH9lJtXcqhFMH/dXR3LCYWIoy7
5XPfG3S+s8ojn8bRTbLdnM48K2NmQx9cmPx+Y8qGVduODeljg7QumdFoh3BlHLKS
+Dyi77zUju6R9dDGBlSqBlxVzv6hrA5IeEK49GcnCWRRRFu+42JRmPSNd13XdPws
G2XD8yt4M0A=
=UHkC
-----END PGP SIGNATURE-----
pgpi9xO2fx9ys.pgp
Description: PGP signature
--- End Message ---
