Your message dated Sat, 21 Sep 2024 11:22:52 +0000
with message-id <[email protected]>
and subject line Bug#933080: fixed in pekka-kana-2 1.4.5+ds-2
has caused the Debian Bug report #933080,
regarding pekka-kana-2 FTCBFS: uses build architecture build tools
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
933080: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=933080
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pekka-kana-2
Version: 1.2.2-2
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
pekka-kana-2 fails to cross build from source. The upstream Makefile
hard codes the build architecture pkg-config and it uses the
non-standard variable CPP for storing the C++ compiler while CXX would
be more common and supplied by debhelper. The attached patch makes
pkg-config substitutable and renames CPP to CXX. Please consider
applying it.
Helmut
--- pekka-kana-2-1.2.2.orig/Makefile
+++ pekka-kana-2-1.2.2/Makefile
@@ -7,9 +7,10 @@
# "make" - Creates Pekka Kana 2 binary
# "make clean" - Removes all objects, executables and dependencies
-CPP = g++
-CFLAGS += $(shell pkg-config --cflags sdl2) -g -O2 -std=gnu++17 -Wno-write-strings
-LFLAGS += $(shell pkg-config --libs sdl2) -lSDL2_mixer
+CXX = g++
+PKG_CONFIG ?= pkg-config
+CFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2) -g -O2 -std=gnu++17 -Wno-write-strings
+LFLAGS += $(shell $(PKG_CONFIG) --libs sdl2) -lSDL2_mixer
# Defines directories
SRC_DIR = src/
@@ -44,15 +45,15 @@
# Rules for generate the binaries using the object files
$(PK2_BIN): $(PK2_OBJ) $(PK2_SPRITE_OBJ) $(PK2_MAP_OBJ) $(ENGINE_OBJ)
@echo -Linking Pekka Kana 2
- @$(CPP) $^ $(LFLAGS) -o $@
+ @$(CXX) $^ $(LFLAGS) -o $@
# Rules for generate any *.o file
-include $(DEPENDENCIES)
build/%.o : src/%.cpp
@echo -Some dependence of $@ was changed, updating
- @$(CPP) $(CFLAGS) -I$(SRC_DIR) -o $@ -c $<
- @$(CPP) -MM -MT $@ -I$(SRC_DIR) $< > build/$*.d
+ @$(CXX) $(CFLAGS) -I$(SRC_DIR) -o $@ -c $<
+ @$(CXX) -MM -MT $@ -I$(SRC_DIR) $< > build/$*.d
makedirs:
@mkdir -p $(BIN_DIR) >/dev/null
--- End Message ---
--- Begin Message ---
Source: pekka-kana-2
Source-Version: 1.4.5+ds-2
Done: Tobias Frost <[email protected]>
We believe that the bug you reported is fixed in the latest version of
pekka-kana-2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Tobias Frost <[email protected]> (supplier of updated pekka-kana-2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 21 Sep 2024 12:23:56 +0200
Source: pekka-kana-2
Architecture: source
Version: 1.4.5+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Tobias Frost <[email protected]>
Closes: 933080
Changes:
pekka-kana-2 (1.4.5+ds-2) unstable; urgency=medium
.
* Re-add applicable parts for the FTCBFS patch (Closes: #933080).
Checksums-Sha1:
722de2ab97e2ddd1a7c19b44f8c2cafd37542df4 2093 pekka-kana-2_1.4.5+ds-2.dsc
4fe08d9db1442d93391f36708152dab5fcd8b75d 6736
pekka-kana-2_1.4.5+ds-2.debian.tar.xz
c75b1a641cc728eb761a77f67d44b8227d2cd1ff 13163
pekka-kana-2_1.4.5+ds-2_amd64.buildinfo
Checksums-Sha256:
6b0dfc47559591d73f07b01d268d2de7ce79bac3942c50ca1016d8391c358dea 2093
pekka-kana-2_1.4.5+ds-2.dsc
19c3f10b4a5159a4acc3912cfb754633f5e230f105dd6ae0296253ce19224dab 6736
pekka-kana-2_1.4.5+ds-2.debian.tar.xz
512fbcfc449453690279c901a1c7ee46321fa14d0fc26a6dd2ea0de86c5fa852 13163
pekka-kana-2_1.4.5+ds-2_amd64.buildinfo
Files:
f68b8654a020aca901f5284aa936c662 2093 games optional
pekka-kana-2_1.4.5+ds-2.dsc
4582f8d1bdbfa04f0f7951f53c35d4f3 6736 games optional
pekka-kana-2_1.4.5+ds-2.debian.tar.xz
5fd86f247ba6b759df5af5ffc87569ed 13163 games optional
pekka-kana-2_1.4.5+ds-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE/d0M/zhkJ3YwohhskWT6HRe9XTYFAmbun1MACgkQkWT6HRe9
XTZ+oBAAmeo06ukBFKrzdp2J+fujEhY8EJBG7XWcX0Yn4lnHspwMJe59uxslR84j
SyTjHWfXLPdd+2IEv5oe1EihfAVd0UARen5z/gnREPVPyjw7NxlhuFgmQ+z9xdjX
gIbjqf8HFIb8R+nR46Uo+FMh5i7AACTA2ioULmqt852tUyGeS/IhF40Kj/vtV7kY
3Whu1k2rLBRrDNmeyXwRKujwLIohp6br7DV2R80FKdLROPBHLVFTTCJbyg0wTNj6
yCHak0MXe19piJXk2qZS7SeWWcGSHWJifqqnti37r4GM+5cEthmg8HrJY/u8lvXb
CVcADEJl26rmUWalwWJSlfnBolY1Vj42KPUw8dquu5PhdeRBb+TpE5os9Cn6IrBl
xbEyogUaZTgbonqoUxsjnB+KQ3Tcept9FNFH90cvZ3mDipGM/6qo4QPzQ647bEuI
aKyio08HALphU0W+inxidC1BcQBtmiGwq/GvvTwChCAyQbvd7Q4w+wkzMZaZ1CjC
+D0YhDJzxypqcSsbvHpZMry7LRWnjAbtuHUlrBxo9v0uGN81fLXFm0AJrCMR+gDW
BiKqzHKWdklHepYRj1rw/ZGDGasXFSEXX3UFf0U6EGG1j/Owl+sXcnEB3etofwuI
g00Iu4EH1im89xFSR8EKBDuphnG5gFJTbeqKnc30+Sw7sVP6TkE=
=ucJu
-----END PGP SIGNATURE-----
pgpfSFCIMVrgW.pgp
Description: PGP signature
--- End Message ---
