Your message dated Mon, 23 Sep 2024 14:34:44 +0200
with message-id <[email protected]>
and subject line Re: [Pkg-sssd-devel] Bug#1060180: Bug#1060180: uid-wrapper:
cmocka does not set CMOCKA_LIBRARY anymore.
has caused the Debian Bug report #1060180,
regarding uid-wrapper: cmocka does not set CMOCKA_LIBRARY anymore.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1060180: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060180
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: uid-wrapper
Version: 1.3.0-4
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
Hey,
cmocka does not set CMOCKA_LIBRARY anymore with 1.1.6+. You can easly
use cmoka as library name. I tested the attached patch locally and it
makes the autopkgtests pass again.
Additionally enables VERBOSE=1 for make, so it is easier to spot what
command is actually executed.
Regards,
hefee
diff --git a/debian/tests/tests b/debian/tests/tests
index b2b4504..a5adfa6 100755
--- a/debian/tests/tests
+++ b/debian/tests/tests
@@ -6,7 +6,7 @@ rm -rf obj debian
mkdir obj
cd obj
cmake .. -DUNIT_TESTING=1
-make -C tests/
+make VERBOSE=1 -C tests/
cd tests
sed -e 's#\(LD_PRELOAD=[^:]*\)[^;]*/\(libuid_wrapper.so\)#\1:\2#' -i
CTestTestfile.cmake
make test ARGS="--output-on-failure"
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 635e86e..0398261 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -59,7 +59,7 @@ function(ADD_CMOCKA_TEST_ENVIRONMENT _TEST_NAME)
ENVIRONMENT "${TORTURE_ENVIRONMENT}")
endfunction()
-set(TESTSUITE_LIBRARIES ${UWRAP_REQUIRED_LIBRARIES} ${CMOCKA_LIBRARY})
+set(TESTSUITE_LIBRARIES ${UWRAP_REQUIRED_LIBRARIES} cmocka)
if (BSD)
add_definitions(-DBSD)
--- End Message ---
--- Begin Message ---
Hefee <[email protected]> writes:
> Hey,
>
>> Is this patch still relevant and necessary? How to reproduce the
>> problem? I think upstream's fix like this resolve this:
>>
>> https://gitlab.com/cwrap/uid_wrapper/-/commit/850f24c6366abda30bfd77734b9033
>> 0b8809d306
>
> I checked the reverse dependencies in January and provided one patch to work
> with current cmocka version. If upstream fixed it, that is even better.
> In the end, if it compiles and you can run the tests, than my patch is not
> needed anymore ;)
>
>> So unless there is some more information, I think this bug report can be
>> closed as fixed in 1.3.0-5. We'll see once the autopkgtest runs for the
>> recent 1.3.1-1 upload if there are any cmake errors.
>
> ACK
>
>> The VERBOSE=1 part was added here:
>> https://salsa.debian.org/sssd-team/uid-wrapper/-/commit/979e902813975791d93e
>> ff8f1d3fca3037846bb6
>
> nice.
Thank you for the report, patch and confirmation!
/Simon
signature.asc
Description: PGP signature
--- End Message ---
