Your message dated Sun, 06 Oct 2024 06:34:23 +0000
with message-id <[email protected]>
and subject line Bug#1081010: fixed in dump 0.4b47-6
has caused the Debian Bug report #1081010,
regarding dump: Dump fails verifying long symlinks with ext4 extents
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1081010: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1081010
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dump
Version: 0.4b47-4+~tjw12r5
Severity: normal

Dear Maintainer,

When using restore -C lgetflags returns 0 for symlinks as flags are not
vaild/settable on a symlink.

However, if EXT4_EXTENTS_FL is set then the verification fails saying
that the flags have changed.

./long_symlink: flags changed from 0x00080000 to 0x00000000.


-- System Information:
Debian Release: 12.7
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-25-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages dump depends on:
ii  libblkid1     2.38.1-5+deb12u1
ii  libbz2-1.0    1.0.8-5+b1
ii  libc6         2.36-9+deb12u8
ii  libcom-err2   1.47.0-2
ii  libext2fs2    1.47.0-2
ii  liblzo2-2     2.10-2
ii  libreadline8  8.2-1.3
ii  libselinux1   3.4-1+b6
ii  tar           1.34+dfsg-1.2+deb12u1
ii  zlib1g        1:1.2.13.dfsg-1

dump recommends no packages.

dump suggests no packages.

-- no debconf information
diff -urN dump-0.4b47.orig/restore/dirs.c dump-0.4b47/restore/dirs.c
--- dump-0.4b47.orig/restore/dirs.c     2022-05-03 10:02:27.000000000 +0000
+++ dump-0.4b47/restore/dirs.c  2022-05-03 10:02:27.000000000 +0000
@@ -791,7 +791,7 @@
                                do_compare_error;
                        }
 #ifdef __linux__
-                       if (lgetflags(cp, &newflags) < 0) {
+                       if (lgetflags(cp, &newflags, 0) < 0) {
                                if (node.flags != 0) {
                                        warn("%s: lgetflags failed", cp);
                                        do_compare_error;
diff -urN dump-0.4b47.orig/restore/extern.h dump-0.4b47/restore/extern.h
--- dump-0.4b47.orig/restore/extern.h   2022-05-03 10:02:27.000000000 +0000
+++ dump-0.4b47/restore/extern.h        2022-05-03 10:02:27.000000000 +0000
@@ -127,7 +127,7 @@
 int setflags (int, unsigned long);
 
 int lsetflags (const char *, unsigned long);
-int lgetflags (const char *, unsigned long *);
+int lgetflags (const char *, unsigned long *, unsigned long);
 
 #ifdef USE_QFA
 int    Inode2Tapepos (dump_ino_t, long *, long long *, int);
diff -urN dump-0.4b47.orig/restore/tape.c dump-0.4b47/restore/tape.c
--- dump-0.4b47.orig/restore/tape.c     2022-05-03 10:02:27.000000000 +0000
+++ dump-0.4b47/restore/tape.c  2022-05-03 10:02:27.000000000 +0000
@@ -1805,7 +1805,7 @@
                do_compare_error;
        }
 #ifdef  __linux__
-       if (lgetflags(name, &newflags) < 0) {
+       if (lgetflags(name, &newflags, flags) < 0) {
                if (flags != 0) {
                        warn("%s: lgetflags failed", name);
                        do_compare_error;
diff -urN dump-0.4b47.orig/restore/utilities.c dump-0.4b47/restore/utilities.c
--- dump-0.4b47.orig/restore/utilities.c        2022-05-03 10:02:27.000000000 
+0000
+++ dump-0.4b47/restore/utilities.c     2022-05-03 10:02:27.000000000 +0000
@@ -263,7 +263,7 @@
                         */
 #ifdef sunos
 #else
-                       if (lgetflags (existing, &s) != -1 &&
+                       if (lgetflags (existing, &s, 0) != -1 &&
                            lsetflags (existing, 0) != -1) {
                                ret = link(existing, new);
                                lsetflags(existing, s);
@@ -731,7 +731,7 @@
 #endif /* DUMP_MACOSX */
 
 int
-lgetflags(const char *path, unsigned long *flags)
+lgetflags(const char *path, unsigned long *flags, unsigned long inode_flags)
 {
        int err;
        struct stat sb;
@@ -742,7 +742,7 @@
 
        if (S_ISLNK(sb.st_mode) || S_ISFIFO(sb.st_mode)) {
                // no way to get/set flags on a symlink
-               *flags = 0;
+               *flags = inode_flags & EXT4_EXTENTS_FL;
                return 0;
        }
        else

--- End Message ---
--- Begin Message ---
Source: dump
Source-Version: 0.4b47-6
Done: Alexander Zangerl <[email protected]>

We believe that the bug you reported is fixed in the latest version of
dump, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexander Zangerl <[email protected]> (supplier of updated dump package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 06 Oct 2024 11:12:02 +1000
Source: dump
Architecture: source
Version: 0.4b47-6
Distribution: unstable
Urgency: high
Maintainer: Alexander Zangerl <[email protected]>
Changed-By: Alexander Zangerl <[email protected]>
Closes: 1081008 1081009 1081010 1081011
Changes:
 dump (0.4b47-6) unstable; urgency=high
 .
   * applied patches from tim woodall that repair a substantial
     number of compatibility issues
     (closes: #1081008, #1081009, #1081010, #1081011)
   * new -q option for restore
Checksums-Sha1:
 433c168cd2c590c39cc6924b9e946b365aa0c9f6 1907 dump_0.4b47-6.dsc
 7b2c610c084c2f1df365d20b2854b571709f98b7 57832 dump_0.4b47-6.debian.tar.xz
 1cf7e511cb8ddc6787cde7a0f1f834f84bb52ea5 8198 dump_0.4b47-6_amd64.buildinfo
Checksums-Sha256:
 724df1ef108de0c2e8a92bafa95e8e5a1b65b9d0362a5ac986c0757feea602a0 1907 
dump_0.4b47-6.dsc
 47bd200af219dc5e1909da94e0551fa43d85c063c7245b42b7c5c9628dc5b0b7 57832 
dump_0.4b47-6.debian.tar.xz
 262576c8f66c68415bbe5bf93fe1d0154928b2cdd19a252edc6dbf5ef45830a0 8198 
dump_0.4b47-6_amd64.buildinfo
Files:
 27255552bae4c88ed3180ad948d8776d 1907 utils optional dump_0.4b47-6.dsc
 3fab8c0c1e8f97328d3b3b8b53f72223 57832 utils optional 
dump_0.4b47-6.debian.tar.xz
 7094caec6e327f8a7f82629da7ae7e6d 8198 utils optional 
dump_0.4b47-6_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIbBAEBCgAGBQJnAivQAAoJED06g4g30PqNxNoP9RHwi/OVonHkQoDkaxFVrcQr
JZm2T+sZZZQhhce1D+6rnvugKNpuCYQIdFrw4IMNOi0Kj5HQl6x3FM8t3oYkgSmc
uLWKPFI6uJ21sinZnaJCh1cvAh4qbzZu8qeF1M9AEs8D+P4hbbLDJW74E7VCrFCF
z02/gxose+JoDlFPgOOIhc9w/RewveutxD31bDfagjNZ9q5Prp/wHR+WipQqKsm5
ZeZz7+9WpKFEAIoG2xkF4PFKx+M6/HqkP0PjPjjltbkeR4N+P6N3hqjm5HQSTs2Y
o2Io8yXOHIcrXRGp4FYaFHhHJ1UpOtlEEUF5n5Qy5vXMXuTFcLd3kLXfKrBmu0Py
Fm7xtST5bajak2IfZBMMwzy3Z8TstFluYJ1AgWJJjDtACIEdRSWIFOXLrrS3rYTX
8NcmqhDXu9i+pjLUK96U7lGXT7O6RzF/oiilNvBU3LFnqw1BROVigCnSavallDxi
KXtKRT0didKr3tE38gSQJ8K5GrZo+pryIP7zxw7CWQMrWHgBSfwngEdMUFF7lZEw
Ie6LAorl2P2kVJm9cPvnCHDBurxDTpoKQfCkT0DKE9JBhZjz59cEAbqHoZktZIft
nmxl4O9hiWS4/n9Hu2ygeE8OWzc/NMx0uRCSsb23MT7mHcD6j43lYnfV1SSul5rL
RmINxbWAb83GY2utGaQ=
=rfWZ
-----END PGP SIGNATURE-----

Attachment: pgpqVebx9SHBz.pgp
Description: PGP signature


--- End Message ---

Reply via email to