Your message dated Sun, 13 Oct 2024 09:04:31 +0000
with message-id <[email protected]>
and subject line Bug#1084959: fixed in dpkg-source-gitarchive 0.2.2
has caused the Debian Bug report #1084959,
regarding dpkg-source-gitarchive: does not cope with ~ in upstream version
number
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1084959: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084959
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg-source-gitarchive
Version: 0.2.1
Severity: normal
dpkg-source-gitarchive does not properly handle ~ (or presumably other
characters that are valid in version strings but not in git tags).
https://salsa.debian.org/noahm/waagent/-/jobs/6417314#L139 shows an example of
a failure to construct a source package from git.
It may be sufficient to remap ~ or other illegal characters to _, as `gbp`
does. A minimal change could look like the following:
diff --git a/lib/Dpkg/Source/Package/V3/Gitarchive/Git.pm
b/lib/Dpkg/Source/Package/V3/Gitarchive/Git.pm
index 87e0302..98d30a5 100644
--- a/lib/Dpkg/Source/Package/V3/Gitarchive/Git.pm
+++ b/lib/Dpkg/Source/Package/V3/Gitarchive/Git.pm
@@ -68,6 +68,7 @@ sub make_blob {
sub make_blob_diff {
my ($self, $upstream_ref, $name) = @_;
my $diff;
+ $upstream_ref =~ s/~/_/g;
my @exec = (
'git', 'diff-tree',
'--diff-algorithm=myers',
--- End Message ---
--- Begin Message ---
Source: dpkg-source-gitarchive
Source-Version: 0.2.2
Done: Bastian Blank <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dpkg-source-gitarchive, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Blank <[email protected]> (supplier of updated dpkg-source-gitarchive
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 13 Oct 2024 10:50:00 +0200
Source: dpkg-source-gitarchive
Architecture: source
Version: 0.2.2
Distribution: unstable
Urgency: medium
Maintainer: Bastian Blank <[email protected]>
Changed-By: Bastian Blank <[email protected]>
Closes: 1084959
Changes:
dpkg-source-gitarchive (0.2.2) unstable; urgency=medium
.
* Replace illegal characters in git tags. (closes: #1084959)
Checksums-Sha1:
69dcf9d21c43166a8915ae672568e7e732d90e44 1012 dpkg-source-gitarchive_0.2.2.dsc
2f51574ae12d8490bf1726817e24fc07cdce0d45 10832
dpkg-source-gitarchive_0.2.2.tar.xz
1ddf810b17e4c756c9235bdffa25d74b9685c64d 4788
dpkg-source-gitarchive_0.2.2_source.buildinfo
Checksums-Sha256:
d06387214055b76d9cce6b6a635e1b15614d5fd215340f735126c7827d9b421d 1012
dpkg-source-gitarchive_0.2.2.dsc
4c012bc23a2cce779324caee84a2ba0a2d1e197804e78427879ed53dc4135a51 10832
dpkg-source-gitarchive_0.2.2.tar.xz
f62ab7143cb0856f40b75371f1b751bad9e33a63829349b140b67580841c9758 4788
dpkg-source-gitarchive_0.2.2_source.buildinfo
Files:
6b054c92f6c7fd3a51ab9d8c233c0285 1012 admin optional
dpkg-source-gitarchive_0.2.2.dsc
18de3863673b2d632f3851a5178a8bd9 10832 admin optional
dpkg-source-gitarchive_0.2.2.tar.xz
6d8f01634298fb176f6882a068cb78b0 4788 admin optional
dpkg-source-gitarchive_0.2.2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQQ8pEKDNIgQDAQDOBFji0aBW7swjwUCZwuJ7gAKCRBji0aBW7sw
jw1RAP9XC0wtdBRYvDIfeTDSaxenDtazcOnSMUDfUseRwySF1QEAraoP0hqPrS+H
wPyr2GEz5Kcxrz32h5jbM9oV5dM+oQo=
=KdhN
-----END PGP SIGNATURE-----
pgp8cxWvKnx0J.pgp
Description: PGP signature
--- End Message ---
