Your message dated Wed, 30 Oct 2024 23:44:19 +0000
with message-id <[email protected]>
and subject line Bug#449602: fixed in perforate 1.2-6
has caused the Debian Bug report #449602,
regarding perforate: finddup is a damn memory hog
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
449602: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=449602
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: perforate
Version: 1.2-5
Severity: important
Hi
The subject say all - finddup eats all memory.
Looking into it its the Digest::MD5 sum usage of finddup, seems the
author never tested with large files, or lots of files (worth a terabyte
of disc space). Kicking the "addfile" and instead doing a while loop has
two effects:
- does not eat any noticable amount of memory anymore.
(other than whats needed for the file list)
- is noticable faster, for whatever reason.
--- /usr/bin/finddup 2006-08-18 23:09:57.000000000 +0200
+++ /home/joerg/finddup 2007-11-07 00:33:01.827142588 +0100
@@ -131,11 +131,19 @@
sub insert_md5
{
my $file = shift;
+ my $data;
+
if (open(IN, "<", $file->[4]->[0]))
{
- my $md5 = Digest::MD5->new->addfile(*IN)->hexdigest;
- $md5 .= "\t".$file->[1]."\t".$file->[2]."\t".$file->[3] unless $opt->{'ignore-perms'};
+ my $check = Digest::MD5->new;
+ while (sysread(IN, $data, 8192))
+ {
+ $check->add($data);
+ }
close IN;
+ my $md5 = $check->hexdigest;
+
+ $md5 .= "\t".$file->[1]."\t".$file->[2]."\t".$file->[3] unless $opt->{'ignore-perms'};
$md5list{$md5} = [] unless exists $md5list{$md5};
push @{$md5list{$md5}}, $file;
}
--
bye Joerg
Some AM to his NM on [11 Aug. 2004]:
You already won't get through Front Desk and Account Manager approvals before
sarge,[...]
[Note: He made it! :) ]
pgpPpDymInGru.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: perforate
Source-Version: 1.2-6
Done: Andreas Tille <[email protected]>
We believe that the bug you reported is fixed in the latest version of
perforate, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated perforate package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 30 Oct 2024 12:02:34 +0100
Source: perforate
Architecture: source
Version: 1.2-6
Distribution: unstable
Urgency: medium
Maintainer: Package Salvaging Team <[email protected]>
Changed-By: Andreas Tille <[email protected]>
Closes: 406096 449602 564302 940146 1086004
Changes:
perforate (1.2-6) unstable; urgency=medium
.
[ Andreas Tille ]
* Team upload of Package Salvage team
Closes: #1086004
* Set Vcs-Fields (routine-update)
* Standards-Version: 4.7.0 (routine-update)
* debhelper-compat 13 (routine-update)
* Remove trailing whitespace in debian/changelog (routine-update)
* Rules-Requires-Root: no (routine-update)
* Trim trailing whitespace.
* Use secure URI in Homepage field.
* Fix day-of-week for changelog entries 1.0-12, 1.0-11.
* Short dh
* Enable hardening options
* d/copyright: DEP5
.
[ Helmut Grohne ]
* Fix FTCBFS: Let dh_auto_build pass cross tools to make. (Closes: #940146)
.
[ Reuben Thomas ]
* Fix typos (Closes: #564302)
* More appropriate wording in README.Debian
Closes: #406096
* finddup: read files BUFSIZ bytes at a time (Closes: #449602)
.
[ наб ]
* d/NEWS: this package is otiose and will be removed from forky, use
normal coreutils/util-linux functionality
Checksums-Sha1:
958a6a1fca35191d1099d954d7120ac11e66285c 1961 perforate_1.2-6.dsc
72101a8e55459fa7abccd9c714aedd8ab0acebaf 12492 perforate_1.2-6.debian.tar.xz
1228dd84c398f52f9031ababfcf0db8fed1edcae 6048 perforate_1.2-6_amd64.buildinfo
Checksums-Sha256:
258090d486d0c0572a7f005f8059b70efb05ca8f0d9e5dc3c455869e61f7cee4 1961
perforate_1.2-6.dsc
bee69d37866f9c9acf544a67b30542c291644f1285cf5f0f0bd8d0bb3b89a4d9 12492
perforate_1.2-6.debian.tar.xz
8dce350635a8ed83cc2d314316d88aeced2998bf1dfe434a2bb4dd6f3765f486 6048
perforate_1.2-6_amd64.buildinfo
Files:
8f763356d0cca8e0ec90b3981e71028f 1961 utils optional perforate_1.2-6.dsc
488820265f0df92293264dd6207cb17a 12492 utils optional
perforate_1.2-6.debian.tar.xz
cb68e9ef5afd80b350c5e4f46de51fab 6048 utils optional
perforate_1.2-6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmciFOYRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtFm7Q/+POeH3u7Vu5Jy2drKUE4yCKEzhC+lEOPh
M1Q15LntNbceExeudd82815YC0gl5ySCXp02YxUjp2JSO50T8MchjoFDoc7gvz1Z
+dN4amXS2Chr0lTycNZucnyn4iM6I7kUmbkgHS9ml+7IuLU4v5sfeHlo9s/cwHeP
Bv5PK00vY05Nu+5wynfcRnpS/CcNF0He5qviDUzsKBVcTLglwLcq01Xjkm51v+J8
++Ech9IR5iw2Y5otzzFFmSxenin6AiKKvVq4Synboilj1fpH6UDDDWySZdiwRF2/
LDxee/pLiICe4KDX634d+jtP6pYECQc15ei11wPQBv/7P4Xa2BEdexWEvT1fAF4q
yD8+ArLaNsuPWAVPAwbKdxwwnTR4XtUexl4WPIWbWtUhWTqSbjGxArL+16ZdkEUm
MPN5aQykFBPBBrt903yVv77uTxQ/FgQVf+lPqPPtPsy8yf/EPQlJO5Xh8OB9zFyk
c/l33ry/WOfK4mS3PtuTtFLvrI/vA2+I/gK+xNYuX2iGX3vt+uqIXQABzuN2eJFG
oDq65cYBS7OTCJ30j4MoIaF9P5KW0VCJbViLZO8M8mjedCzhvHhgn81CW5Z3JvWf
Qy0jOZlxdU91s9/u7yF78dVPSj4eMmjEeMzs+9FLVkNaNltgMKPz1WCnD2tg0t3P
aNKq1qibUhQ=
=DxK2
-----END PGP SIGNATURE-----
pgp_8UFAMoDfy.pgp
Description: PGP signature
--- End Message ---
