Your message dated Fri, 01 Nov 2024 19:58:34 +0000
with message-id <[email protected]>
and subject line Bug#1086510: fixed in rust-bindgen 0.66.1-11
has caused the Debian Bug report #1086510,
regarding bindgen: bug triggers future kernel build error (fixed upstream)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1086510: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086510
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bindgen
X-Debbugs-Cc: [email protected], [email protected], [email protected]
Version: 0.66.1-7+b2
Severity: important
Tags: patch, fixed-upstream
Hi,
Current Sid's `bindgen` will run into a kernel build failure in the
future (in a few weeks, when the new tracepoints support gets merged):
$ bindgen --version --verbose
bindgen 0.66.1
Clang: Debian clang version 19.1.2 (2)
$ make LLVM=1 samples/rust/rust_print.o
...
error[E0425]: cannot find value `__tracepoint_rust_sample_loaded` in crate
`$crate::bindings`
--> samples/rust/rust_print.rs:87:5
...
The issue triggers with `bindgen` < 0.69.5 && `libclang` >= 19.1. Debian
Testing is fine (at least the `debian:testing` image), since `libclang`
is older there.
Upstream has a fix (released for 0.70.0 and backported to 0.69.5) at:
https://github.com/rust-lang/rust-bindgen/pull/2824
600f63895f73 ("Use clang_getFileLocation instead of
clang_getSpellingLocation")
35f0f9aafc9b ("Use clang_getFileLocation instead of
clang_getSpellingLocation")
It is a single line change which can be cleanly cherry-picked into
`bindgen` 0.66.1.
I confirmed the change would fix the issue (using `debian:sid` image): I
downloaded the Sid package sources (rust-bindgen and rust-bindgen-cli),
built the kernel to confirm the issue is there, then applied the single
line change to the sources, built the kernel again successfully.
Upgrading to `bindgen 0.70.x` should also fix the issue.
The consequence of not doing anything would be that kernel developers
using Debian would need to install a custom/newer `bindgen`, possibly
via `cargo`, instead of using their distribution package, which would be
inconvenient for them -- we are trying to keep the kernel buildable with
distributions' toolchains, e.g. see our instructions for Debian at:
https://docs.kernel.org/rust/quick-start.html#debian
Backport PR by NoisyCoil at:
https://salsa.debian.org/rust-team/debcargo-conf/-/merge_requests/771
Thanks!
Cheers,
Miguel
--- End Message ---
--- Begin Message ---
Source: rust-bindgen
Source-Version: 0.66.1-11
Done: NoisyCoil <[email protected]>
We believe that the bug you reported is fixed in the latest version of
rust-bindgen, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
NoisyCoil <[email protected]> (supplier of updated rust-bindgen package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 01 Nov 2024 20:04:35 +0100
Source: rust-bindgen
Architecture: source
Version: 0.66.1-11
Distribution: unstable
Urgency: medium
Maintainer: Debian Rust Maintainers
<[email protected]>
Changed-By: NoisyCoil <[email protected]>
Closes: 1086510
Changes:
rust-bindgen (0.66.1-11) unstable; urgency=medium
.
* Team upload.
* Package bindgen 0.66.1 from crates.io using debcargo 2.7.2
* d/patches: add use-clang-getfilelocation.patch - fix
SourceLocation::location
for libclang >= 19.1.0 (Closes: #1086510)
Checksums-Sha1:
6b9129f92ee944090d8e469ae14c6955b5b807b1 2561 rust-bindgen_0.66.1-11.dsc
a9b7a95523f0d546566f49d971f4afff4ee12b22 11088
rust-bindgen_0.66.1-11.debian.tar.xz
323939c09a01569ff88854b38cacb5bf9b60e410 11645
rust-bindgen_0.66.1-11_amd64.buildinfo
Checksums-Sha256:
92aa6357a8ca0b9863d587d2c6a1c29f111d0d36e9d59b1c4dd49ac1b80ecae5 2561
rust-bindgen_0.66.1-11.dsc
ea83eb40dc19a866eb7ecbdd903584ee717056c3836f6e1d5537f964f52c6626 11088
rust-bindgen_0.66.1-11.debian.tar.xz
52aea1bbec79e566db9cbab0efa6fd8f901252fdcefad791f3e130312fb5f540 11645
rust-bindgen_0.66.1-11_amd64.buildinfo
Files:
8f1e48c55b546165a79bd533916bfab8 2561 rust optional rust-bindgen_0.66.1-11.dsc
c9688a517345cb79092ba5fed4c7ed2a 11088 rust optional
rust-bindgen_0.66.1-11.debian.tar.xz
7184fc14bdb5dad6b6fc66d64a93eca1 11645 rust optional
rust-bindgen_0.66.1-11_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQR+BoBw1e95SwDIqdkdEI5sB8vEBgUCZyUn4QAKCRAdEI5sB8vE
Bi2ZAQDauATfjqrmTeThXW9ydoIwnRaOBjVG89BWBKWEFK7RcAEApmndDuWzAHXe
h48SArgrI0bbO6HTHVg9St56H84Xyw0=
=6RWx
-----END PGP SIGNATURE-----
pgpYU4rG_J0jJ.pgp
Description: PGP signature
--- End Message ---