Your message dated Wed, 06 Nov 2024 23:49:15 +0000
with message-id <[email protected]>
and subject line Bug#1086867: fixed in setserial 2.17-56
has caused the Debian Bug report #1086867,
regarding setserial FTCBFS: does not pass --host to configure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1086867: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086867
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: setserial
Version: 2.17-55
Tags: patch
User: [email protected]
Usertags: ftcbfs
setserial fails to cross build from source, because it does not pass
--host to configure but is being passed a cross compiler. This used to
work, because configure was so ancient but now that it is being
autoreconf'ed, it needs the --host flag. On the flip side, it no longer
needs CC exported.
I also noticed that the packaging confused build and host architecture.
While fixing that part, I noticed that it does not properly trap errors
from debian/rules, because it forgets to set -e for chained commands.
I've also fixed that by not chaining commands.
All of the aspects mentioned above are fixed in the attached patch for
your convenience.
Helmut
diff --minimal -Nru setserial-2.17/debian/changelog
setserial-2.17/debian/changelog
--- setserial-2.17/debian/changelog 2024-07-27 09:39:00.000000000 +0200
+++ setserial-2.17/debian/changelog 2024-11-06 08:30:09.000000000 +0100
@@ -1,3 +1,13 @@
+setserial (2.17-55.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Let dh_auto_configure pass --host to configure.
+ + Fix build vs host confusion.
+ + Fix lack of error trapping. (Policy violation)
+
+ -- Helmut Grohne <[email protected]> Wed, 06 Nov 2024 08:30:09 +0100
+
setserial (2.17-55) unstable; urgency=medium
* debian/rules: use autoreconf (Closes: #1075505)
diff --minimal -Nru setserial-2.17/debian/rules setserial-2.17/debian/rules
--- setserial-2.17/debian/rules 2024-07-27 09:39:00.000000000 +0200
+++ setserial-2.17/debian/rules 2024-11-06 08:30:09.000000000 +0100
@@ -4,12 +4,8 @@
include /usr/share/dpkg/architecture.mk
-ifeq ($(origin CC),default)
-export CC := $(DEB_HOST_GNU_TYPE)-gcc
-endif
DESTDIR = $(CURDIR)/debian/setserial
-arch = $(shell dpkg-architecture -qDEB_BUILD_ARCH)
CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
CFLAGS:=$(shell dpkg-buildflags --get CFLAGS)
CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS)
@@ -26,7 +22,7 @@
endif
autoupdate
dh_autoreconf
- ./configure --prefix=/usr
+ dh_auto_configure
# make both m68k 2.2 and 2.4+ kernels work effectively
#
rm -f gorhack.h
@@ -62,23 +58,22 @@
install -g root -m 755 -o root setserial $(DESTDIR)/usr/bin
install -g root -m 644 -o root setserial.8 \
$(DESTDIR)/usr/share/man/man8/setserial.8
- echo ${arch}
- if [ "${arch}" = "m68k" ] ; then \
- echo "Using rc.serial.m68k" ;\
- install -g root -m 755 -o root rc.serial.m68k \
- $(DESTDIR)/etc/init.d/setserial ; \
- else \
- echo "Using rc.serial" ;\
- install -g root -m 755 -o root rc.serial \
- $(DESTDIR)/etc/init.d/setserial ; \
- install -g root -m 755 -o root rc.etc-setserial \
- $(DESTDIR)/etc/init.d/etc-setserial ; \
- install -g root -m 644 -o root serial.conf
$(DESTDIR)/usr/share/doc/setserial/serial.conf ;\
- # #518313, not used anymore: install -g root -m 644 -o root
debian/setserial.modutils $(DESTDIR)/etc/modutils/setserial ;\
- fi
- if [ "${arch}" = "sparc" ] ; then \
- install -g root -m 644 -o root serial.conf.sparc
$(DESTDIR)/usr/share/doc/setserial/serial.conf ;\
- fi
+ifeq ($(DEB_HOST_ARCH),m68k)
+ echo "Using rc.serial.m68k"
+ install -g root -m 755 -o root rc.serial.m68k \
+ $(DESTDIR)/etc/init.d/setserial
+else
+ echo "Using rc.serial"
+ install -g root -m 755 -o root rc.serial \
+ $(DESTDIR)/etc/init.d/setserial
+ install -g root -m 755 -o root rc.etc-setserial \
+ $(DESTDIR)/etc/init.d/etc-setserial
+ install -g root -m 644 -o root serial.conf
$(DESTDIR)/usr/share/doc/setserial/serial.conf
+ # #518313, not used anymore: install -g root -m 644 -o root
debian/setserial.modutils $(DESTDIR)/etc/modutils/setserial
+endif
+ifeq ($(DEB_HOST_ARCH),sparc)
+ install -g root -m 644 -o root serial.conf.sparc
$(DESTDIR)/usr/share/doc/setserial/serial.conf
+endif
# Lintian overrides
cd debian ; \
--- End Message ---
--- Begin Message ---
Source: setserial
Source-Version: 2.17-56
Done: Thorsten Alteholz <[email protected]>
We believe that the bug you reported is fixed in the latest version of
setserial, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thorsten Alteholz <[email protected]> (supplier of updated setserial package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 06 Nov 2024 23:30:09 +0100
Source: setserial
Architecture: source
Version: 2.17-56
Distribution: unstable
Urgency: medium
Maintainer: Thorsten Alteholz <[email protected]>
Changed-By: Thorsten Alteholz <[email protected]>
Closes: 1086867
Changes:
setserial (2.17-56) unstable; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #1086867)
+ Let dh_auto_configure pass --host to configure.
+ Fix build vs host confusion.
+ Fix lack of error trapping. (Policy violation)
Checksums-Sha1:
e544feaa646e9964ead27b0c3cf23f770c70c923 1964 setserial_2.17-56.dsc
68824494a0b5700f7e999564a59358bf34f79eb1 52437 setserial_2.17.orig.tar.gz
aa459d75941af0bae51f6b6354fe5f1f026be885 56428 setserial_2.17-56.debian.tar.xz
ce42886d421b15a6c57e7e6983a0965256450422 6127 setserial_2.17-56_amd64.buildinfo
Checksums-Sha256:
4fbca327fd9cbe2206df0f7fb2622fff2219b5f85cab14c9fb0545ba1552db36 1964
setserial_2.17-56.dsc
7e4487d320ac31558563424189435d396ddf77953bb23111a17a3d1487b5794a 52437
setserial_2.17.orig.tar.gz
67ba5b199ddb61f8d806250a2e21cb78f342c2f818b7d78b591d0e9ece9c305a 56428
setserial_2.17-56.debian.tar.xz
617f1b3a917a820fb3bc315ef7a635151d35b98c10daecde77b2311be02f79f8 6127
setserial_2.17-56_amd64.buildinfo
Files:
1b683ef11705624d013e04919e727776 1964 comm optional setserial_2.17-56.dsc
c4867d72c41564318e0107745eb7a0f2 52437 comm optional setserial_2.17.orig.tar.gz
fff442088ac8f996d17578d24673a142 56428 comm optional
setserial_2.17-56.debian.tar.xz
fc5087c233e9063f0bda47070b6a5876 6127 comm optional
setserial_2.17-56_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKnBAEBCgCRFiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAmcr+3dfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcTHGRlYmlhbkBh
bHRlaG9sei5kZQAKCRCW/KwNOHtYR4s3D/9LzoGHM2Q81zvWr/yvX9Wqzw4itogH
Zj4DmwIIYdGNDUuJ14oe1aeM23LrglvFY2UxV1Si5a8RKXZR005TZ/delT+HObFA
HMlfkPWpI88Qxg0CkF+eTfWvTkqjVEdCV5Vj1kyf4nB10uC0qssmt53xEbOXr9aR
/pSAEwm2gdN5dsJ+ThYvEEyOY7sd++JJfXjnXkh3YDhPELA+tjDNoBhIB8YzjA/g
1bXAjoYGAmWiTr98fcHF83ByhD+am2RM/H4KFHzc9xKh4aGUSu958olf8ZkK+g3U
dpev+F8sfqc/hkBKFw3D3D0BIYxLbv3gcIe/YZebD+/2cMzx2XI0iOr0dCDmInUE
oW6cxpM8MrGyE4m/0XfCttcdjlveNJiXK3p4vIo+0tcjOcDTJO5XgZuibsMUtkVZ
pm1rmPV11WdFy8x5fFcyyqwBWCjLzy6qzWoxxxQeTZKf3dT3XFGY8QNS0EQzQlKH
rZ0gImYzGpuLTu7Z9fUVB92N0YyzISV4xMwS7j89/UbxtYJ5p1xwzLgMygyaHJ4N
JfkpycA23gLTKHtdDmGz098gzKkWdC/O9yt4m4LA9yv/xOlziDiQvcT/XdtGKWHZ
GBb9M7fMVi1SMH3R1h6nXmRPDKbcpvM6PuGmQa7zTHiUi4zvLTcEVW386tvzxCw4
qq3cWX59fs4DXw==
=XfsK
-----END PGP SIGNATURE-----
pgp3laTckuejI.pgp
Description: PGP signature
--- End Message ---
